All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: Ben Greear <greearb@candelatech.com>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [RFTv2 4/5] ath10k: wait for mgmt tx when flushing too
Date: Thu, 15 May 2014 13:26:47 +0300	[thread overview]
Message-ID: <87vbt79w2g.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQ=05fULptYqAecf-9jsq_aun_NsNT=c2-ZFxm96ymgQdg@mail.gmail.com> (Michal Kazior's message of "Thu, 15 May 2014 09:24:31 +0200")

Michal Kazior <michal.kazior@tieto.com> writes:

> In the meantime if you want to hasten tx queue ps expiration you can
> try to set `ap_detect_out_of_sync_sleeping_sta_time_secs` vdev param
> to 1 second (default is 10 set in firmware if I'm not mistaken). I
> haven't tested it but this should in theory shorten tx credit
> starvation duration and avoid cascade of wmi timeouts (wmi timeout=3
> seconds, max mgmt tx pending=2 x 1 second each=2s worst case) as well
> as should prevent tx flushing from failing (timeout=5). This will not
> prevent from beacon SWBA overruns because tx starvation is still
> possible although it should be faster to recover.
>
> I wonder if it's reasonable to set this vdev param explicitly in
> upstream driver. We should probably consider longest beacon interval
> in effect when calculation the value to set. Thoughts, anyone?

I haven't looked at the details yet but I think that would be a good
idea. Are there any downsides from doing that change?

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2014-05-15 10:27 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-04 11:37 [RFT 0/4] ath10k: fix flushing and tx stalls Michal Kazior
2014-04-04 11:37 ` Michal Kazior
2014-04-04 11:37 ` [RFT 1/4] ath10k: fix wmi-htc tx credit starvation Michal Kazior
2014-04-04 11:37   ` Michal Kazior
2014-04-04 11:37 ` [RFT 2/4] ath10k: rework peer accounting Michal Kazior
2014-04-04 11:37   ` Michal Kazior
2014-04-04 11:37 ` [RFT 3/4] ath10k: wait for mgmt tx when flushing too Michal Kazior
2014-04-04 11:37   ` Michal Kazior
2014-04-04 11:37 ` [RFT 4/4] ath10k: improve tx flushing Michal Kazior
2014-04-04 11:37   ` Michal Kazior
2014-04-08  6:58   ` Kalle Valo
2014-04-08  6:58     ` Kalle Valo
2014-04-04 14:49 ` [RFT 0/4] ath10k: fix flushing and tx stalls Ben Greear
2014-04-04 14:49   ` Ben Greear
2014-04-04 18:31   ` Dave Taht
2014-04-04 18:31     ` Dave Taht
2014-04-07  9:06   ` Michal Kazior
2014-04-07  9:06     ` Michal Kazior
2014-04-07  0:30 ` Ben Greear
2014-04-07  0:30   ` Ben Greear
2014-04-07  1:05   ` Ben Greear
2014-04-07  1:05     ` Ben Greear
2014-04-07  9:11   ` Michal Kazior
2014-04-07  9:11     ` Michal Kazior
2014-04-08  2:31     ` Ben Greear
2014-04-08  2:31       ` Ben Greear
2014-04-08  5:51       ` Michal Kazior
2014-04-08  5:51         ` Michal Kazior
2014-04-08 16:02         ` Ben Greear
2014-04-08 16:02           ` Ben Greear
2014-04-09  6:25           ` Michal Kazior
2014-04-09  6:25             ` Michal Kazior
2014-04-09 17:34             ` Ben Greear
2014-04-09 17:34               ` Ben Greear
2014-04-09 19:29               ` Ben Greear
2014-04-09 19:29                 ` Ben Greear
2014-04-10  3:45               ` Kalle Valo
2014-04-10  3:45                 ` Kalle Valo
2014-04-09 10:48 ` [RFTv2 0/5] ath10k: " Michal Kazior
2014-04-09 10:48   ` Michal Kazior
2014-04-09 10:48   ` [RFTv2 1/5] ath10k: always request htc tx replenishment Michal Kazior
2014-04-09 10:48     ` Michal Kazior
2014-04-09 10:48   ` [RFTv2 2/5] ath10k: fix wmi-htc tx credit starvation Michal Kazior
2014-04-09 10:48     ` Michal Kazior
2015-01-29  1:32     ` YanBo
2015-01-29  1:32       ` YanBo
2015-01-29  7:57       ` Michal Kazior
2015-01-29  7:57         ` Michal Kazior
2015-01-29 16:50         ` Ben Greear
2015-01-29 16:50           ` Ben Greear
2015-02-04 10:57         ` Matti Laakso
     [not found]         ` <54D1FA8F.6030804@elisanet.fi>
2015-02-04 11:27           ` Michal Kazior
2014-04-09 10:48   ` [RFTv2 3/5] ath10k: rework peer accounting Michal Kazior
2014-04-09 10:48     ` Michal Kazior
2014-04-10  6:50     ` Kalle Valo
2014-04-10  6:50       ` Kalle Valo
2014-04-10  6:56       ` Michal Kazior
2014-04-10  6:56         ` Michal Kazior
2014-04-10  6:59     ` Kalle Valo
2014-04-10  6:59       ` Kalle Valo
2014-04-10  7:11       ` Michal Kazior
2014-04-10  7:11         ` Michal Kazior
2014-04-10  7:18         ` Kalle Valo
2014-04-10  7:18           ` Kalle Valo
2014-04-10  7:43           ` Michal Kazior
2014-04-10  7:43             ` Michal Kazior
2014-04-11  6:22             ` Kalle Valo
2014-04-11  6:22               ` Kalle Valo
2014-04-11  6:31         ` Kalle Valo
2014-04-11  6:31           ` Kalle Valo
2014-04-11  4:59     ` Ben Greear
2014-04-11  4:59       ` Ben Greear
2014-04-09 10:48   ` [RFTv2 4/5] ath10k: wait for mgmt tx when flushing too Michal Kazior
2014-04-09 10:48     ` Michal Kazior
2014-05-13 20:09     ` Ben Greear
2014-05-15  7:24       ` Michal Kazior
2014-05-15 10:26         ` Kalle Valo [this message]
2014-05-15 13:05         ` Ben Greear
2014-04-09 10:48   ` [RFTv2 5/5] ath10k: improve tx flushing Michal Kazior
2014-04-09 10:48     ` Michal Kazior
2014-04-09 21:46   ` [RFTv2 0/5] ath10k: ath10k: fix flushing and tx stalls Ben Greear
2014-04-09 21:46     ` Ben Greear
2014-04-09 23:58     ` Ben Greear
2014-04-09 23:58       ` Ben Greear
2014-04-10  5:10       ` Michal Kazior
2014-04-10  5:10         ` Michal Kazior
2014-04-10  5:26         ` Ben Greear
2014-04-10  5:26           ` Ben Greear
2014-04-10  8:50           ` Michal Kazior
2014-04-10  8:50             ` Michal Kazior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vbt79w2g.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=greearb@candelatech.com \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.