All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Michal Kazior <michal.kazior@tieto.com>, ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFTv2 3/5] ath10k: rework peer accounting
Date: Thu, 10 Apr 2014 21:59:11 -0700	[thread overview]
Message-ID: <5347769F.2020808@candelatech.com> (raw)
In-Reply-To: <1397040531-6224-4-git-send-email-michal.kazior@tieto.com>

On 04/09/2014 03:48 AM, Michal Kazior wrote:
> It was troublesome to iterate over peers and
> perform sleepable calls. This will be necessary
> for some upcomming changes to tx flushing.

Just FYI, I tried all yesterday to get my system stable with all
of your RFT patches applied, but it just has all sorts of issues.
I think much of it relates to the management flush logic, perhaps
all the time it spends under lock (including RTNL lock I think)
just makes my system fall apart.

Possibly related to my peculiar environment & firmware, for sure.

I backed out your last two, leaving this one and the two previous,
and it runs better.  I still see the tx-credits hang (this time,
when I tried resetting all 32 stations while transmitting packets),
but at least the stations come up and can transmit packets most of
the time.

Even in the 'mostly working' state, resetting interfaces while
they and other vifs are under heavy packet load can effectively
lock up my user-space app, and things like 'ifconfig -a'
can take 10s of seconds to complete.  So, I probably need
to mitigate more of the sleeps related to flushing somehow.

Thanks,
Ben


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb@candelatech.com>
To: Michal Kazior <michal.kazior@tieto.com>, ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFTv2 3/5] ath10k: rework peer accounting
Date: Thu, 10 Apr 2014 21:59:11 -0700	[thread overview]
Message-ID: <5347769F.2020808@candelatech.com> (raw)
In-Reply-To: <1397040531-6224-4-git-send-email-michal.kazior@tieto.com>

On 04/09/2014 03:48 AM, Michal Kazior wrote:
> It was troublesome to iterate over peers and
> perform sleepable calls. This will be necessary
> for some upcomming changes to tx flushing.

Just FYI, I tried all yesterday to get my system stable with all
of your RFT patches applied, but it just has all sorts of issues.
I think much of it relates to the management flush logic, perhaps
all the time it spends under lock (including RTNL lock I think)
just makes my system fall apart.

Possibly related to my peculiar environment & firmware, for sure.

I backed out your last two, leaving this one and the two previous,
and it runs better.  I still see the tx-credits hang (this time,
when I tried resetting all 32 stations while transmitting packets),
but at least the stations come up and can transmit packets most of
the time.

Even in the 'mostly working' state, resetting interfaces while
they and other vifs are under heavy packet load can effectively
lock up my user-space app, and things like 'ifconfig -a'
can take 10s of seconds to complete.  So, I probably need
to mitigate more of the sleeps related to flushing somehow.

Thanks,
Ben


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


  parent reply	other threads:[~2014-04-11  4:59 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-04 11:37 [RFT 0/4] ath10k: fix flushing and tx stalls Michal Kazior
2014-04-04 11:37 ` Michal Kazior
2014-04-04 11:37 ` [RFT 1/4] ath10k: fix wmi-htc tx credit starvation Michal Kazior
2014-04-04 11:37   ` Michal Kazior
2014-04-04 11:37 ` [RFT 2/4] ath10k: rework peer accounting Michal Kazior
2014-04-04 11:37   ` Michal Kazior
2014-04-04 11:37 ` [RFT 3/4] ath10k: wait for mgmt tx when flushing too Michal Kazior
2014-04-04 11:37   ` Michal Kazior
2014-04-04 11:37 ` [RFT 4/4] ath10k: improve tx flushing Michal Kazior
2014-04-04 11:37   ` Michal Kazior
2014-04-08  6:58   ` Kalle Valo
2014-04-08  6:58     ` Kalle Valo
2014-04-04 14:49 ` [RFT 0/4] ath10k: fix flushing and tx stalls Ben Greear
2014-04-04 14:49   ` Ben Greear
2014-04-04 18:31   ` Dave Taht
2014-04-04 18:31     ` Dave Taht
2014-04-07  9:06   ` Michal Kazior
2014-04-07  9:06     ` Michal Kazior
2014-04-07  0:30 ` Ben Greear
2014-04-07  0:30   ` Ben Greear
2014-04-07  1:05   ` Ben Greear
2014-04-07  1:05     ` Ben Greear
2014-04-07  9:11   ` Michal Kazior
2014-04-07  9:11     ` Michal Kazior
2014-04-08  2:31     ` Ben Greear
2014-04-08  2:31       ` Ben Greear
2014-04-08  5:51       ` Michal Kazior
2014-04-08  5:51         ` Michal Kazior
2014-04-08 16:02         ` Ben Greear
2014-04-08 16:02           ` Ben Greear
2014-04-09  6:25           ` Michal Kazior
2014-04-09  6:25             ` Michal Kazior
2014-04-09 17:34             ` Ben Greear
2014-04-09 17:34               ` Ben Greear
2014-04-09 19:29               ` Ben Greear
2014-04-09 19:29                 ` Ben Greear
2014-04-10  3:45               ` Kalle Valo
2014-04-10  3:45                 ` Kalle Valo
2014-04-09 10:48 ` [RFTv2 0/5] ath10k: " Michal Kazior
2014-04-09 10:48   ` Michal Kazior
2014-04-09 10:48   ` [RFTv2 1/5] ath10k: always request htc tx replenishment Michal Kazior
2014-04-09 10:48     ` Michal Kazior
2014-04-09 10:48   ` [RFTv2 2/5] ath10k: fix wmi-htc tx credit starvation Michal Kazior
2014-04-09 10:48     ` Michal Kazior
2015-01-29  1:32     ` YanBo
2015-01-29  1:32       ` YanBo
2015-01-29  7:57       ` Michal Kazior
2015-01-29  7:57         ` Michal Kazior
2015-01-29 16:50         ` Ben Greear
2015-01-29 16:50           ` Ben Greear
2015-02-04 10:57         ` Matti Laakso
     [not found]         ` <54D1FA8F.6030804@elisanet.fi>
2015-02-04 11:27           ` Michal Kazior
2014-04-09 10:48   ` [RFTv2 3/5] ath10k: rework peer accounting Michal Kazior
2014-04-09 10:48     ` Michal Kazior
2014-04-10  6:50     ` Kalle Valo
2014-04-10  6:50       ` Kalle Valo
2014-04-10  6:56       ` Michal Kazior
2014-04-10  6:56         ` Michal Kazior
2014-04-10  6:59     ` Kalle Valo
2014-04-10  6:59       ` Kalle Valo
2014-04-10  7:11       ` Michal Kazior
2014-04-10  7:11         ` Michal Kazior
2014-04-10  7:18         ` Kalle Valo
2014-04-10  7:18           ` Kalle Valo
2014-04-10  7:43           ` Michal Kazior
2014-04-10  7:43             ` Michal Kazior
2014-04-11  6:22             ` Kalle Valo
2014-04-11  6:22               ` Kalle Valo
2014-04-11  6:31         ` Kalle Valo
2014-04-11  6:31           ` Kalle Valo
2014-04-11  4:59     ` Ben Greear [this message]
2014-04-11  4:59       ` Ben Greear
2014-04-09 10:48   ` [RFTv2 4/5] ath10k: wait for mgmt tx when flushing too Michal Kazior
2014-04-09 10:48     ` Michal Kazior
2014-05-13 20:09     ` Ben Greear
2014-05-15  7:24       ` Michal Kazior
2014-05-15 10:26         ` Kalle Valo
2014-05-15 13:05         ` Ben Greear
2014-04-09 10:48   ` [RFTv2 5/5] ath10k: improve tx flushing Michal Kazior
2014-04-09 10:48     ` Michal Kazior
2014-04-09 21:46   ` [RFTv2 0/5] ath10k: ath10k: fix flushing and tx stalls Ben Greear
2014-04-09 21:46     ` Ben Greear
2014-04-09 23:58     ` Ben Greear
2014-04-09 23:58       ` Ben Greear
2014-04-10  5:10       ` Michal Kazior
2014-04-10  5:10         ` Michal Kazior
2014-04-10  5:26         ` Ben Greear
2014-04-10  5:26           ` Ben Greear
2014-04-10  8:50           ` Michal Kazior
2014-04-10  8:50             ` Michal Kazior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5347769F.2020808@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.