From: "Bjørn Mork" <bjorn@mork.no>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
Patch Tracking <patches@linaro.org>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Nishanth Menon <nm@ti.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Kgene Kim <kgene.kim@samsung.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
linux-tegra@vger.kernel.org, jinchoi@broadcom.com,
Lan Tianyu <tianyu.lan@intel.com>,
Sebastian Capella <sebastian.capella@linaro.org>,
Jonghwan Choi <jhbird.choi@samsung.com>
Subject: Re: [PATCH V4] cpufreq: suspend governors on system suspend/hibernate
Date: Sat, 07 Dec 2013 12:01:54 +0100 [thread overview]
Message-ID: <87vbz0j55p.fsf@nemi.mork.no> (raw)
In-Reply-To: <CAKohpomA9r5a4GkfA-Huh0ectc-hXjSxcdLkJhF6DZvL22yY4w@mail.gmail.com> (Viresh Kumar's message of "Fri, 29 Nov 2013 08:56:08 +0530")
Viresh Kumar <viresh.kumar@linaro.org> writes:
> On 29 November 2013 01:59, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>> So I'm reading this as "the version of the patch in bleeding-edge is OK".
>>
>> I hope that really is the case. :-)
>
> Yeah, that's correct.
Sorry to be making noise here again, but I was eager to verify that the
fixes in v3.13-rc3 were OK on my system. Unfortunately it seems this
patch completely broke suspend for me. Hibernete ended up with a blank
console and no visible activity, without ever writing any image to disk.
There really weren't that many suspects between v3.13-rc2 and v3.13-rc3,
so I went directly to reverting 5a87182aa21d ("cpufreq: suspend
governors on system suspend/hibernate") which fixed the problem. I
didn't bother debugging it further from there. I don't think there is
anything magic about my system which should make this problem specific
to it.
I am still using the acpi-cpufreq driver on an old x86_64 laptop if that
matters.
Bj√∏rn
WARNING: multiple messages have this Message-ID (diff)
From: "Bjørn Mork" <bjorn@mork.no>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
Patch Tracking <patches@linaro.org>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Nishanth Menon <nm@ti.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Kgene Kim <kgene.kim@samsung.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
linux-tegra@vger.kernel.org, jinchoi@broadcom.com,
Lan Tianyu <tianyu.lan@intel.com>,
Sebastian Capella <sebastian.capella@linaro.org>,
Jonghwan Choi <jhbird.choi@samsung.com>
Subject: Re: [PATCH V4] cpufreq: suspend governors on system suspend/hibernate
Date: Sat, 07 Dec 2013 12:01:54 +0100 [thread overview]
Message-ID: <87vbz0j55p.fsf@nemi.mork.no> (raw)
In-Reply-To: <CAKohpomA9r5a4GkfA-Huh0ectc-hXjSxcdLkJhF6DZvL22yY4w@mail.gmail.com> (Viresh Kumar's message of "Fri, 29 Nov 2013 08:56:08 +0530")
Viresh Kumar <viresh.kumar@linaro.org> writes:
> On 29 November 2013 01:59, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>> So I'm reading this as "the version of the patch in bleeding-edge is OK".
>>
>> I hope that really is the case. :-)
>
> Yeah, that's correct.
Sorry to be making noise here again, but I was eager to verify that the
fixes in v3.13-rc3 were OK on my system. Unfortunately it seems this
patch completely broke suspend for me. Hibernete ended up with a blank
console and no visible activity, without ever writing any image to disk.
There really weren't that many suspects between v3.13-rc2 and v3.13-rc3,
so I went directly to reverting 5a87182aa21d ("cpufreq: suspend
governors on system suspend/hibernate") which fixed the problem. I
didn't bother debugging it further from there. I don't think there is
anything magic about my system which should make this problem specific
to it.
I am still using the acpi-cpufreq driver on an old x86_64 laptop if that
matters.
Bjørn
WARNING: multiple messages have this Message-ID (diff)
From: "Bjørn Mork" <bjorn@mork.no>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
Patch Tracking <patches@linaro.org>,
"cpufreq\@vger.kernel.org" <cpufreq@vger.kernel.org>,
"linux-pm\@vger.kernel.org" <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Nishanth Menon <nm@ti.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Kgene Kim <kgene.kim@samsung.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
linux-tegra@vger.kernel.org, jinchoi@broadcom.com,
Lan Tianyu <tianyu.lan@intel.com>,
Sebastian Capella <sebastian.capella@linaro.org>,
Jonghwan Choi <jhbird.choi@samsung.com>
Subject: Re: [PATCH V4] cpufreq: suspend governors on system suspend/hibernate
Date: Sat, 07 Dec 2013 12:01:54 +0100 [thread overview]
Message-ID: <87vbz0j55p.fsf@nemi.mork.no> (raw)
In-Reply-To: <CAKohpomA9r5a4GkfA-Huh0ectc-hXjSxcdLkJhF6DZvL22yY4w@mail.gmail.com> (Viresh Kumar's message of "Fri, 29 Nov 2013 08:56:08 +0530")
Viresh Kumar <viresh.kumar@linaro.org> writes:
> On 29 November 2013 01:59, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>> So I'm reading this as "the version of the patch in bleeding-edge is OK".
>>
>> I hope that really is the case. :-)
>
> Yeah, that's correct.
Sorry to be making noise here again, but I was eager to verify that the
fixes in v3.13-rc3 were OK on my system. Unfortunately it seems this
patch completely broke suspend for me. Hibernete ended up with a blank
console and no visible activity, without ever writing any image to disk.
There really weren't that many suspects between v3.13-rc2 and v3.13-rc3,
so I went directly to reverting 5a87182aa21d ("cpufreq: suspend
governors on system suspend/hibernate") which fixed the problem. I
didn't bother debugging it further from there. I don't think there is
anything magic about my system which should make this problem specific
to it.
I am still using the acpi-cpufreq driver on an old x86_64 laptop if that
matters.
Bjørn
next prev parent reply other threads:[~2013-12-07 11:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 3:39 [PATCH V4] cpufreq: suspend governors on system suspend/hibernate Viresh Kumar
2013-11-28 14:23 ` Rafael J. Wysocki
2013-11-28 14:19 ` Viresh Kumar
2013-11-28 20:29 ` Rafael J. Wysocki
2013-11-29 3:26 ` Viresh Kumar
2013-12-07 11:01 ` Bjørn Mork [this message]
2013-12-07 11:01 ` Bjørn Mork
2013-12-07 11:01 ` Bjørn Mork
2013-12-07 15:24 ` Paul Bolle
2013-12-07 15:24 ` Paul Bolle
2013-12-08 0:34 ` Rafael J. Wysocki
2013-12-08 0:34 ` Rafael J. Wysocki
[not found] ` <3466098.C5M665z3nb-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2013-12-08 12:41 ` Borislav Petkov
2013-12-08 12:41 ` Borislav Petkov
2013-12-08 12:41 ` Borislav Petkov
2013-12-12 1:50 ` Rafael J. Wysocki
2013-12-12 1:50 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vbz0j55p.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=cpufreq@vger.kernel.org \
--cc=jhbird.choi@samsung.com \
--cc=jinchoi@broadcom.com \
--cc=kgene.kim@samsung.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=nm@ti.com \
--cc=patches@linaro.org \
--cc=rjw@rjwysocki.net \
--cc=sebastian.capella@linaro.org \
--cc=swarren@wwwdotorg.org \
--cc=tianyu.lan@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.