Re: [PATCH] Add an array that describes which opcodes are supported by the RDWR and SHEEPDOG backends.

[Hitoshi Mitake <mitake.hitoshi@gmail.com>]

Hi Ronnie,

At Sat, 12 Oct 2013 07:38:59 -0700,
Ronnie Sahlberg wrote:
> 
> While RDWR supports all SBC opcodes that TGTD implement SHEEPDOG
> only supports a subset and lacks the following opcodes:
>             WRITE_VERIFY10/12/16 VERIFY10/12/16 PREFETCH10/16
>             WRITE_SAME10/16 UNMAP and ORWRITE
> 
> This allows backends to specify which opcodes it is prepared to process
> and which commands should fail with invalid op code
> and allows SHEEPDOG backed LUNs to respond with INVALID_OP_CODE
> correctly.
> 
> This is most useful for block devices where we have several different backens
> and where some backends only support a subset of the commands
> 
> Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
> ---
>  usr/bs.c          |    8 ++++++++
>  usr/bs_rdwr.c     |   51 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  usr/bs_sheepdog.c |   38 ++++++++++++++++++++++++++++++++++++++
>  usr/scsi.c        |    6 ++++++
>  usr/tgtd.h        |    1 +
>  5 files changed, 104 insertions(+), 0 deletions(-)
> 

Thanks a lot for the change! This patch looks good to me. I'll try to
implement these missing opcode in bs_sheepdog.c, but it will take time
and your solution is a great help.

Thanks,
Hitoshi