From: Markus Armbruster <armbru@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-trivial@nongnu.org, Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v2 12/13] qemu-char: report udb backend errors
Date: Mon, 24 Jun 2013 10:06:17 +0200 [thread overview]
Message-ID: <87vc54ylty.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <1372055996-4072-13-git-send-email-kraxel@redhat.com> (Gerd Hoffmann's message of "Mon, 24 Jun 2013 08:39:55 +0200")
Typo in subject: s/udb/UDP/
Gerd Hoffmann <kraxel@redhat.com> writes:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> qemu-char.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index 7d072a8..dcc91bb 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -2255,6 +2255,8 @@ static CharDriverState *qemu_chr_open_udp(QemuOpts *opts)
>
> fd = inet_dgram_opts(opts, &local_err);
> if (fd < 0) {
> + qerror_report_err(local_err);
> + error_free(local_err);
> return NULL;
> }
> return qemu_chr_open_udp_fd(fd);
Also plugs memory leak on error path. Worth mentioning in commit
message.
WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-trivial@nongnu.org, Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 12/13] qemu-char: report udb backend errors
Date: Mon, 24 Jun 2013 10:06:17 +0200 [thread overview]
Message-ID: <87vc54ylty.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <1372055996-4072-13-git-send-email-kraxel@redhat.com> (Gerd Hoffmann's message of "Mon, 24 Jun 2013 08:39:55 +0200")
Typo in subject: s/udb/UDP/
Gerd Hoffmann <kraxel@redhat.com> writes:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> qemu-char.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index 7d072a8..dcc91bb 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -2255,6 +2255,8 @@ static CharDriverState *qemu_chr_open_udp(QemuOpts *opts)
>
> fd = inet_dgram_opts(opts, &local_err);
> if (fd < 0) {
> + qerror_report_err(local_err);
> + error_free(local_err);
> return NULL;
> }
> return qemu_chr_open_udp_fd(fd);
Also plugs memory leak on error path. Worth mentioning in commit
message.
next prev parent reply other threads:[~2013-06-24 9:05 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 6:39 [Qemu-trivial] [PATCH v2 00/13] A bunch of little socket + chardev fixes Gerd Hoffmann
2013-06-24 6:39 ` [Qemu-devel] " Gerd Hoffmann
2013-06-24 6:39 ` [Qemu-trivial] [PATCH v2 01/13] qemu-socket: zero-initialize SocketAddress Gerd Hoffmann
2013-06-24 6:39 ` [Qemu-devel] " Gerd Hoffmann
2013-06-24 6:39 ` [Qemu-trivial] [PATCH v2 02/13] qemu-socket: drop pointless allocation Gerd Hoffmann
2013-06-24 6:39 ` [Qemu-devel] " Gerd Hoffmann
2013-06-24 8:07 ` [Qemu-trivial] " Markus Armbruster
2013-06-24 8:07 ` Markus Armbruster
2013-06-24 6:39 ` [Qemu-trivial] [PATCH v2 03/13] qemu-socket: catch monitor_get_fd failures Gerd Hoffmann
2013-06-24 6:39 ` [Qemu-devel] " Gerd Hoffmann
2013-06-24 6:39 ` [Qemu-trivial] [PATCH v2 04/13] qemu-char: check optional fields using has_* Gerd Hoffmann
2013-06-24 6:39 ` [Qemu-devel] " Gerd Hoffmann
2013-06-24 6:39 ` [Qemu-trivial] [PATCH v2 05/13] qemu-char: use more specific error_setg_* variants Gerd Hoffmann
2013-06-24 6:39 ` [Qemu-devel] " Gerd Hoffmann
2013-06-24 6:39 ` [Qemu-trivial] [PATCH v2 06/13] qemu-char: print notification to stderr Gerd Hoffmann
2013-06-24 6:39 ` [Qemu-devel] " Gerd Hoffmann
2013-06-24 6:39 ` [Qemu-trivial] [PATCH v2 07/13] qemu-char: fix documentation for telnet+wait socket flags Gerd Hoffmann
2013-06-24 6:39 ` [Qemu-devel] " Gerd Hoffmann
2013-06-24 8:08 ` [Qemu-trivial] " Markus Armbruster
2013-06-24 8:08 ` Markus Armbruster
2013-06-24 6:39 ` [Qemu-trivial] [PATCH v2 08/13] qemu-char: don't leak opts on error Gerd Hoffmann
2013-06-24 6:39 ` [Qemu-devel] " Gerd Hoffmann
2013-06-24 6:39 ` [Qemu-trivial] [PATCH v2 09/13] qemu-char: use ChardevBackendKind in in CharDriver Gerd Hoffmann
2013-06-24 6:39 ` [Qemu-devel] " Gerd Hoffmann
2013-06-24 6:39 ` [Qemu-trivial] [PATCH v2 10/13] qemu-char: minor mux chardev fixes Gerd Hoffmann
2013-06-24 6:39 ` [Qemu-devel] " Gerd Hoffmann
2013-06-24 6:39 ` [Qemu-trivial] [PATCH v2 11/13] qemu-char: add -chardev mux support Gerd Hoffmann
2013-06-24 6:39 ` [Qemu-devel] " Gerd Hoffmann
2013-06-24 6:39 ` [Qemu-trivial] [PATCH v2 12/13] qemu-char: report udb backend errors Gerd Hoffmann
2013-06-24 6:39 ` [Qemu-devel] " Gerd Hoffmann
2013-06-24 8:06 ` Markus Armbruster [this message]
2013-06-24 8:06 ` Markus Armbruster
2013-06-24 6:39 ` [Qemu-trivial] [PATCH v2 13/13] qemu-socket: don't leak opts on error Gerd Hoffmann
2013-06-24 6:39 ` [Qemu-devel] " Gerd Hoffmann
2013-06-24 7:18 ` [Qemu-trivial] [PATCH v2 00/13] A bunch of little socket + chardev fixes Michael Tokarev
2013-06-24 7:18 ` [Qemu-devel] " Michael Tokarev
2013-06-24 8:14 ` [Qemu-trivial] [Qemu-devel] " Markus Armbruster
2013-06-24 8:14 ` [Qemu-devel] [Qemu-trivial] " Markus Armbruster
2013-06-24 8:24 ` [Qemu-trivial] [Qemu-devel] " Michael Tokarev
2013-06-24 8:24 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-06-24 8:57 ` [Qemu-trivial] [Qemu-devel] " Markus Armbruster
2013-06-24 8:57 ` [Qemu-devel] [Qemu-trivial] " Markus Armbruster
2013-06-24 8:54 ` [Qemu-trivial] [Qemu-devel] " Laszlo Ersek
2013-06-24 8:54 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vc54ylty.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.