From: Rusty Russell <rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: paul-inf54ven1CmVyaH7bEyXVA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
mhocko-AlSwsSmVLrQ@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [PATCH 06/13] cpuset: cleanup cpuset[_can]_attach()
Date: Mon, 07 Jan 2013 09:58:22 +1030 [thread overview]
Message-ID: <87vcb951t5.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20130103022911.GH11220-9pTldWuhBndy/B6EtB590w@public.gmane.org>
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> writes:
> Hello, Rusty.
>
> On Thu, Jan 03, 2013 at 11:17:11AM +1030, Rusty Russell wrote:
>> > So, I guess this currently is caught in a place which isn't here or
>> > there. I'm pretty skeptical whether it makes sense to bother about
>> > static usages tho. Can I keep them for static ones?
>>
>> I didn't realize that cpuset_attach was a fastpath. If it is, put a
>
> It isn't a hot path. It's just a bit nasty to have to allocate them
> separately.
>
>> static there and I'll fix turn it into a bitmap when I need to.
>> Otherwise, please don't change the code in the first place.
>
> So, the plan to drop cpumask_t is still on? If so, I'll leave
> cpumask_var_t.
Yep!
Thanks,
Rusty.
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Tejun Heo <tj@kernel.org>
Cc: Li Zefan <lizefan@huawei.com>,
paul@paulmenage.org, glommer@parallels.com,
containers@lists.linux-foundation.org, cgroups@vger.kernel.org,
peterz@infradead.org, mhocko@suse.cz, bsingharora@gmail.com,
hannes@cmpxchg.org, kamezawa.hiroyu@jp.fujitsu.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/13] cpuset: cleanup cpuset[_can]_attach()
Date: Mon, 07 Jan 2013 09:58:22 +1030 [thread overview]
Message-ID: <87vcb951t5.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20130103022911.GH11220@mtj.dyndns.org>
Tejun Heo <tj@kernel.org> writes:
> Hello, Rusty.
>
> On Thu, Jan 03, 2013 at 11:17:11AM +1030, Rusty Russell wrote:
>> > So, I guess this currently is caught in a place which isn't here or
>> > there. I'm pretty skeptical whether it makes sense to bother about
>> > static usages tho. Can I keep them for static ones?
>>
>> I didn't realize that cpuset_attach was a fastpath. If it is, put a
>
> It isn't a hot path. It's just a bit nasty to have to allocate them
> separately.
>
>> static there and I'll fix turn it into a bitmap when I need to.
>> Otherwise, please don't change the code in the first place.
>
> So, the plan to drop cpumask_t is still on? If so, I'll leave
> cpumask_var_t.
Yep!
Thanks,
Rusty.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Tejun Heo <tj@kernel.org>
Cc: Li Zefan <lizefan@huawei.com>,
paul@paulmenage.org, glommer@parallels.com,
containers@lists.linux-foundation.org, cgroups@vger.kernel.org,
peterz@infradead.org, mhocko@suse.cz, bsingharora@gmail.com,
hannes@cmpxchg.org, kamezawa.hiroyu@jp.fujitsu.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/13] cpuset: cleanup cpuset[_can]_attach()
Date: Mon, 07 Jan 2013 09:58:22 +1030 [thread overview]
Message-ID: <87vcb951t5.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20130103022911.GH11220@mtj.dyndns.org>
Tejun Heo <tj@kernel.org> writes:
> Hello, Rusty.
>
> On Thu, Jan 03, 2013 at 11:17:11AM +1030, Rusty Russell wrote:
>> > So, I guess this currently is caught in a place which isn't here or
>> > there. I'm pretty skeptical whether it makes sense to bother about
>> > static usages tho. Can I keep them for static ones?
>>
>> I didn't realize that cpuset_attach was a fastpath. If it is, put a
>
> It isn't a hot path. It's just a bit nasty to have to allocate them
> separately.
>
>> static there and I'll fix turn it into a bitmap when I need to.
>> Otherwise, please don't change the code in the first place.
>
> So, the plan to drop cpumask_t is still on? If so, I'll leave
> cpumask_var_t.
Yep!
Thanks,
Rusty.
next prev parent reply other threads:[~2013-01-06 23:28 UTC|newest]
Thread overview: 138+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 21:34 [PATCHSET cgroup/for-3.8] cpuset: decouple cpuset locking from cgroup core Tejun Heo
2012-11-28 21:34 ` Tejun Heo
2012-11-28 21:34 ` Tejun Heo
2012-11-28 21:34 ` [PATCH 01/13] cpuset: remove unused cpuset_unlock() Tejun Heo
2012-11-28 21:34 ` Tejun Heo
2012-11-28 21:34 ` [PATCH 03/13] cpuset: introduce ->css_on/offline() Tejun Heo
2012-11-28 21:34 ` Tejun Heo
2012-11-28 21:34 ` [PATCH 04/13] cpuset: introduce CS_ONLINE Tejun Heo
2012-11-28 21:34 ` Tejun Heo
2012-11-28 21:34 ` [PATCH 05/13] cpuset: introduce cpuset_for_each_child() Tejun Heo
2012-11-28 21:34 ` Tejun Heo
2012-11-28 21:34 ` [PATCH 06/13] cpuset: cleanup cpuset[_can]_attach() Tejun Heo
2012-11-28 21:34 ` Tejun Heo
[not found] ` <1354138460-19286-7-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2012-12-26 10:20 ` Li Zefan
2012-12-26 10:20 ` Li Zefan
2012-12-26 10:20 ` Li Zefan
[not found] ` <50DACF5B.6050705-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2012-12-26 12:04 ` Tejun Heo
2012-12-26 12:04 ` Tejun Heo
2012-12-26 12:04 ` Tejun Heo
2012-12-26 12:04 ` Tejun Heo
[not found] ` <20121226120415.GA18193-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-01-02 4:42 ` Rusty Russell
2013-01-02 4:42 ` Rusty Russell
2013-01-02 4:42 ` Rusty Russell
[not found] ` <87zk0s5h7c.fsf-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>
2013-01-02 15:34 ` Tejun Heo
2013-01-02 15:34 ` Tejun Heo
2013-01-02 15:34 ` Tejun Heo
2013-01-03 0:47 ` Rusty Russell
2013-01-03 0:47 ` Rusty Russell
[not found] ` <871ue35bzk.fsf-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>
2013-01-03 2:29 ` Tejun Heo
2013-01-03 2:29 ` Tejun Heo
2013-01-03 2:29 ` Tejun Heo
[not found] ` <20130103022911.GH11220-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-01-06 23:28 ` Rusty Russell [this message]
2013-01-06 23:28 ` Rusty Russell
2013-01-06 23:28 ` Rusty Russell
[not found] ` <20130102153439.GA11220-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-01-03 0:47 ` Rusty Russell
2012-11-28 21:34 ` [PATCH 07/13] cpuset: drop async_rebuild_sched_domains() Tejun Heo
2012-11-28 21:34 ` Tejun Heo
2012-11-28 21:34 ` [PATCH 08/13] cpuset: reorganize CPU / memory hotplug handling Tejun Heo
2012-11-28 21:34 ` Tejun Heo
2012-11-28 21:34 ` [PATCH 09/13] cpuset: don't nest cgroup_mutex inside get_online_cpus() Tejun Heo
2012-11-28 21:34 ` Tejun Heo
2012-11-28 21:34 ` [PATCH 10/13] cpuset: make CPU / memory hotplug propagation asynchronous Tejun Heo
2012-11-28 21:34 ` Tejun Heo
2012-11-28 21:34 ` [PATCH 11/13] cpuset: pin down cpus and mems while a task is being attached Tejun Heo
2012-11-28 21:34 ` Tejun Heo
2012-11-28 21:34 ` [PATCH 12/13] cpuset: schedule hotplug propagation from cpuset_attach() if the cpuset is empty Tejun Heo
2012-11-28 21:34 ` Tejun Heo
2012-11-28 21:34 ` [PATCH 13/13] cpuset: replace cgroup_mutex locking with cpuset internal locking Tejun Heo
2012-11-28 21:34 ` Tejun Heo
[not found] ` <1354138460-19286-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2012-11-28 21:34 ` [PATCH 01/13] cpuset: remove unused cpuset_unlock() Tejun Heo
2012-11-28 21:34 ` [PATCH 02/13] cpuset: remove fast exit path from remove_tasks_in_empty_cpuset() Tejun Heo
2012-11-28 21:34 ` Tejun Heo
2012-11-28 21:34 ` Tejun Heo
2012-11-28 21:34 ` [PATCH 03/13] cpuset: introduce ->css_on/offline() Tejun Heo
2012-11-28 21:34 ` [PATCH 04/13] cpuset: introduce CS_ONLINE Tejun Heo
2012-11-28 21:34 ` [PATCH 05/13] cpuset: introduce cpuset_for_each_child() Tejun Heo
2012-11-28 21:34 ` [PATCH 06/13] cpuset: cleanup cpuset[_can]_attach() Tejun Heo
2012-11-28 21:34 ` [PATCH 07/13] cpuset: drop async_rebuild_sched_domains() Tejun Heo
2012-11-28 21:34 ` [PATCH 08/13] cpuset: reorganize CPU / memory hotplug handling Tejun Heo
2012-11-28 21:34 ` [PATCH 09/13] cpuset: don't nest cgroup_mutex inside get_online_cpus() Tejun Heo
2012-11-28 21:34 ` [PATCH 10/13] cpuset: make CPU / memory hotplug propagation asynchronous Tejun Heo
2012-11-28 21:34 ` [PATCH 11/13] cpuset: pin down cpus and mems while a task is being attached Tejun Heo
2012-11-28 21:34 ` [PATCH 12/13] cpuset: schedule hotplug propagation from cpuset_attach() if the cpuset is empty Tejun Heo
2012-11-28 21:34 ` [PATCH 13/13] cpuset: replace cgroup_mutex locking with cpuset internal locking Tejun Heo
2012-11-29 11:14 ` [PATCHSET cgroup/for-3.8] cpuset: decouple cpuset locking from cgroup core Glauber Costa
2012-11-29 11:14 ` Glauber Costa
2012-11-29 11:14 ` Glauber Costa
[not found] ` <50B743A1.4040405-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-11-29 14:26 ` Tejun Heo
2012-11-29 14:26 ` Tejun Heo
2012-11-29 14:26 ` Tejun Heo
[not found] ` <20121129142646.GD24683-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2012-11-29 14:36 ` Tejun Heo
2012-11-29 14:36 ` Tejun Heo
2012-11-29 14:36 ` Tejun Heo
2012-11-29 14:26 ` Tejun Heo
2012-11-29 11:14 ` Glauber Costa
2012-11-30 3:21 ` Kamezawa Hiroyuki
2012-11-30 3:21 ` Kamezawa Hiroyuki
2012-11-30 3:21 ` Kamezawa Hiroyuki
2012-11-30 8:33 ` Michal Hocko
2012-11-30 8:33 ` Michal Hocko
2012-11-30 9:00 ` Glauber Costa
2012-11-30 9:00 ` Glauber Costa
2012-11-30 9:00 ` Glauber Costa
2012-11-30 9:24 ` Michal Hocko
2012-11-30 9:24 ` Michal Hocko
[not found] ` <20121130092435.GD29317-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-11-30 9:33 ` Glauber Costa
2012-11-30 9:33 ` Glauber Costa
2012-11-30 9:33 ` Glauber Costa
2012-11-30 9:42 ` Glauber Costa
2012-11-30 9:42 ` Glauber Costa
2012-11-30 9:42 ` Glauber Costa
[not found] ` <50B87F84.7040206-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-11-30 9:49 ` Michal Hocko
2012-11-30 9:49 ` Michal Hocko
2012-11-30 9:49 ` Michal Hocko
[not found] ` <20121130094959.GE29317-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-11-30 10:00 ` Glauber Costa
2012-11-30 10:00 ` Glauber Costa
2012-11-30 10:00 ` Glauber Costa
[not found] ` <50B883B5.8020705-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-11-30 14:59 ` Tejun Heo
2012-11-30 14:59 ` Tejun Heo
2012-11-30 14:59 ` Tejun Heo
[not found] ` <20121130145924.GA3873-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2012-11-30 15:09 ` Glauber Costa
2012-11-30 15:09 ` Glauber Costa
2012-11-30 15:09 ` Glauber Costa
2012-11-30 15:09 ` Glauber Costa
2012-12-03 15:22 ` Michal Hocko
2012-12-03 15:22 ` Michal Hocko
2012-12-03 15:22 ` Michal Hocko
2012-12-03 16:53 ` Tejun Heo
2012-12-03 16:53 ` Tejun Heo
[not found] ` <20121203165338.GF19802-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2012-12-06 6:25 ` Li Zefan
2012-12-06 6:25 ` Li Zefan
2012-12-06 6:25 ` Li Zefan
[not found] ` <50C03A3F.7070605-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2012-12-06 13:09 ` Michal Hocko
2012-12-06 13:09 ` Michal Hocko
2012-12-06 13:09 ` Michal Hocko
[not found] ` <20121206130904.GC10931-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-12-06 16:54 ` Tejun Heo
2012-12-06 16:54 ` Tejun Heo
2012-12-06 16:54 ` Tejun Heo
[not found] ` <20121203152205.GB17093-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-12-03 16:53 ` Tejun Heo
2012-12-03 15:22 ` Michal Hocko
2012-12-26 10:51 ` Li Zefan
2012-12-26 10:51 ` Li Zefan
2012-12-26 10:51 ` Li Zefan
2013-01-02 8:53 ` Michal Hocko
2013-01-02 8:53 ` Michal Hocko
[not found] ` <20130102085355.GA22160-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-01-02 15:36 ` Tejun Heo
2013-01-02 15:36 ` Tejun Heo
2013-01-02 15:36 ` Tejun Heo
[not found] ` <20130102153605.GB11220-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-01-02 16:02 ` Michal Hocko
2013-01-02 16:02 ` Michal Hocko
2013-01-02 16:02 ` Michal Hocko
[not found] ` <50DAD696.8050400-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-01-02 8:53 ` Michal Hocko
2013-01-03 22:20 ` Tejun Heo
2013-01-03 22:20 ` Tejun Heo
2013-01-03 22:20 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2013-01-03 21:35 [PATCHSET] cpuset: decouple cpuset locking from cgroup core, take#2 Tejun Heo
[not found] ` <1357248967-24959-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-01-03 21:36 ` [PATCH 06/13] cpuset: cleanup cpuset[_can]_attach() Tejun Heo
2013-01-03 21:36 ` Tejun Heo
2013-01-03 21:36 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vcb951t5.fsf@rustcorp.com.au \
--to=rusty-8n+1lvoiyb80n/f98k4iww@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
--cc=paul-inf54ven1CmVyaH7bEyXVA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.