From: Peter Korsgaard <jacmet@sunsite.dk>
To: "Philip\, Avinash" <avinashphilip@ti.com>
Cc: afzal@ti.com, linux-doc@vger.kernel.org, tony@atomide.com,
artem.bityutskiy@linux.intel.com,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
ivan.djelic@parrot.com, linux-omap@vger.kernel.org,
dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] ARM: OMAP2: gpmc: Add support for BCH ECC scheme
Date: Mon, 15 Oct 2012 20:48:30 +0200 [thread overview]
Message-ID: <87vcebvaf5.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1349274589-11389-4-git-send-email-avinashphilip@ti.com> (Avinash Philip's message of "Wed, 3 Oct 2012 19:59:48 +0530")
>>>>> Philip, Avinash <avinashphilip@ti.com> writes:
> Add support for BCH ECC scheme to gpmc driver and also enabling multi
> sector read/write. This helps in doing single shot NAND page read and
> write.
> ECC engine configurations
> BCH 4 bit support
> 1. write => ECC engine configured in wrap mode 6 and with ecc_size0 as 32.
> 2. read => ECC engine configured in wrap mode 1 and with ecc_size0 as
> 13 and ecc_size1 as 1.
> BCH 8 bit support
> 1. write => ECC engine configured in wrap mode 6 and with ecc_size0 as 32.
> 2. read => ECC engine configured in wrap mode 1 and with ecc_size0 as
> 26 and ecc_size1 as 2.
> Note: For BCH8 ECC bytes set to 14 to make compatible with RBL.
On what device? In the am335x TRM (spruh73f.pdf) figure 26-15 (pg 4273)
the rom code is documented to not use any padding on the ECC bytes
(E.G. oob 2..53):
http://www.ti.com/litv/pdf/spruh73f
I see the driver in the u-boot-am33x tree (ti81xx_nand.c) seems to use
4x14 bytes as well though, so perhaps that's a bug in the documentation
instead?
--
Bye, Peter Korsgaard
WARNING: multiple messages have this Message-ID (diff)
From: Peter Korsgaard <jacmet@sunsite.dk>
To: "Philip, Avinash" <avinashphilip@ti.com>
Cc: dwmw2@infradead.org, artem.bityutskiy@linux.intel.com,
tony@atomide.com, afzal@ti.com, linux-doc@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
ivan.djelic@parrot.com, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] ARM: OMAP2: gpmc: Add support for BCH ECC scheme
Date: Mon, 15 Oct 2012 20:48:30 +0200 [thread overview]
Message-ID: <87vcebvaf5.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1349274589-11389-4-git-send-email-avinashphilip@ti.com> (Avinash Philip's message of "Wed, 3 Oct 2012 19:59:48 +0530")
>>>>> Philip, Avinash <avinashphilip@ti.com> writes:
> Add support for BCH ECC scheme to gpmc driver and also enabling multi
> sector read/write. This helps in doing single shot NAND page read and
> write.
> ECC engine configurations
> BCH 4 bit support
> 1. write => ECC engine configured in wrap mode 6 and with ecc_size0 as 32.
> 2. read => ECC engine configured in wrap mode 1 and with ecc_size0 as
> 13 and ecc_size1 as 1.
> BCH 8 bit support
> 1. write => ECC engine configured in wrap mode 6 and with ecc_size0 as 32.
> 2. read => ECC engine configured in wrap mode 1 and with ecc_size0 as
> 26 and ecc_size1 as 2.
> Note: For BCH8 ECC bytes set to 14 to make compatible with RBL.
On what device? In the am335x TRM (spruh73f.pdf) figure 26-15 (pg 4273)
the rom code is documented to not use any padding on the ECC bytes
(E.G. oob 2..53):
http://www.ti.com/litv/pdf/spruh73f
I see the driver in the u-boot-am33x tree (ti81xx_nand.c) seems to use
4x14 bytes as well though, so perhaps that's a bug in the documentation
instead?
--
Bye, Peter Korsgaard
WARNING: multiple messages have this Message-ID (diff)
From: jacmet@sunsite.dk (Peter Korsgaard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] ARM: OMAP2: gpmc: Add support for BCH ECC scheme
Date: Mon, 15 Oct 2012 20:48:30 +0200 [thread overview]
Message-ID: <87vcebvaf5.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1349274589-11389-4-git-send-email-avinashphilip@ti.com> (Avinash Philip's message of "Wed, 3 Oct 2012 19:59:48 +0530")
>>>>> Philip, Avinash <avinashphilip@ti.com> writes:
> Add support for BCH ECC scheme to gpmc driver and also enabling multi
> sector read/write. This helps in doing single shot NAND page read and
> write.
> ECC engine configurations
> BCH 4 bit support
> 1. write => ECC engine configured in wrap mode 6 and with ecc_size0 as 32.
> 2. read => ECC engine configured in wrap mode 1 and with ecc_size0 as
> 13 and ecc_size1 as 1.
> BCH 8 bit support
> 1. write => ECC engine configured in wrap mode 6 and with ecc_size0 as 32.
> 2. read => ECC engine configured in wrap mode 1 and with ecc_size0 as
> 26 and ecc_size1 as 2.
> Note: For BCH8 ECC bytes set to 14 to make compatible with RBL.
On what device? In the am335x TRM (spruh73f.pdf) figure 26-15 (pg 4273)
the rom code is documented to not use any padding on the ECC bytes
(E.G. oob 2..53):
http://www.ti.com/litv/pdf/spruh73f
I see the driver in the u-boot-am33x tree (ti81xx_nand.c) seems to use
4x14 bytes as well though, so perhaps that's a bug in the documentation
instead?
--
Bye, Peter Korsgaard
WARNING: multiple messages have this Message-ID (diff)
From: Peter Korsgaard <jacmet@sunsite.dk>
To: "Philip\, Avinash" <avinashphilip@ti.com>
Cc: <dwmw2@infradead.org>, <artem.bityutskiy@linux.intel.com>,
<tony@atomide.com>,
afzal@ti.com, linux-doc@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
ivan.djelic@parrot.com, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] ARM: OMAP2: gpmc: Add support for BCH ECC scheme
Date: Mon, 15 Oct 2012 20:48:30 +0200 [thread overview]
Message-ID: <87vcebvaf5.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1349274589-11389-4-git-send-email-avinashphilip@ti.com> (Avinash Philip's message of "Wed, 3 Oct 2012 19:59:48 +0530")
>>>>> Philip, Avinash <avinashphilip@ti.com> writes:
> Add support for BCH ECC scheme to gpmc driver and also enabling multi
> sector read/write. This helps in doing single shot NAND page read and
> write.
> ECC engine configurations
> BCH 4 bit support
> 1. write => ECC engine configured in wrap mode 6 and with ecc_size0 as 32.
> 2. read => ECC engine configured in wrap mode 1 and with ecc_size0 as
> 13 and ecc_size1 as 1.
> BCH 8 bit support
> 1. write => ECC engine configured in wrap mode 6 and with ecc_size0 as 32.
> 2. read => ECC engine configured in wrap mode 1 and with ecc_size0 as
> 26 and ecc_size1 as 2.
> Note: For BCH8 ECC bytes set to 14 to make compatible with RBL.
On what device? In the am335x TRM (spruh73f.pdf) figure 26-15 (pg 4273)
the rom code is documented to not use any padding on the ECC bytes
(E.G. oob 2..53):
http://www.ti.com/litv/pdf/spruh73f
I see the driver in the u-boot-am33x tree (ti81xx_nand.c) seems to use
4x14 bytes as well though, so perhaps that's a bug in the documentation
instead?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2012-10-15 18:48 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-03 14:29 [PATCH 0/4] mtd: nand: OMAP: Add support to use ELM as error correction module Philip, Avinash
2012-10-03 14:29 ` Philip, Avinash
2012-10-03 14:29 ` Philip, Avinash
2012-10-03 14:29 ` Philip, Avinash
2012-10-03 14:29 ` [PATCH 1/4] mtd: nand: omap2: Update nerrors using ecc.strength Philip, Avinash
2012-10-03 14:29 ` Philip, Avinash
2012-10-03 14:29 ` Philip, Avinash
2012-10-03 14:29 ` Philip, Avinash
2012-10-15 18:56 ` Peter Korsgaard
2012-10-15 18:56 ` Peter Korsgaard
2012-10-15 18:56 ` Peter Korsgaard
2012-10-15 18:56 ` Peter Korsgaard
2012-10-23 10:17 ` Philip, Avinash
2012-10-23 10:17 ` Philip, Avinash
2012-10-23 10:17 ` Philip, Avinash
2012-10-03 14:29 ` [PATCH 2/4] mtd: devices: elm: Add support for ELM error correction Philip, Avinash
2012-10-03 14:29 ` Philip, Avinash
2012-10-03 14:29 ` Philip, Avinash
2012-10-03 14:29 ` Philip, Avinash
2012-10-03 15:10 ` Peter Meerwald
2012-10-03 15:10 ` Peter Meerwald
2012-10-03 15:10 ` Peter Meerwald
2012-10-04 7:49 ` Philip, Avinash
2012-10-04 7:49 ` Philip, Avinash
2012-10-04 7:49 ` Philip, Avinash
2012-10-15 19:40 ` Peter Korsgaard
2012-10-15 19:40 ` Peter Korsgaard
2012-10-15 19:40 ` Peter Korsgaard
2012-10-15 19:40 ` Peter Korsgaard
2012-10-23 10:17 ` Philip, Avinash
2012-10-23 10:17 ` Philip, Avinash
2012-10-23 10:17 ` Philip, Avinash
2012-10-03 14:29 ` [PATCH 3/4] ARM: OMAP2: gpmc: Add support for BCH ECC scheme Philip, Avinash
2012-10-03 14:29 ` Philip, Avinash
2012-10-03 14:29 ` Philip, Avinash
2012-10-03 14:29 ` Philip, Avinash
2012-10-03 18:54 ` Ivan Djelic
2012-10-03 18:54 ` Ivan Djelic
2012-10-03 18:54 ` Ivan Djelic
2012-10-04 8:03 ` Philip, Avinash
2012-10-04 8:03 ` Philip, Avinash
2012-10-04 8:03 ` Philip, Avinash
2012-10-04 12:04 ` Ivan Djelic
2012-10-04 12:04 ` Ivan Djelic
2012-10-04 12:04 ` Ivan Djelic
2012-10-15 18:48 ` Peter Korsgaard [this message]
2012-10-15 18:48 ` Peter Korsgaard
2012-10-15 18:48 ` Peter Korsgaard
2012-10-15 18:48 ` Peter Korsgaard
2012-10-23 10:18 ` Philip, Avinash
2012-10-23 10:18 ` Philip, Avinash
2012-10-23 10:18 ` Philip, Avinash
2012-10-03 14:29 ` [PATCH 4/4] mtd: nand: omap2: Add data correction support Philip, Avinash
2012-10-03 14:29 ` Philip, Avinash
2012-10-03 14:29 ` Philip, Avinash
2012-10-03 14:29 ` Philip, Avinash
2012-10-03 19:20 ` Ivan Djelic
2012-10-03 19:20 ` Ivan Djelic
2012-10-03 19:20 ` Ivan Djelic
2012-10-04 10:22 ` Philip, Avinash
2012-10-04 10:22 ` Philip, Avinash
2012-10-04 10:22 ` Philip, Avinash
2012-10-05 8:51 ` Philip, Avinash
2012-10-05 8:51 ` Philip, Avinash
2012-10-05 8:51 ` Philip, Avinash
2012-10-05 14:23 ` Ivan Djelic
2012-10-05 14:23 ` Ivan Djelic
2012-10-05 14:23 ` Ivan Djelic
2012-10-09 12:36 ` Philip, Avinash
2012-10-09 12:36 ` Philip, Avinash
2012-10-09 12:36 ` Philip, Avinash
2012-10-10 17:08 ` Ivan Djelic
2012-10-10 17:08 ` Ivan Djelic
2012-10-10 17:08 ` Ivan Djelic
2012-10-11 5:27 ` Philip, Avinash
2012-10-11 5:27 ` Philip, Avinash
2012-10-11 5:27 ` Philip, Avinash
2012-10-11 8:21 ` Ivan Djelic
2012-10-11 8:21 ` Ivan Djelic
2012-10-11 8:21 ` Ivan Djelic
2012-10-11 8:21 ` Ivan Djelic
2012-10-11 9:05 ` Philip, Avinash
2012-10-11 9:05 ` Philip, Avinash
2012-10-11 9:05 ` Philip, Avinash
2012-10-11 14:41 ` Tony Lindgren
2012-10-11 14:41 ` Tony Lindgren
2012-10-11 14:41 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vcebvaf5.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=afzal@ti.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=avinashphilip@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dwmw2@infradead.org \
--cc=ivan.djelic@parrot.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.