All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: "Palande, Ameya" <ameya.palande@ti.com>
Cc: linux-omap@vger.kernel.org, paul@pwsan.com
Subject: Re: [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL
Date: Mon, 23 Jan 2012 15:34:51 -0800	[thread overview]
Message-ID: <87vco2j8mc.fsf@ti.com> (raw)
In-Reply-To: <CAHFNHeXZKDnHUwjeahsNLk_2QDDuNJ12p2iZnEgCMSCRD99V4g@mail.gmail.com> (Ameya Palande's message of "Fri, 20 Jan 2012 11:52:17 -0800")

"Palande, Ameya" <ameya.palande@ti.com> writes:

> Any update on this?

A descriptive changelog would be helpful here, ideally with a TRM
reference to the correct values such that a reviewer could verify this
quickly.

Also, please Cc linux-arm-kernel@lists.infradead.org for upstream
patches.

Thanks,

Kevin

> On Wed, Jan 18, 2012 at 3:39 PM, Ameya Palande <ameya.palande@ti.com> wrote:
>>
>> Signed-off-by: Ameya Palande <ameya.palande@ti.com>
>> ---
>>  arch/arm/mach-omap2/clock44xx_data.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c
>> index 08e86d7..053cc15 100644
>> --- a/arch/arm/mach-omap2/clock44xx_data.c
>> +++ b/arch/arm/mach-omap2/clock44xx_data.c
>> @@ -953,8 +953,8 @@ static struct dpll_data dpll_usb_dd = {
>>        .modes          = (1 << DPLL_LOW_POWER_BYPASS) | (1 << DPLL_LOCKED),
>>        .autoidle_reg   = OMAP4430_CM_AUTOIDLE_DPLL_USB,
>>        .idlest_reg     = OMAP4430_CM_IDLEST_DPLL_USB,
>> -       .mult_mask      = OMAP4430_DPLL_MULT_MASK,
>> -       .div1_mask      = OMAP4430_DPLL_DIV_MASK,
>> +       .mult_mask      = OMAP4430_DPLL_MULT_USB_MASK,
>> +       .div1_mask      = OMAP4430_DPLL_DIV_0_7_MASK,
>>        .enable_mask    = OMAP4430_DPLL_EN_MASK,
>>        .autoidle_mask  = OMAP4430_AUTO_DPLL_MODE_MASK,
>>        .idlest_mask    = OMAP4430_ST_DPLL_CLK_MASK,
>> --
>> 1.7.4.1
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2012-01-23 23:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-18 23:39 [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL Ameya Palande
2012-01-20 19:52 ` Palande, Ameya
2012-01-23 23:34   ` Kevin Hilman [this message]
2012-01-24  9:53 ` Cousson, Benoit
2012-01-25  1:35   ` Ameya Palande
2012-01-25  1:35     ` Ameya Palande
2012-01-25 19:04     ` Paul Walmsley
2012-01-25 19:04       ` Paul Walmsley
2012-01-25 19:05     ` Paul Walmsley
2012-01-25 19:05       ` Paul Walmsley
2012-01-25 19:46       ` Cousson, Benoit
2012-01-25 19:46         ` Cousson, Benoit
2012-01-25 18:10   ` Turquette, Mike
2012-01-25 22:45     ` Palande, Ameya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vco2j8mc.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=ameya.palande@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.