From: "Cousson, Benoit" <b-cousson@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Ameya Palande <ameya.palande@ti.com>,
mturquette@ti.com, khilman@ti.com, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL
Date: Wed, 25 Jan 2012 20:46:18 +0100 [thread overview]
Message-ID: <4F205C0A.1050502@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1201251204480.5324@utopia.booyaka.com>
Hi Paul,
On 1/25/2012 8:05 PM, Paul Walmsley wrote:
> Hi
>
> one important question first:
>
> On Tue, 24 Jan 2012, Ameya Palande wrote:
>
>> According to OMAP4 TRM Table 3-1183, CM_CLKSEL_DPLL_USB register defines
>> following fields for multiplication and division factors:
>>
>> DPLL_MULT (bits 19:8) DPLL multiplier factor (2 to 4095)
>> DPLL_DIV (bits 7:0) DPLL divider factor (0 to 255)
>>
>> Acked-by: Benoit Cousson<b-cousson@ti.com>
>> Signed-off-by: Ameya Palande<ameya.palande@ti.com>
>
> Have the scripts been updated?
No not yet. The easy fix I was thinking about is to replace this define
by the hexa value of the mask. I can extract directly from the max mult
and max div.
Regards,
Benoit
WARNING: multiple messages have this Message-ID (diff)
From: b-cousson@ti.com (Cousson, Benoit)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL
Date: Wed, 25 Jan 2012 20:46:18 +0100 [thread overview]
Message-ID: <4F205C0A.1050502@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1201251204480.5324@utopia.booyaka.com>
Hi Paul,
On 1/25/2012 8:05 PM, Paul Walmsley wrote:
> Hi
>
> one important question first:
>
> On Tue, 24 Jan 2012, Ameya Palande wrote:
>
>> According to OMAP4 TRM Table 3-1183, CM_CLKSEL_DPLL_USB register defines
>> following fields for multiplication and division factors:
>>
>> DPLL_MULT (bits 19:8) DPLL multiplier factor (2 to 4095)
>> DPLL_DIV (bits 7:0) DPLL divider factor (0 to 255)
>>
>> Acked-by: Benoit Cousson<b-cousson@ti.com>
>> Signed-off-by: Ameya Palande<ameya.palande@ti.com>
>
> Have the scripts been updated?
No not yet. The easy fix I was thinking about is to replace this define
by the hexa value of the mask. I can extract directly from the max mult
and max div.
Regards,
Benoit
next prev parent reply other threads:[~2012-01-25 19:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-18 23:39 [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL Ameya Palande
2012-01-20 19:52 ` Palande, Ameya
2012-01-23 23:34 ` Kevin Hilman
2012-01-24 9:53 ` Cousson, Benoit
2012-01-25 1:35 ` Ameya Palande
2012-01-25 1:35 ` Ameya Palande
2012-01-25 19:04 ` Paul Walmsley
2012-01-25 19:04 ` Paul Walmsley
2012-01-25 19:05 ` Paul Walmsley
2012-01-25 19:05 ` Paul Walmsley
2012-01-25 19:46 ` Cousson, Benoit [this message]
2012-01-25 19:46 ` Cousson, Benoit
2012-01-25 18:10 ` Turquette, Mike
2012-01-25 22:45 ` Palande, Ameya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F205C0A.1050502@ti.com \
--to=b-cousson@ti.com \
--cc=ameya.palande@ti.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@ti.com \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.