* [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL @ 2012-01-18 23:39 Ameya Palande 2012-01-20 19:52 ` Palande, Ameya 2012-01-24 9:53 ` Cousson, Benoit 0 siblings, 2 replies; 14+ messages in thread From: Ameya Palande @ 2012-01-18 23:39 UTC (permalink / raw) To: linux-omap; +Cc: paul, ameya.palande Signed-off-by: Ameya Palande <ameya.palande@ti.com> --- arch/arm/mach-omap2/clock44xx_data.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c index 08e86d7..053cc15 100644 --- a/arch/arm/mach-omap2/clock44xx_data.c +++ b/arch/arm/mach-omap2/clock44xx_data.c @@ -953,8 +953,8 @@ static struct dpll_data dpll_usb_dd = { .modes = (1 << DPLL_LOW_POWER_BYPASS) | (1 << DPLL_LOCKED), .autoidle_reg = OMAP4430_CM_AUTOIDLE_DPLL_USB, .idlest_reg = OMAP4430_CM_IDLEST_DPLL_USB, - .mult_mask = OMAP4430_DPLL_MULT_MASK, - .div1_mask = OMAP4430_DPLL_DIV_MASK, + .mult_mask = OMAP4430_DPLL_MULT_USB_MASK, + .div1_mask = OMAP4430_DPLL_DIV_0_7_MASK, .enable_mask = OMAP4430_DPLL_EN_MASK, .autoidle_mask = OMAP4430_AUTO_DPLL_MODE_MASK, .idlest_mask = OMAP4430_ST_DPLL_CLK_MASK, -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL 2012-01-18 23:39 [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL Ameya Palande @ 2012-01-20 19:52 ` Palande, Ameya 2012-01-23 23:34 ` Kevin Hilman 2012-01-24 9:53 ` Cousson, Benoit 1 sibling, 1 reply; 14+ messages in thread From: Palande, Ameya @ 2012-01-20 19:52 UTC (permalink / raw) To: linux-omap; +Cc: paul, ameya.palande Any update on this? On Wed, Jan 18, 2012 at 3:39 PM, Ameya Palande <ameya.palande@ti.com> wrote: > > Signed-off-by: Ameya Palande <ameya.palande@ti.com> > --- > arch/arm/mach-omap2/clock44xx_data.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c > index 08e86d7..053cc15 100644 > --- a/arch/arm/mach-omap2/clock44xx_data.c > +++ b/arch/arm/mach-omap2/clock44xx_data.c > @@ -953,8 +953,8 @@ static struct dpll_data dpll_usb_dd = { > .modes = (1 << DPLL_LOW_POWER_BYPASS) | (1 << DPLL_LOCKED), > .autoidle_reg = OMAP4430_CM_AUTOIDLE_DPLL_USB, > .idlest_reg = OMAP4430_CM_IDLEST_DPLL_USB, > - .mult_mask = OMAP4430_DPLL_MULT_MASK, > - .div1_mask = OMAP4430_DPLL_DIV_MASK, > + .mult_mask = OMAP4430_DPLL_MULT_USB_MASK, > + .div1_mask = OMAP4430_DPLL_DIV_0_7_MASK, > .enable_mask = OMAP4430_DPLL_EN_MASK, > .autoidle_mask = OMAP4430_AUTO_DPLL_MODE_MASK, > .idlest_mask = OMAP4430_ST_DPLL_CLK_MASK, > -- > 1.7.4.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL 2012-01-20 19:52 ` Palande, Ameya @ 2012-01-23 23:34 ` Kevin Hilman 0 siblings, 0 replies; 14+ messages in thread From: Kevin Hilman @ 2012-01-23 23:34 UTC (permalink / raw) To: Palande, Ameya; +Cc: linux-omap, paul "Palande, Ameya" <ameya.palande@ti.com> writes: > Any update on this? A descriptive changelog would be helpful here, ideally with a TRM reference to the correct values such that a reviewer could verify this quickly. Also, please Cc linux-arm-kernel@lists.infradead.org for upstream patches. Thanks, Kevin > On Wed, Jan 18, 2012 at 3:39 PM, Ameya Palande <ameya.palande@ti.com> wrote: >> >> Signed-off-by: Ameya Palande <ameya.palande@ti.com> >> --- >> arch/arm/mach-omap2/clock44xx_data.c | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c >> index 08e86d7..053cc15 100644 >> --- a/arch/arm/mach-omap2/clock44xx_data.c >> +++ b/arch/arm/mach-omap2/clock44xx_data.c >> @@ -953,8 +953,8 @@ static struct dpll_data dpll_usb_dd = { >> .modes = (1 << DPLL_LOW_POWER_BYPASS) | (1 << DPLL_LOCKED), >> .autoidle_reg = OMAP4430_CM_AUTOIDLE_DPLL_USB, >> .idlest_reg = OMAP4430_CM_IDLEST_DPLL_USB, >> - .mult_mask = OMAP4430_DPLL_MULT_MASK, >> - .div1_mask = OMAP4430_DPLL_DIV_MASK, >> + .mult_mask = OMAP4430_DPLL_MULT_USB_MASK, >> + .div1_mask = OMAP4430_DPLL_DIV_0_7_MASK, >> .enable_mask = OMAP4430_DPLL_EN_MASK, >> .autoidle_mask = OMAP4430_AUTO_DPLL_MODE_MASK, >> .idlest_mask = OMAP4430_ST_DPLL_CLK_MASK, >> -- >> 1.7.4.1 >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL 2012-01-18 23:39 [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL Ameya Palande 2012-01-20 19:52 ` Palande, Ameya @ 2012-01-24 9:53 ` Cousson, Benoit 2012-01-25 1:35 ` Ameya Palande 2012-01-25 18:10 ` Turquette, Mike 1 sibling, 2 replies; 14+ messages in thread From: Cousson, Benoit @ 2012-01-24 9:53 UTC (permalink / raw) To: Ameya Palande, Hilman, Kevin; +Cc: linux-omap, paul, Turquette, Mike + Mike On 1/19/2012 12:39 AM, Ameya Palande wrote: > Signed-off-by: Ameya Palande<ameya.palande@ti.com> Assuming that you will re-send with Kevin's comment taken into account, the fix is indeed very valid. Acked-by: Benoit Cousson <b-cousson@ti.com> > --- > arch/arm/mach-omap2/clock44xx_data.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c > index 08e86d7..053cc15 100644 > --- a/arch/arm/mach-omap2/clock44xx_data.c > +++ b/arch/arm/mach-omap2/clock44xx_data.c > @@ -953,8 +953,8 @@ static struct dpll_data dpll_usb_dd = { > .modes = (1<< DPLL_LOW_POWER_BYPASS) | (1<< DPLL_LOCKED), > .autoidle_reg = OMAP4430_CM_AUTOIDLE_DPLL_USB, > .idlest_reg = OMAP4430_CM_IDLEST_DPLL_USB, > - .mult_mask = OMAP4430_DPLL_MULT_MASK, > - .div1_mask = OMAP4430_DPLL_DIV_MASK, > + .mult_mask = OMAP4430_DPLL_MULT_USB_MASK, > + .div1_mask = OMAP4430_DPLL_DIV_0_7_MASK, We were wrongly assuming that all DPLLs were using the same mask, which cannot be the case for the USB DPLL since that one has a higher max multiplier and max divider than the other ones (4095/256 instead of 2047/128). For Mike and Paul, It is indeed a bug in the clock generator script. Regards, Benoit ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL 2012-01-24 9:53 ` Cousson, Benoit @ 2012-01-25 1:35 ` Ameya Palande 2012-01-25 18:10 ` Turquette, Mike 1 sibling, 0 replies; 14+ messages in thread From: Ameya Palande @ 2012-01-25 1:35 UTC (permalink / raw) To: b-cousson Cc: khilman, linux-omap, paul, mturquette, linux-arm-kernel, ameya.palande According to OMAP4 TRM Table 3-1183, CM_CLKSEL_DPLL_USB register defines following fields for multiplication and division factors: DPLL_MULT (bits 19:8) DPLL multiplier factor (2 to 4095) DPLL_DIV (bits 7:0) DPLL divider factor (0 to 255) Acked-by: Benoit Cousson <b-cousson@ti.com> Signed-off-by: Ameya Palande <ameya.palande@ti.com> --- arch/arm/mach-omap2/clock44xx_data.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c index 08e86d7..053cc15 100644 --- a/arch/arm/mach-omap2/clock44xx_data.c +++ b/arch/arm/mach-omap2/clock44xx_data.c @@ -953,8 +953,8 @@ static struct dpll_data dpll_usb_dd = { .modes = (1 << DPLL_LOW_POWER_BYPASS) | (1 << DPLL_LOCKED), .autoidle_reg = OMAP4430_CM_AUTOIDLE_DPLL_USB, .idlest_reg = OMAP4430_CM_IDLEST_DPLL_USB, - .mult_mask = OMAP4430_DPLL_MULT_MASK, - .div1_mask = OMAP4430_DPLL_DIV_MASK, + .mult_mask = OMAP4430_DPLL_MULT_USB_MASK, + .div1_mask = OMAP4430_DPLL_DIV_0_7_MASK, .enable_mask = OMAP4430_DPLL_EN_MASK, .autoidle_mask = OMAP4430_AUTO_DPLL_MODE_MASK, .idlest_mask = OMAP4430_ST_DPLL_CLK_MASK, -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL @ 2012-01-25 1:35 ` Ameya Palande 0 siblings, 0 replies; 14+ messages in thread From: Ameya Palande @ 2012-01-25 1:35 UTC (permalink / raw) To: linux-arm-kernel According to OMAP4 TRM Table 3-1183, CM_CLKSEL_DPLL_USB register defines following fields for multiplication and division factors: DPLL_MULT (bits 19:8) DPLL multiplier factor (2 to 4095) DPLL_DIV (bits 7:0) DPLL divider factor (0 to 255) Acked-by: Benoit Cousson <b-cousson@ti.com> Signed-off-by: Ameya Palande <ameya.palande@ti.com> --- arch/arm/mach-omap2/clock44xx_data.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c index 08e86d7..053cc15 100644 --- a/arch/arm/mach-omap2/clock44xx_data.c +++ b/arch/arm/mach-omap2/clock44xx_data.c @@ -953,8 +953,8 @@ static struct dpll_data dpll_usb_dd = { .modes = (1 << DPLL_LOW_POWER_BYPASS) | (1 << DPLL_LOCKED), .autoidle_reg = OMAP4430_CM_AUTOIDLE_DPLL_USB, .idlest_reg = OMAP4430_CM_IDLEST_DPLL_USB, - .mult_mask = OMAP4430_DPLL_MULT_MASK, - .div1_mask = OMAP4430_DPLL_DIV_MASK, + .mult_mask = OMAP4430_DPLL_MULT_USB_MASK, + .div1_mask = OMAP4430_DPLL_DIV_0_7_MASK, .enable_mask = OMAP4430_DPLL_EN_MASK, .autoidle_mask = OMAP4430_AUTO_DPLL_MODE_MASK, .idlest_mask = OMAP4430_ST_DPLL_CLK_MASK, -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL 2012-01-25 1:35 ` Ameya Palande @ 2012-01-25 19:04 ` Paul Walmsley -1 siblings, 0 replies; 14+ messages in thread From: Paul Walmsley @ 2012-01-25 19:04 UTC (permalink / raw) To: Ameya Palande Cc: b-cousson, khilman, linux-omap, mturquette, linux-arm-kernel On Tue, 24 Jan 2012, Ameya Palande wrote: > According to OMAP4 TRM Table 3-1183, CM_CLKSEL_DPLL_USB register defines > following fields for multiplication and division factors: > > DPLL_MULT (bits 19:8) DPLL multiplier factor (2 to 4095) > DPLL_DIV (bits 7:0) DPLL divider factor (0 to 255) > > Acked-by: Benoit Cousson <b-cousson@ti.com> > Signed-off-by: Ameya Palande <ameya.palande@ti.com> Thanks, queued for 3.4. - Paul ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL @ 2012-01-25 19:04 ` Paul Walmsley 0 siblings, 0 replies; 14+ messages in thread From: Paul Walmsley @ 2012-01-25 19:04 UTC (permalink / raw) To: linux-arm-kernel On Tue, 24 Jan 2012, Ameya Palande wrote: > According to OMAP4 TRM Table 3-1183, CM_CLKSEL_DPLL_USB register defines > following fields for multiplication and division factors: > > DPLL_MULT (bits 19:8) DPLL multiplier factor (2 to 4095) > DPLL_DIV (bits 7:0) DPLL divider factor (0 to 255) > > Acked-by: Benoit Cousson <b-cousson@ti.com> > Signed-off-by: Ameya Palande <ameya.palande@ti.com> Thanks, queued for 3.4. - Paul ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL 2012-01-25 1:35 ` Ameya Palande @ 2012-01-25 19:05 ` Paul Walmsley -1 siblings, 0 replies; 14+ messages in thread From: Paul Walmsley @ 2012-01-25 19:05 UTC (permalink / raw) To: Ameya Palande, b-cousson, mturquette Cc: khilman, linux-omap, linux-arm-kernel Hi one important question first: On Tue, 24 Jan 2012, Ameya Palande wrote: > According to OMAP4 TRM Table 3-1183, CM_CLKSEL_DPLL_USB register defines > following fields for multiplication and division factors: > > DPLL_MULT (bits 19:8) DPLL multiplier factor (2 to 4095) > DPLL_DIV (bits 7:0) DPLL divider factor (0 to 255) > > Acked-by: Benoit Cousson <b-cousson@ti.com> > Signed-off-by: Ameya Palande <ameya.palande@ti.com> Have the scripts been updated? - Paul ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL @ 2012-01-25 19:05 ` Paul Walmsley 0 siblings, 0 replies; 14+ messages in thread From: Paul Walmsley @ 2012-01-25 19:05 UTC (permalink / raw) To: linux-arm-kernel Hi one important question first: On Tue, 24 Jan 2012, Ameya Palande wrote: > According to OMAP4 TRM Table 3-1183, CM_CLKSEL_DPLL_USB register defines > following fields for multiplication and division factors: > > DPLL_MULT (bits 19:8) DPLL multiplier factor (2 to 4095) > DPLL_DIV (bits 7:0) DPLL divider factor (0 to 255) > > Acked-by: Benoit Cousson <b-cousson@ti.com> > Signed-off-by: Ameya Palande <ameya.palande@ti.com> Have the scripts been updated? - Paul ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL 2012-01-25 19:05 ` Paul Walmsley @ 2012-01-25 19:46 ` Cousson, Benoit -1 siblings, 0 replies; 14+ messages in thread From: Cousson, Benoit @ 2012-01-25 19:46 UTC (permalink / raw) To: Paul Walmsley Cc: Ameya Palande, mturquette, khilman, linux-omap, linux-arm-kernel Hi Paul, On 1/25/2012 8:05 PM, Paul Walmsley wrote: > Hi > > one important question first: > > On Tue, 24 Jan 2012, Ameya Palande wrote: > >> According to OMAP4 TRM Table 3-1183, CM_CLKSEL_DPLL_USB register defines >> following fields for multiplication and division factors: >> >> DPLL_MULT (bits 19:8) DPLL multiplier factor (2 to 4095) >> DPLL_DIV (bits 7:0) DPLL divider factor (0 to 255) >> >> Acked-by: Benoit Cousson<b-cousson@ti.com> >> Signed-off-by: Ameya Palande<ameya.palande@ti.com> > > Have the scripts been updated? No not yet. The easy fix I was thinking about is to replace this define by the hexa value of the mask. I can extract directly from the max mult and max div. Regards, Benoit ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL @ 2012-01-25 19:46 ` Cousson, Benoit 0 siblings, 0 replies; 14+ messages in thread From: Cousson, Benoit @ 2012-01-25 19:46 UTC (permalink / raw) To: linux-arm-kernel Hi Paul, On 1/25/2012 8:05 PM, Paul Walmsley wrote: > Hi > > one important question first: > > On Tue, 24 Jan 2012, Ameya Palande wrote: > >> According to OMAP4 TRM Table 3-1183, CM_CLKSEL_DPLL_USB register defines >> following fields for multiplication and division factors: >> >> DPLL_MULT (bits 19:8) DPLL multiplier factor (2 to 4095) >> DPLL_DIV (bits 7:0) DPLL divider factor (0 to 255) >> >> Acked-by: Benoit Cousson<b-cousson@ti.com> >> Signed-off-by: Ameya Palande<ameya.palande@ti.com> > > Have the scripts been updated? No not yet. The easy fix I was thinking about is to replace this define by the hexa value of the mask. I can extract directly from the max mult and max div. Regards, Benoit ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL 2012-01-24 9:53 ` Cousson, Benoit 2012-01-25 1:35 ` Ameya Palande @ 2012-01-25 18:10 ` Turquette, Mike 2012-01-25 22:45 ` Palande, Ameya 1 sibling, 1 reply; 14+ messages in thread From: Turquette, Mike @ 2012-01-25 18:10 UTC (permalink / raw) To: Cousson, Benoit Cc: Ameya Palande, Hilman, Kevin, linux-omap, paul, Nayak, Rajendra On Tue, Jan 24, 2012 at 1:53 AM, Cousson, Benoit <b-cousson@ti.com> wrote: > + Mike > > On 1/19/2012 12:39 AM, Ameya Palande wrote: >> >> Signed-off-by: Ameya Palande<ameya.palande@ti.com> > > > Assuming that you will re-send with Kevin's comment taken into account, the > fix is indeed very valid. > > Acked-by: Benoit Cousson <b-cousson@ti.com> > >> --- >> arch/arm/mach-omap2/clock44xx_data.c | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/clock44xx_data.c >> b/arch/arm/mach-omap2/clock44xx_data.c >> index 08e86d7..053cc15 100644 >> --- a/arch/arm/mach-omap2/clock44xx_data.c >> +++ b/arch/arm/mach-omap2/clock44xx_data.c >> @@ -953,8 +953,8 @@ static struct dpll_data dpll_usb_dd = { >> .modes = (1<< DPLL_LOW_POWER_BYPASS) | (1<< >> DPLL_LOCKED), >> .autoidle_reg = OMAP4430_CM_AUTOIDLE_DPLL_USB, >> .idlest_reg = OMAP4430_CM_IDLEST_DPLL_USB, >> - .mult_mask = OMAP4430_DPLL_MULT_MASK, >> - .div1_mask = OMAP4430_DPLL_DIV_MASK, >> + .mult_mask = OMAP4430_DPLL_MULT_USB_MASK, >> + .div1_mask = OMAP4430_DPLL_DIV_0_7_MASK, > > > We were wrongly assuming that all DPLLs were using the same mask, which > cannot be the case for the USB DPLL since that one has a higher max > multiplier and max divider than the other ones (4095/256 instead of > 2047/128). > > For Mike and Paul, > > It is indeed a bug in the clock generator script. This DPLL does have some quirks. Rajendra recently solved a bug where .clkdm was not set for this DPLL since it is in the L3INIT clkdm, not an always-on clkdm, so that must also be taken into account in the data generation. Regards, Mike > > Regards, > Benoit -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL 2012-01-25 18:10 ` Turquette, Mike @ 2012-01-25 22:45 ` Palande, Ameya 0 siblings, 0 replies; 14+ messages in thread From: Palande, Ameya @ 2012-01-25 22:45 UTC (permalink / raw) To: Turquette, Mike Cc: Cousson, Benoit, Hilman, Kevin, linux-omap, paul, Nayak, Rajendra Hi Mike, On Wed, Jan 25, 2012 at 10:10 AM, Turquette, Mike <mturquette@ti.com> wrote: > On Tue, Jan 24, 2012 at 1:53 AM, Cousson, Benoit <b-cousson@ti.com> wrote: >> + Mike >> >> On 1/19/2012 12:39 AM, Ameya Palande wrote: >>> >>> Signed-off-by: Ameya Palande<ameya.palande@ti.com> >> >> >> Assuming that you will re-send with Kevin's comment taken into account, the >> fix is indeed very valid. >> >> Acked-by: Benoit Cousson <b-cousson@ti.com> >> >>> --- >>> arch/arm/mach-omap2/clock44xx_data.c | 4 ++-- >>> 1 files changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/arch/arm/mach-omap2/clock44xx_data.c >>> b/arch/arm/mach-omap2/clock44xx_data.c >>> index 08e86d7..053cc15 100644 >>> --- a/arch/arm/mach-omap2/clock44xx_data.c >>> +++ b/arch/arm/mach-omap2/clock44xx_data.c >>> @@ -953,8 +953,8 @@ static struct dpll_data dpll_usb_dd = { >>> .modes = (1<< DPLL_LOW_POWER_BYPASS) | (1<< >>> DPLL_LOCKED), >>> .autoidle_reg = OMAP4430_CM_AUTOIDLE_DPLL_USB, >>> .idlest_reg = OMAP4430_CM_IDLEST_DPLL_USB, >>> - .mult_mask = OMAP4430_DPLL_MULT_MASK, >>> - .div1_mask = OMAP4430_DPLL_DIV_MASK, >>> + .mult_mask = OMAP4430_DPLL_MULT_USB_MASK, >>> + .div1_mask = OMAP4430_DPLL_DIV_0_7_MASK, >> >> >> We were wrongly assuming that all DPLLs were using the same mask, which >> cannot be the case for the USB DPLL since that one has a higher max >> multiplier and max divider than the other ones (4095/256 instead of >> 2047/128). >> >> For Mike and Paul, >> >> It is indeed a bug in the clock generator script. > > This DPLL does have some quirks. Rajendra recently solved a bug where > .clkdm was not set for this DPLL since it is in the L3INIT clkdm, not > an always-on clkdm, so that must also be taken into account in the > data generation. I already submitted that patch for review: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg61444.html Cheers, Ameya. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2012-01-25 22:45 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-01-18 23:39 [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL Ameya Palande 2012-01-20 19:52 ` Palande, Ameya 2012-01-23 23:34 ` Kevin Hilman 2012-01-24 9:53 ` Cousson, Benoit 2012-01-25 1:35 ` Ameya Palande 2012-01-25 1:35 ` Ameya Palande 2012-01-25 19:04 ` Paul Walmsley 2012-01-25 19:04 ` Paul Walmsley 2012-01-25 19:05 ` Paul Walmsley 2012-01-25 19:05 ` Paul Walmsley 2012-01-25 19:46 ` Cousson, Benoit 2012-01-25 19:46 ` Cousson, Benoit 2012-01-25 18:10 ` Turquette, Mike 2012-01-25 22:45 ` Palande, Ameya
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.