* [PATCH] virtio: add HAS_IOMEM dependency to MMIO platform bus driver
@ 2011-11-15 9:13 Heiko Carstens
2011-11-15 10:31 ` Pawel Moll
0 siblings, 1 reply; 3+ messages in thread
From: Heiko Carstens @ 2011-11-15 9:13 UTC (permalink / raw)
To: Rusty Russell
Cc: linux-kernel, Heiko Carstens, Christian Borntraeger, Pawel Moll
Fix this compile error on s390:
CC [M] drivers/virtio/virtio_mmio.o
drivers/virtio/virtio_mmio.c: In function 'vm_get_features':
drivers/virtio/virtio_mmio.c:107:2: error: implicit declaration of function 'writel'
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Pawel Moll <pawel.moll@arm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
drivers/virtio/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
index 816ed08..1a61939 100644
--- a/drivers/virtio/Kconfig
+++ b/drivers/virtio/Kconfig
@@ -37,7 +37,7 @@ config VIRTIO_BALLOON
config VIRTIO_MMIO
tristate "Platform bus driver for memory mapped virtio devices (EXPERIMENTAL)"
- depends on EXPERIMENTAL
+ depends on HAS_IOMEM && EXPERIMENTAL
select VIRTIO
select VIRTIO_RING
---help---
--
1.7.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] virtio: add HAS_IOMEM dependency to MMIO platform bus driver
2011-11-15 9:13 [PATCH] virtio: add HAS_IOMEM dependency to MMIO platform bus driver Heiko Carstens
@ 2011-11-15 10:31 ` Pawel Moll
2011-11-16 0:28 ` Rusty Russell
0 siblings, 1 reply; 3+ messages in thread
From: Pawel Moll @ 2011-11-15 10:31 UTC (permalink / raw)
To: Heiko Carstens
Cc: Rusty Russell, linux-kernel@vger.kernel.org,
Christian Borntraeger
On Tue, 2011-11-15 at 09:13 +0000, Heiko Carstens wrote:
> Fix this compile error on s390:
>
> CC [M] drivers/virtio/virtio_mmio.o
> drivers/virtio/virtio_mmio.c: In function 'vm_get_features':
> drivers/virtio/virtio_mmio.c:107:2: error: implicit declaration of function 'writel'
One learns something new every day :-O
Thanks and apologies for inconvenience!
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Acked-by: Pawel Moll <pawel.moll@arm.com>
Cheers!
Pawel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] virtio: add HAS_IOMEM dependency to MMIO platform bus driver
2011-11-15 10:31 ` Pawel Moll
@ 2011-11-16 0:28 ` Rusty Russell
0 siblings, 0 replies; 3+ messages in thread
From: Rusty Russell @ 2011-11-16 0:28 UTC (permalink / raw)
To: Pawel Moll, Heiko Carstens
Cc: linux-kernel@vger.kernel.org, Christian Borntraeger
On Tue, 15 Nov 2011 10:31:58 +0000, Pawel Moll <pawel.moll@arm.com> wrote:
> On Tue, 2011-11-15 at 09:13 +0000, Heiko Carstens wrote:
> > Fix this compile error on s390:
> >
> > CC [M] drivers/virtio/virtio_mmio.o
> > drivers/virtio/virtio_mmio.c: In function 'vm_get_features':
> > drivers/virtio/virtio_mmio.c:107:2: error: implicit declaration of function 'writel'
>
> One learns something new every day :-O
>
> Thanks and apologies for inconvenience!
>
> > Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> > Cc: Pawel Moll <pawel.moll@arm.com>
> > Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
>
> Acked-by: Pawel Moll <pawel.moll@arm.com>
Applied, thanks!
Cheers,
Rusty.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-16 2:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-15 9:13 [PATCH] virtio: add HAS_IOMEM dependency to MMIO platform bus driver Heiko Carstens
2011-11-15 10:31 ` Pawel Moll
2011-11-16 0:28 ` Rusty Russell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.