Re: nmi is broken?

[OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>]

Jan Kiszka <jan.kiszka@web.de> writes:

>> Yes, this is old kernel (2.6.9), and is not using HPET
>> (CONFIG_HPET_TIMER=n), using IO-APIC as NMI source (PMU seems to be
>> unsupported on kvm for now).
>> 
>> Unfortunately, -no-hpet didn't change situation. irq_stat.apic_timer_irqs
>> and nmi_count() are same while irq is disabled.
>
> Maybe it's a regression of latest NMI injection patches.
>
> This worked before? Can you check if commits
> c2dd554dc61173ecb6b3741b680d2ae4c245d2ba and
> f86368493ec038218e8663cc1b6e5393cd8e008a have any impact on your problem?

Unfortunately, no. I've checked kvm_inject_nmi() was not called if irq
was disabled on guest.

The path is following (without my patch, kvm_apic_nmi_wd_deliver is not
called),

pit_do_work()
    kvm_apic_nmi_wd_deliver()
        kvm_apic_local_deliver()
            __apic_accept_irq()
                kvm_inject_nmi()

so it is not meaningful to change after kvm_inject_nmi() (if I'm
understanding commits correctly).

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>