From: Kevin Hilman <khilman@deeprootsystems.com>
To: Aaro Koskinen <aaro.koskinen@nokia.com>
Cc: tony@atomide.com, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm: omap2: io: fix clk_get() error check
Date: Thu, 02 Dec 2010 11:11:02 +0100 [thread overview]
Message-ID: <87vd3c4h8p.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1291126678-2782-1-git-send-email-aaro.koskinen@nokia.com> (Aaro Koskinen's message of "Tue, 30 Nov 2010 16:17:58 +0200")
Aaro Koskinen <aaro.koskinen@nokia.com> writes:
> clk_get() return value should be checked with IS_ERR().
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
Acked-by: Kevin Hilman <khilman@deeprootsystems.com>
> ---
> arch/arm/mach-omap2/io.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/io.c b/arch/arm/mach-omap2/io.c
> index 40562dd..a1939b1 100644
> --- a/arch/arm/mach-omap2/io.c
> +++ b/arch/arm/mach-omap2/io.c
> @@ -297,7 +297,7 @@ static int __init _omap2_init_reprogram_sdrc(void)
> return 0;
>
> dpll3_m2_ck = clk_get(NULL, "dpll3_m2_ck");
> - if (!dpll3_m2_ck)
> + if (IS_ERR(dpll3_m2_ck))
> return -EINVAL;
>
> rate = clk_get_rate(dpll3_m2_ck);
WARNING: multiple messages have this Message-ID (diff)
From: khilman@deeprootsystems.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: omap2: io: fix clk_get() error check
Date: Thu, 02 Dec 2010 11:11:02 +0100 [thread overview]
Message-ID: <87vd3c4h8p.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1291126678-2782-1-git-send-email-aaro.koskinen@nokia.com> (Aaro Koskinen's message of "Tue, 30 Nov 2010 16:17:58 +0200")
Aaro Koskinen <aaro.koskinen@nokia.com> writes:
> clk_get() return value should be checked with IS_ERR().
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
Acked-by: Kevin Hilman <khilman@deeprootsystems.com>
> ---
> arch/arm/mach-omap2/io.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/io.c b/arch/arm/mach-omap2/io.c
> index 40562dd..a1939b1 100644
> --- a/arch/arm/mach-omap2/io.c
> +++ b/arch/arm/mach-omap2/io.c
> @@ -297,7 +297,7 @@ static int __init _omap2_init_reprogram_sdrc(void)
> return 0;
>
> dpll3_m2_ck = clk_get(NULL, "dpll3_m2_ck");
> - if (!dpll3_m2_ck)
> + if (IS_ERR(dpll3_m2_ck))
> return -EINVAL;
>
> rate = clk_get_rate(dpll3_m2_ck);
next prev parent reply other threads:[~2010-12-02 10:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-30 14:17 [PATCH] arm: omap2: io: fix clk_get() error check Aaro Koskinen
2010-11-30 14:17 ` Aaro Koskinen
2010-12-02 10:11 ` Kevin Hilman [this message]
2010-12-02 10:11 ` Kevin Hilman
2010-12-03 1:10 ` Tony Lindgren
2010-12-03 1:10 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vd3c4h8p.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=aaro.koskinen@nokia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.