From: Eric Anholt <eric@anholt.net>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 26/29] drm/i915: Invert watermarks used for i8xx, i9xx.
Date: Mon, 30 Aug 2010 15:39:10 -0700 [thread overview]
Message-ID: <87vd6r20a9.fsf@pollan.anholt.net> (raw)
In-Reply-To: <1282475148-15951-27-git-send-email-chris@chris-wilson.co.uk>
[-- Attachment #1.1: Type: text/plain, Size: 1473 bytes --]
On Sun, 22 Aug 2010 12:05:45 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> The calculation seem backwards as they compute the number of entries
> that would be drained during a memory fetch, and but return the opposite
> value.
>
> This fixes a common flicker [or even completely scrambled display] on
> high resolution outputs (e.g. 1920x1080 with 915GM). However, as we do not
> adjust DSPARB, we are still limited by the FIFO setup by the BIOS which may
> continue to cause underruns with high resolutions on some machines.
>
> References:
>
> Bug 22996 - [945GM] external lcd does not work on high resolution
> https://bugs.freedesktop.org/show_bug.cgi?id=22996
>
> Bug 25284 - [915GM] random flickering when using metacity-compositor
> https://bugs.freedesktop.org/show_bug.cgi?id=25284
>
> Bug 25857 - [945]: Entire screen "jerks" randomly after removing external monitor
> https://bugs.freedesktop.org/show_bug.cgi?id=25857
>
> Bug 27738 - [915] 1920x1200 resolution fails, probable FIFO issue.
> https://bugs.freedesktop.org/show_bug.cgi?id=27738
>
> Bug 28149 - [945GM] KMS regression.
> https://bugs.freedesktop.org/show_bug.cgi?id=28149
>
> Also it may address some instances where the monitor fails to sync
> due to underruns.
What's up with all the bug references here? I hit the first 3 and
didn't see any mention of this patch. I'd probably prefer to see either
Tested-by or nothing.
[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2010-08-30 22:39 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-22 11:05 More patches (resend) Chris Wilson
2010-08-22 11:05 ` [PATCH 01/29] drm/i915: unload: fix intel dp encoder cleanup Chris Wilson
2010-08-22 11:05 ` [PATCH 02/29] drm/i915: unload: fix error_work races Chris Wilson
2010-08-22 11:05 ` [PATCH 03/29] drm/i915: unload: fix hotplug_work races Chris Wilson
2010-08-22 11:05 ` [PATCH 04/29] drm/i915: unload: don't leak error state Chris Wilson
2010-08-22 11:05 ` [PATCH 05/29] drm/i915: unload: fix idle_timer/idle_work races Chris Wilson
2010-08-22 11:05 ` [PATCH 06/29] drm/i915: unload: fix unpin_work related races Chris Wilson
2010-08-22 11:05 ` [PATCH 07/29] drm/i915: unload: ensure that gem is idle Chris Wilson
2010-08-22 11:05 ` [PATCH 08/29] drm/i915: unload: fix retire_work races Chris Wilson
2010-08-22 11:05 ` [PATCH 09/29] drm/i915: Fixup intel_wait_for_vblank*() Chris Wilson
2010-08-23 16:56 ` [PATCH] drm/i915: Drop the msleep parameter to wait_for() Chris Wilson
2010-08-23 23:16 ` Peter Clifton
2010-08-23 23:33 ` Chris Wilson
2010-08-23 23:42 ` Peter Clifton
2010-08-22 11:05 ` [PATCH 10/29] drm/i915: Avoid using msleep under kdb and wait_for() Chris Wilson
2010-08-22 11:05 ` [PATCH 11/29] drm/i915: Include a generation number in the device info Chris Wilson
2010-08-22 11:05 ` [PATCH 12/29] drm/i915: Fix offset page-flips on i965+ Chris Wilson
2010-08-22 11:05 ` [PATCH 13/29] drm/i915: Clear scanline waits after disabling the pipe Chris Wilson
2010-08-22 11:05 ` [PATCH 14/29] drm/i915: Sanity check user framebuffer parameters on creation Chris Wilson
2010-08-22 11:05 ` [PATCH 15/29] drm/i915: Re-use set_base_atomic to share setting of the display registers Chris Wilson
2010-08-22 11:05 ` [PATCH 16/29] drm/i915/sdvo: Propagate error from switching control buses Chris Wilson
2010-08-22 11:05 ` [PATCH 17/29] drm/i915: Add ringbuffer wait reset to hangcheck Chris Wilson
2010-08-22 11:05 ` [PATCH 18/29] drm/i915/crt: Flush register prior to waiting for vblank Chris Wilson
2010-08-22 11:05 ` [PATCH 19/29] drm/i915/dp: Boost timeout for enabling transcoder to 100ms Chris Wilson
2010-08-22 11:05 ` [PATCH 20/29] drm/i915/sdvo: Guess the DDC bus in absence of VBIOS Chris Wilson
2010-08-22 11:05 ` [PATCH 21/29] drm/i915/tv: Flush register writes before sleeping Chris Wilson
2010-08-22 11:05 ` [PATCH 22/29] drm/i915/dp: Really try 5 times before giving up Chris Wilson
2010-08-30 22:35 ` Eric Anholt
2010-08-22 11:05 ` [PATCH 23/29] drm/i915/debug: Include Ironlake in self-refresh status Chris Wilson
2010-08-22 11:05 ` [PATCH 24/29] drm/i915: Allocate the PCI resource for the MCHBAR Chris Wilson
2010-08-22 11:05 ` [PATCH 25/29] drm/i915: Use the VBT from OpRegion when available (v2) Chris Wilson
2010-08-22 11:05 ` [PATCH 26/29] drm/i915: Invert watermarks used for i8xx, i9xx Chris Wilson
2010-08-30 22:39 ` Eric Anholt [this message]
2010-08-22 11:05 ` [PATCH 27/29] drm: Scan EDID for an audio-capable HDMI output Chris Wilson
2010-08-23 15:05 ` Adam Jackson
2010-08-22 11:05 ` [PATCH 28/29] drm/i915/hdmi: Only enable audio if supported by the monitor Chris Wilson
2010-08-22 11:05 ` [PATCH 29/29] drm/i915: Tightly scope intel_encoder to prevent invalid use Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vd6r20a9.fsf@pollan.anholt.net \
--to=eric@anholt.net \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.