* Dovtail: Question regarding stop_machine
@ 2026-11-19 19:42 Florian Bezdeka
2026-11-20 9:38 ` Philippe Gerum
0 siblings, 1 reply; 2+ messages in thread
From: Florian Bezdeka @ 2026-11-19 19:42 UTC (permalink / raw)
To: xenomai@lists.linux.dev; +Cc: Philippe Gerum
Hi Philippe,
while cleaning up my todo list I came along the following thread:
https://lore.kernel.org/xenomai/1207-6aed9780-55-3e404bc0@80379430/T/#t
Seems that you handled that with
5c39a0e4f186 ("stop_machine: irq_pipeline: preserve hard irq state in local stop context")
already (which sneaked in within the last days).
Meanwhile, I would have migrated to local_irq_{save,restore}_full(),
mainly because we touch the code already and it saves us one long at the
stack.
That should also work, no?
Best regards,
Florian
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: Dovtail: Question regarding stop_machine
2026-11-19 19:42 Dovtail: Question regarding stop_machine Florian Bezdeka
@ 2026-11-20 9:38 ` Philippe Gerum
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Gerum @ 2026-11-20 9:38 UTC (permalink / raw)
To: Florian Bezdeka; +Cc: xenomai@lists.linux.dev
Florian Bezdeka <florian.bezdeka@siemens.com> writes:
> Hi Philippe,
>
> while cleaning up my todo list I came along the following thread:
>
> https://lore.kernel.org/xenomai/1207-6aed9780-55-3e404bc0@80379430/T/#t
>
Mm, this one slipped through the cracks too.
> Seems that you handled that with
>
> 5c39a0e4f186 ("stop_machine: irq_pipeline: preserve hard irq state in local stop context")
>
> already (which sneaked in within the last days).
>
> Meanwhile, I would have migrated to local_irq_{save,restore}_full(),
> mainly because we touch the code already and it saves us one long at the
> stack.
>
> That should also work, no?
>
This would be equivalent, however the _full() variants are
stage-adaptive, so we'd have a couple of useless conditional branches
checking for oob context although the stop_machine trampoline always
runs in-band.
--
Philippe.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-20 9:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-19 19:42 Dovtail: Question regarding stop_machine Florian Bezdeka
2026-11-20 9:38 ` Philippe Gerum
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.