All of lore.kernel.org
 help / color / mirror / Atom feed
From: Toon Claes <toon@iotcl.com>
To: Mirko Faina <mroik@delayed.space>, git@vger.kernel.org
Cc: Mirko Faina <mroik@delayed.space>,
	pabloosabaterr@gmail.com, ben.knoble@gmail.com
Subject: Re: [PATCH v2] completions: add some missing options for git log
Date: Mon, 09 Nov 2026 16:41:38 +0100	[thread overview]
Message-ID: <87wlqmxb9p.fsf@dev.null.iotcl.com.invalid> (raw)
In-Reply-To: <5735bacbd5c2c48eddafb43f75f7ddcdf402ff17.1793656021.git.mroik@delayed.space>

Mirko Faina <mroik@delayed.space> writes:

> Some options for "git log" are missing in bash-completions,
> --graph-lane-limit introduced in [1] and --[no-]graph-indent introduced
> in [2].
>
> Teach bash-completions to autocomplete these options.
>
> [1] f756a3c78d (graph: add --graph-lane-limit option, 2026-03-28)
> [2] e9b5720bef (graph: add --[no-]graph-indent and log.graphIndent, 2026-07-14)
>
> Signed-off-by: Mirko Faina <mroik@delayed.space>
> ---
>  contrib/completion/git-completion.bash | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index c3a49e2e22..eab6309a69 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -2395,6 +2395,8 @@ __git_complete_log_opts ()
>  			--cherry-mark
>  			--cherry-pick
>  			--graph
> +			--graph-indent --no-graph-indent
> +			--graph-lane-limit=
>  			--decorate --decorate= --no-decorate
>  			--walk-reflogs
>  			--no-walk --no-walk= --do-walk
>
> base-commit: 6de20f6092dcf9bdb1c8efe03db4b70c82b423dd
> -- 
> 2.56.0

I'm fine with these changes, they do what we want them to. Looks good to
me. 

-- 
Laters,
Toon

  reply	other threads:[~2026-11-09 15:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-13 19:50 [PATCH] bash-completions: add --[no-]graph-indent Mirko Faina
2026-10-29 12:16 ` Mirko Faina
2026-10-29 13:45 ` Pablo Sabater
2026-10-29 14:17   ` Ben Knoble
2026-11-02 19:53   ` Mirko Faina
2026-11-09 15:40     ` Toon Claes
2026-11-02 21:47 ` [PATCH v2] completions: add some missing options for git log Mirko Faina
2026-11-09 15:41   ` Toon Claes [this message]
2026-11-09 20:21     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wlqmxb9p.fsf@dev.null.iotcl.com.invalid \
    --to=toon@iotcl.com \
    --cc=ben.knoble@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=mroik@delayed.space \
    --cc=pabloosabaterr@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.