From: Nam Cao <namcao@linutronix.de>
To: Rui Qi <qirui.001@bytedance.com>, linux-riscv@lists.infradead.org
Cc: Rui Qi <qirui.001@bytedance.com>, Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Thomas Gleixner <tglx@kernel.org>, Zong Li <zong.li@sifive.com>,
Conor Dooley <conor.dooley@microchip.com>,
Lukas Gerlach <lukas.gerlach@cispa.de>,
Deepak Gupta <debug@rivosinc.com>,
Ryan Roberts <ryan.roberts@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: kprobes: Prevent probes in breakpoint handlers
Date: Tue, 04 Aug 2026 08:56:19 +0200 [thread overview]
Message-ID: <87wlu6l6gc.fsf@yellow.woof> (raw)
In-Reply-To: <20260804064343.1865283-1-qirui.001@bytedance.com>
"Rui Qi" <qirui.001@bytedance.com> writes:
> diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c
> index 2f57fd48ec28..5eb5785874dd 100644
> --- a/arch/riscv/kernel/traps.c
> +++ b/arch/riscv/kernel/traps.c
> @@ -270,6 +270,8 @@ static bool probe_single_step_handler(struct pt_regs *regs)
> return user ? uprobe_single_step_handler(regs) : kprobe_single_step_handler(regs);
> }
>
> +NOKPROBE_SYMBOL(probe_single_step_handler);
> +
The usual style is NOKPROBE_SYMBOL() following the function with no
blank line.
Other than that:
Reviewed-by: Nam Cao <namcao@linutronix.de>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Nam Cao <namcao@linutronix.de>
To: Rui Qi <qirui.001@bytedance.com>, linux-riscv@lists.infradead.org
Cc: Rui Qi <qirui.001@bytedance.com>, Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Thomas Gleixner <tglx@kernel.org>, Zong Li <zong.li@sifive.com>,
Conor Dooley <conor.dooley@microchip.com>,
Lukas Gerlach <lukas.gerlach@cispa.de>,
Deepak Gupta <debug@rivosinc.com>,
Ryan Roberts <ryan.roberts@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: kprobes: Prevent probes in breakpoint handlers
Date: Tue, 04 Aug 2026 08:56:19 +0200 [thread overview]
Message-ID: <87wlu6l6gc.fsf@yellow.woof> (raw)
In-Reply-To: <20260804064343.1865283-1-qirui.001@bytedance.com>
"Rui Qi" <qirui.001@bytedance.com> writes:
> diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c
> index 2f57fd48ec28..5eb5785874dd 100644
> --- a/arch/riscv/kernel/traps.c
> +++ b/arch/riscv/kernel/traps.c
> @@ -270,6 +270,8 @@ static bool probe_single_step_handler(struct pt_regs *regs)
> return user ? uprobe_single_step_handler(regs) : kprobe_single_step_handler(regs);
> }
>
> +NOKPROBE_SYMBOL(probe_single_step_handler);
> +
The usual style is NOKPROBE_SYMBOL() following the function with no
blank line.
Other than that:
Reviewed-by: Nam Cao <namcao@linutronix.de>
next prev parent reply other threads:[~2026-08-04 6:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 6:43 [PATCH] riscv: kprobes: Prevent probes in breakpoint handlers Rui Qi
2026-08-04 6:43 ` Rui Qi
2026-08-04 6:56 ` Nam Cao [this message]
2026-08-04 6:56 ` Nam Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wlu6l6gc.fsf@yellow.woof \
--to=namcao@linutronix.de \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor.dooley@microchip.com \
--cc=debug@rivosinc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lukas.gerlach@cispa.de \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=qirui.001@bytedance.com \
--cc=ryan.roberts@arm.com \
--cc=tglx@kernel.org \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.