Re: [PATCH v1 1/3] tests/qtest/libqtest: Replace QTEST_TRACE with QTEST_QEMU_ARGS

[Fabiano Rosas <farosas@suse.de>]

Peter Maydell <peter.maydell@linaro.org> writes:

> On Wed, 29 Apr 2026 at 01:32, Fabiano Rosas <farosas@suse.de> wrote:
>>
>> The QTEST_TRACE environment variable allows for any QEMU command line
>> option to be passed if used like so:
>>
>> export QTEST_TRACE="-trace tracepoint -more -opts -here"
>>
>> Formalize that usage by accepting a new QTEST_QEMU_ARGS
>> variable. Since the QTEST_TRACE now becomes redundant, remove its
>> usage.
>>
>> Signed-off-by: Fabiano Rosas <farosas@suse.de>
>> ---
>>  tests/qtest/libqtest.c | 11 +++++------
>>  1 file changed, 5 insertions(+), 6 deletions(-)
>>
>> diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
>> index 051faf31e1..a580d75179 100644
>> --- a/tests/qtest/libqtest.c
>> +++ b/tests/qtest/libqtest.c
>> @@ -454,11 +454,9 @@ gchar *qtest_qemu_args(const char *extra_args)
>>  {
>>      g_autofree gchar *socket_path = qtest_socket_path("sock");
>>      g_autofree gchar *qmp_socket_path = qtest_socket_path("qmp");
>> -    const char *trace = g_getenv("QTEST_TRACE");
>> -    g_autofree char *tracearg = trace ? g_strdup_printf("-trace %s ", trace) :
>> -                                        g_strdup("");
>> +    const char *args_from_env = g_getenv("QTEST_QEMU_ARGS");
>> +
>>      gchar *args = g_strdup_printf(
>> -                      "%s"
>>                        "-qtest unix:%s "
>>                        "-qtest-log %s "
>>                        "-chardev socket,path=%s,id=char0 "
>> @@ -466,16 +464,17 @@ gchar *qtest_qemu_args(const char *extra_args)
>>                        "-display none "
>>                        "-audio none "
>>                        "%s"
>> +                      "%s "
>>                        "%s"
>>                        " -accel qtest",
>>
>> -                      tracearg,
>>                        socket_path,
>>                        getenv("QTEST_LOG") ? DEV_STDERR : DEV_NULL,
>>                        qmp_socket_path,
>>                        can_exit_with_parent() ?
>>                        "-run-with exit-with-parent=on " : "",
>> -                      extra_args ?: "");
>> +                      extra_args ?: "",
>> +                      args_from_env ?: "");
>
> Maybe we should have all those "%s" consistently be "%s "
> (and drop the trailing space in the "-run-with exit-with-parent=on "
> string and the leading one in " -accel qtest")?
>

Yep, I'll fix it.

At some point I'll figure out how to integrate this qgraph thing with
the rest of qtest so we can build command lines in a cleaner way.

> Sometimes we might get an extra space we don't technically
> need in the command line, but on the other hand we would be able
> to look at the format string and see at a glance that it
> definitely doesn't potentially run one argument into the next
> without having to cross-check all the %s with the arguments,
> and the arguments would consistently always be just strings
> with no requirement to bring along a leading or trailing space.
>
> But either way
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> thanks
> -- PMM