Re: [PATCH v1 2/3] tests/qtest: Individual verbose switches

[Peter Xu <peterx@redhat.com>]

On Tue, Apr 28, 2026 at 09:31:29PM -0300, Fabiano Rosas wrote:
> Allow logging to be set for specific parts of QTest. Having a single
> QTEST_LOG knob creates an output stream that is almost useless due to
> spamming from some operations.
> 
> Add a backward-compatible way of selecting which parts will be made
> verbose. Reuse the existing QTEST_LOG variable. The new options are:
> 
> QTEST_LOG=
> fuzz - fuzz.c
> qga - unit/test-qga.c
> qmp - libqmp.c
> qtest - QTest device, i.e. -qtest-log option
> test - generic term for usage of all tests
> 
> E.g.:
> 
> QTEST_LOG=fuzz,qga,qmp,qtest,test
>   equivalent to QTEST_LOG=1
> 
> QTEST_LOG=qmp,qtest
>   enables logging of qmp operations from libqmp.c and logging of the
>   qtest device.
> 
> QTEST_LOG=test,qmp
>   enable test output and libqmp.c output.
> 
> QTEST_LOG=-qmp
>   enable all output, except for libqmp.c
> 
> Signed-off-by: Fabiano Rosas <farosas@suse.de>

Ohhh this is nice..

Acked-by: Peter Xu <peterx@redhat.com>

Some quick thoughts, doesn't need to do it immediately or at all: make the
parsing of QTEST_LOG var only once might be nice (e.g. switch to flag for
qtest_verbose()).  The other nitpick is would the word "test" too hard to
guess for what it does?  Maybe "misc"?

-- 
Peter Xu