Re: [PATCH] lib: Replace NVL with NVL-S

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Fri, 14 Nov 2025 07:35:28 -0800, Kamil Konieczny wrote:
>
> Hi Shekhar,
> On 2025-11-14 at 11:50:42 +0530, Shekhar Chauhan wrote:
> > Fix NVL-S' definition, by replacing Novalake with Novalake-S.
>
> Remove \' char after S.
>
> >
> > Fixes: 480fa21b8 lib: Add NVL-S support
>
> This should follow convention: 12+ chars for hash and ("title"),
> here:
>
> Fixes: 480fa21b82c2 ("lib: Add NVL-S support")
> > Signed-off-by: Shekhar Chauhan <shekhar.chauhan@intel.com>
>
> With above fixed this is
> Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

I made these changes and merged the patch. Thanks!

>
> Regards,
> Kamil
>
> > ---
> >  lib/intel_chipset.h     | 4 ++--
> >  lib/intel_device_info.c | 8 ++++----
> >  2 files changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h
> > index 7739f4a84..cc2225110 100644
> > --- a/lib/intel_chipset.h
> > +++ b/lib/intel_chipset.h
> > @@ -93,7 +93,7 @@ struct intel_device_info {
> >	bool is_lunarlake : 1;
> >	bool is_battlemage : 1;
> >	bool is_pantherlake : 1;
> > -	bool is_novalake: 1;
> > +	bool is_novalake_s: 1;
> >	bool is_crescentisland: 1;
> >
> >	const struct intel_cmds_info *cmds_info;
> > @@ -212,7 +212,7 @@ void intel_check_pch(void);
> >  #define IS_LUNARLAKE(devid)	(intel_get_device_info(devid)->is_lunarlake)
> >  #define IS_BATTLEMAGE(devid)	(intel_get_device_info(devid)->is_battlemage)
> >  #define IS_PANTHERLAKE(devid)	(intel_get_device_info(devid)->is_pantherlake)
> > -#define IS_NOVALAKE(devid)	(intel_get_device_info(devid)->is_novalake)
> > +#define IS_NOVALAKE_S(devid)	(intel_get_device_info(devid)->is_novalake_s)
> >  #define IS_CRESCENTISLAND(devid)	(intel_get_device_info(devid)->is_crescentisland)
> >
> >  #define IS_GEN(devid, x)	(intel_get_device_info(devid)->graphics_ver == x)
> > diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
> > index d33bf39d4..20147479a 100644
> > --- a/lib/intel_device_info.c
> > +++ b/lib/intel_device_info.c
> > @@ -539,14 +539,14 @@ static const struct intel_device_info intel_pantherlake_info = {
> >	.cmds_info = &xe2_cmds_info,
> >  };
> >
> > -static const struct intel_device_info intel_novalake_info = {
> > +static const struct intel_device_info intel_novalake_s_info = {
> >	.graphics_ver = 30,
> >	.graphics_rel = 04,
> >	.display_ver = 35,
> >	.has_4tile = true,
> >	.has_oam = true,
> > -	.is_novalake = true,
> > -	.codename = "novalake",
> > +	.is_novalake_s = true,
> > +	.codename = "novalake_s",
> >	.cmds_info = &xe2_cmds_info,
> >  };
> >
> > @@ -678,7 +678,7 @@ static const struct pci_id_match intel_device_match[] = {
> >
> >	INTEL_PTL_IDS(INTEL_PCI_ID_INIT, &intel_pantherlake_info),
> >
> > -	INTEL_NVLS_IDS(INTEL_PCI_ID_INIT, &intel_novalake_info),
> > +	INTEL_NVLS_IDS(INTEL_PCI_ID_INIT, &intel_novalake_s_info),
> >
> >	INTEL_CRI_IDS(INTEL_PCI_ID_INIT, &intel_crescentisland_info),
> >
> > --
> > 2.51.1
> >