All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda/realtek: Fix mute LED mask on HP OMEN 16 laptop
@ 2025-07-22 17:22 SHARAN KUMAR M
  2025-07-22 18:00 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: SHARAN KUMAR M @ 2025-07-22 17:22 UTC (permalink / raw)
  To: tiwai; +Cc: linux-sound, sharweshraajan

this patch is to fix my previous Commit <e5182305a519> i have fixed mute 
led but for by This patch corrects the coefficient mask value introduced
in commit <e5182305a519>, which was intended to enable the mute LED 
functionality. During testing, multiple values were evaluated, and 
an incorrect value was mistakenly included in the final commit. 
This update fixes that error by applying the correct 
mask value for proper mute LED behavior.

Tested on 6.15.5-arch1-1

Signed-off-by: SHARAN KUMAR M<sharweshraajan@gmail.com>

---
 sound/pci/hda/patch_realtek.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index d91aac06adde..82eae89f579f 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -4753,7 +4753,7 @@ static void alc245_fixup_hp_mute_led_v1_coefbit(struct hda_codec *codec,
 	if (action == HDA_FIXUP_ACT_PRE_PROBE) {
 		spec->mute_led_polarity = 0;
 		spec->mute_led_coef.idx = 0x0b;
-		spec->mute_led_coef.mask = 1 << 3;
+		spec->mute_led_coef.mask = 3 << 2;
 		spec->mute_led_coef.on = 1 << 3;
 		spec->mute_led_coef.off = 0;
 		snd_hda_gen_add_mute_led_cdev(codec, coef_mute_led_set);
-- 
2.50.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-07-22 18:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-22 17:22 [PATCH] ALSA: hda/realtek: Fix mute LED mask on HP OMEN 16 laptop SHARAN KUMAR M
2025-07-22 18:00 ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.