Re: [PATCH 1/3] accel/ivpu: pages_use_count is now a refcount_t

[Jani Nikula <jani.nikula@linux.intel.com>]

On Thu, 27 Mar 2025, Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com> wrote:
> Hi,
>
> On 3/27/2025 12:37 PM, Dmitry Osipenko wrote:
>> On 3/27/25 14:30, Jani Nikula wrote:
>>> On Thu, 27 Mar 2025, Boris Brezillon <boris.brezillon@collabora.com> wrote:
>>>> Commit 051b6646d36d ("drm/shmem-helper: Use refcount_t for
>>>> pages_use_count") changed the type of
>>>> drm_gem_shmem_object::pages_use_count but accel drivers were left
>>>> behind.
>>>>
>>>> Fixes: 051b6646d36d ("drm/shmem-helper: Use refcount_t for pages_use_count")
>>>> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
>>>> Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>>>> Cc: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
>>>> Cc: Maciej Falkowski <maciej.falkowski@linux.intel.com>
>>>> Cc: Oded Gabbay <ogabbay@kernel.org>
>>>> Cc: dri-devel@lists.freedesktop.org
>>>
>>> Just for build, on the series,
>>>
>>> Tested-by: Jani Nikula <jani.nikula@intel.com>
>>>
>>> Please merge.
>> 
>> Applied to misc-next
>
> This was applied in less then an hour after posting for review without any testing (building is not testing).
> I can't see how this is up to community standards.
> I would prefer that patches for accel/ivpu were merged by ivpu maintainers.
> At least give us time to review them. 

I regret rushing Boris/Dmitry to merge. Sorry about that.

My only excuse is that the build was broken, and the changes were small
and mechanical, similar to what was done elsewhere to change the
interfaces.


BR,
Jani.

-- 
Jani Nikula, Intel