Re: [PATCH 1/3] accel/ivpu: pages_use_count is now a refcount_t

[Jani Nikula <jani.nikula@linux.intel.com>]

On Thu, 27 Mar 2025, Boris Brezillon <boris.brezillon@collabora.com> wrote:
> Commit 051b6646d36d ("drm/shmem-helper: Use refcount_t for
> pages_use_count") changed the type of
> drm_gem_shmem_object::pages_use_count but accel drivers were left
> behind.
>
> Fixes: 051b6646d36d ("drm/shmem-helper: Use refcount_t for pages_use_count")
> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
> Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> Cc: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
> Cc: Maciej Falkowski <maciej.falkowski@linux.intel.com>
> Cc: Oded Gabbay <ogabbay@kernel.org>
> Cc: dri-devel@lists.freedesktop.org

Just for build, on the series,

Tested-by: Jani Nikula <jani.nikula@intel.com>

Please merge.

> ---
>  drivers/accel/ivpu/ivpu_gem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accel/ivpu/ivpu_gem.c b/drivers/accel/ivpu/ivpu_gem.c
> index 8741c73b92ce..09c9c5256af5 100644
> --- a/drivers/accel/ivpu/ivpu_gem.c
> +++ b/drivers/accel/ivpu/ivpu_gem.c
> @@ -282,7 +282,7 @@ static void ivpu_gem_bo_free(struct drm_gem_object *obj)
>  	ivpu_bo_unbind_locked(bo);
>  	mutex_destroy(&bo->lock);
>  
> -	drm_WARN_ON(obj->dev, bo->base.pages_use_count > 1);
> +	drm_WARN_ON(obj->dev, refcount_read(&bo->base.pages_use_count) > 1);
>  	drm_gem_shmem_free(&bo->base);
>  }

-- 
Jani Nikula, Intel