* [PATCH] drm/print: Add missing [drm] prefix to drm based WARN
@ 2024-05-23 17:44 Michal Wajdeczko
2024-05-24 8:04 ` Jani Nikula
0 siblings, 1 reply; 2+ messages in thread
From: Michal Wajdeczko @ 2024-05-23 17:44 UTC (permalink / raw)
To: dri-devel
Cc: Michal Wajdeczko, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, Jani Nikula
All drm_device based logging macros, except those related to WARN,
include the [drm] prefix. Fix that.
[ ] 0000:00:00.0: this is a warning
[ ] 0000:00:00.0: drm_WARN_ON(true)
vs
[ ] 0000:00:00.0: [drm] this is a warning
[ ] 0000:00:00.0: [drm] drm_WARN_ON(true)
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Jani Nikula <jani.nikula@intel.com>
---
include/drm/drm_print.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
index 089950ad8681..112f8830b372 100644
--- a/include/drm/drm_print.h
+++ b/include/drm/drm_print.h
@@ -632,12 +632,12 @@ void __drm_err(const char *format, ...);
/* Helper for struct drm_device based WARNs */
#define drm_WARN(drm, condition, format, arg...) \
- WARN(condition, "%s %s: " format, \
+ WARN(condition, "%s %s: [drm] " format, \
dev_driver_string((drm)->dev), \
dev_name((drm)->dev), ## arg)
#define drm_WARN_ONCE(drm, condition, format, arg...) \
- WARN_ONCE(condition, "%s %s: " format, \
+ WARN_ONCE(condition, "%s %s: [drm] " format, \
dev_driver_string((drm)->dev), \
dev_name((drm)->dev), ## arg)
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/print: Add missing [drm] prefix to drm based WARN
2024-05-23 17:44 [PATCH] drm/print: Add missing [drm] prefix to drm based WARN Michal Wajdeczko
@ 2024-05-24 8:04 ` Jani Nikula
0 siblings, 0 replies; 2+ messages in thread
From: Jani Nikula @ 2024-05-24 8:04 UTC (permalink / raw)
To: Michal Wajdeczko, dri-devel
Cc: Michal Wajdeczko, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann
On Thu, 23 May 2024, Michal Wajdeczko <michal.wajdeczko@intel.com> wrote:
> All drm_device based logging macros, except those related to WARN,
> include the [drm] prefix. Fix that.
>
> [ ] 0000:00:00.0: this is a warning
> [ ] 0000:00:00.0: drm_WARN_ON(true)
> vs
> [ ] 0000:00:00.0: [drm] this is a warning
> [ ] 0000:00:00.0: [drm] drm_WARN_ON(true)
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Jani Nikula <jani.nikula@intel.com>
> ---
> include/drm/drm_print.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
> index 089950ad8681..112f8830b372 100644
> --- a/include/drm/drm_print.h
> +++ b/include/drm/drm_print.h
> @@ -632,12 +632,12 @@ void __drm_err(const char *format, ...);
>
> /* Helper for struct drm_device based WARNs */
> #define drm_WARN(drm, condition, format, arg...) \
> - WARN(condition, "%s %s: " format, \
> + WARN(condition, "%s %s: [drm] " format, \
> dev_driver_string((drm)->dev), \
> dev_name((drm)->dev), ## arg)
>
> #define drm_WARN_ONCE(drm, condition, format, arg...) \
> - WARN_ONCE(condition, "%s %s: " format, \
> + WARN_ONCE(condition, "%s %s: [drm] " format, \
> dev_driver_string((drm)->dev), \
> dev_name((drm)->dev), ## arg)
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-24 8:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-23 17:44 [PATCH] drm/print: Add missing [drm] prefix to drm based WARN Michal Wajdeczko
2024-05-24 8:04 ` Jani Nikula
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.