All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v5] drm/i915/dp: Increase idle pattern wait timeout to 2ms
@ 2024-03-11  4:15 Shekhar Chauhan
  2024-03-11 12:04 ` Gustavo Sousa
                   ` (4 more replies)
  0 siblings, 5 replies; 12+ messages in thread
From: Shekhar Chauhan @ 2024-03-11  4:15 UTC (permalink / raw)
  To: intel-gfx; +Cc: jani.nikula, matthew.d.roper, clinton.a.taylor, shekhar.chauhan

The driver currently waits 1ms for idle patterns,
but for Xe2LPD and possibly future display IPs,
it requires a 1640us (rounded up to 2ms) timeout
whilst waiting for idle patterns for MST streams.

To simplify the code, the timeout is uniformly
increased by 1ms across all platforms/display IPs.

v1: Introduced the 2ms wait timeout.
v2: Segregated the wait timeout for platforms before & after LNL.
v3: Fixed 2 cosmetic changes.
v4: Revert to v2 design with commit message enhancements.
v5: Minor cosmetic changes to the commit message.

BSpec: 68849
Signed-off-by: Shekhar Chauhan <shekhar.chauhan@intel.com>
---
 drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index bea441590204..05ba3642d486 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -3680,7 +3680,7 @@ static void intel_ddi_set_idle_link_train(struct intel_dp *intel_dp,
 
 	if (intel_de_wait_for_set(dev_priv,
 				  dp_tp_status_reg(encoder, crtc_state),
-				  DP_TP_STATUS_IDLE_DONE, 1))
+				  DP_TP_STATUS_IDLE_DONE, 2))
 		drm_err(&dev_priv->drm,
 			"Timed out waiting for DP idle patterns\n");
 }
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2024-03-14 18:37 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-11  4:15 [PATCH v5] drm/i915/dp: Increase idle pattern wait timeout to 2ms Shekhar Chauhan
2024-03-11 12:04 ` Gustavo Sousa
2024-03-14  9:12   ` Jani Nikula
2024-03-11 23:39 ` ✗ Fi.CI.BAT: failure for drm/i915/dp: Increase idle pattern wait timeout to 2ms (rev4) Patchwork
2024-03-13  3:54   ` Chauhan, Shekhar
2024-03-13  7:46     ` Illipilli, TejasreeX
2024-03-13  6:45 ` ✓ Fi.CI.BAT: success " Patchwork
2024-03-13  8:54 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-03-14  5:14   ` Chauhan, Shekhar
2024-03-14 18:31     ` Illipilli, TejasreeX
2024-03-14 18:37     ` Illipilli, TejasreeX
2024-03-14 18:33 ` ✓ Fi.CI.IGT: success " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.