All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Docs/zh_CN: Fix the meaning of DEBUG to pr_debug()
@ 2023-12-19  7:08 JiaLong.Yang
  2023-12-19 14:43 ` Jonathan Corbet
  0 siblings, 1 reply; 6+ messages in thread
From: JiaLong.Yang @ 2023-12-19  7:08 UTC (permalink / raw)
  To: Alex Shi, Yanteng Si, Jonathan Corbet
  Cc: 2738078698, JiaLong.Yang, linux-doc, linux-kernel

Signed-off-by: JiaLong.Yang <jialong.yang@shingroup.cn>
---
 Documentation/translations/zh_CN/core-api/printk-basics.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/translations/zh_CN/core-api/printk-basics.rst b/Documentation/translations/zh_CN/core-api/printk-basics.rst
index 59c6efb3fc41..cafa01bccff2 100644
--- a/Documentation/translations/zh_CN/core-api/printk-basics.rst
+++ b/Documentation/translations/zh_CN/core-api/printk-basics.rst
@@ -100,7 +100,7 @@ printk()的用法通常是这样的::
 
 为了调试，还有两个有条件编译的宏：
 pr_debug()和pr_devel()，除非定义了 ``DEBUG`` (或者在pr_debug()的情况下定义了
-``CONFIG_DYNAMIC_DEBUG`` )，否则它们会被编译。
+``CONFIG_DYNAMIC_DEBUG`` )，否则它们不会被编译。
 
 
 函数接口
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] Docs/zh_CN: Fix the meaning of DEBUG to pr_debug()
  2023-12-19  7:08 [PATCH] Docs/zh_CN: Fix the meaning of DEBUG to pr_debug() JiaLong.Yang
@ 2023-12-19 14:43 ` Jonathan Corbet
  2023-12-19 18:47   ` Zenghui Yu
  2023-12-20  2:00   ` Yanteng Si
  0 siblings, 2 replies; 6+ messages in thread
From: Jonathan Corbet @ 2023-12-19 14:43 UTC (permalink / raw)
  To: JiaLong.Yang, Alex Shi, Yanteng Si
  Cc: 2738078698, JiaLong.Yang, linux-doc, linux-kernel

"JiaLong.Yang" <jialong.yang@shingroup.cn> writes:

> Signed-off-by: JiaLong.Yang <jialong.yang@shingroup.cn>
> ---
>  Documentation/translations/zh_CN/core-api/printk-basics.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/translations/zh_CN/core-api/printk-basics.rst b/Documentation/translations/zh_CN/core-api/printk-basics.rst
> index 59c6efb3fc41..cafa01bccff2 100644
> --- a/Documentation/translations/zh_CN/core-api/printk-basics.rst
> +++ b/Documentation/translations/zh_CN/core-api/printk-basics.rst
> @@ -100,7 +100,7 @@ printk()的用法通常是这样的::
>  
>  为了调试，还有两个有条件编译的宏：
>  pr_debug()和pr_devel()，除非定义了 ``DEBUG`` (或者在pr_debug()的情况下定义了
> -``CONFIG_DYNAMIC_DEBUG`` )，否则它们会被编译。
> +``CONFIG_DYNAMIC_DEBUG`` )，否则它们不会被编译。
>  

This patch needs an actual changelog.  Being illiterate in Chinese, I
can't make any connection between the subject line and what has actually
been done here.

Thanks,

jon

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] Docs/zh_CN: Fix the meaning of DEBUG to pr_debug()
  2023-12-19 14:43 ` Jonathan Corbet
@ 2023-12-19 18:47   ` Zenghui Yu
  2023-12-20  2:00   ` Yanteng Si
  1 sibling, 0 replies; 6+ messages in thread
From: Zenghui Yu @ 2023-12-19 18:47 UTC (permalink / raw)
  To: Jonathan Corbet, JiaLong.Yang, Alex Shi, Yanteng Si
  Cc: 2738078698, linux-doc, linux-kernel

On 2023/12/19 22:43, Jonathan Corbet wrote:
> "JiaLong.Yang" <jialong.yang@shingroup.cn> writes:
> 
>> Signed-off-by: JiaLong.Yang <jialong.yang@shingroup.cn>
>> ---
>>  Documentation/translations/zh_CN/core-api/printk-basics.rst | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/translations/zh_CN/core-api/printk-basics.rst b/Documentation/translations/zh_CN/core-api/printk-basics.rst
>> index 59c6efb3fc41..cafa01bccff2 100644
>> --- a/Documentation/translations/zh_CN/core-api/printk-basics.rst
>> +++ b/Documentation/translations/zh_CN/core-api/printk-basics.rst
>> @@ -100,7 +100,7 @@ printk()的用法通常是这样的::
>>  
>>  为了调试，还有两个有条件编译的宏：
>>  pr_debug()和pr_devel()，除非定义了 ``DEBUG`` (或者在pr_debug()的情况下定义了
>> -``CONFIG_DYNAMIC_DEBUG`` )，否则它们会被编译。
>> +``CONFIG_DYNAMIC_DEBUG`` )，否则它们不会被编译。
>>  
> 
> This patch needs an actual changelog.  Being illiterate in Chinese, I
> can't make any connection between the subject line and what has actually
> been done here.

Agreed. The change itself looks correct though, feel free to add my

Reviewed-by: Zenghui Yu <zenghui.yu@linux.dev>

in your next revision (with Jon's suggestion addressed).

Thanks,
Zenghui

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] Docs/zh_CN: Fix the meaning of DEBUG to pr_debug()
  2023-12-19 14:43 ` Jonathan Corbet
  2023-12-19 18:47   ` Zenghui Yu
@ 2023-12-20  2:00   ` Yanteng Si
  1 sibling, 0 replies; 6+ messages in thread
From: Yanteng Si @ 2023-12-20  2:00 UTC (permalink / raw)
  To: Jonathan Corbet, JiaLong.Yang, Alex Shi
  Cc: 2738078698, linux-doc, linux-kernel

Hi JiaLong,

在 2023/12/19 22:43, Jonathan Corbet 写道:
> "JiaLong.Yang" <jialong.yang@shingroup.cn> writes:
>
>> Signed-off-by: JiaLong.Yang <jialong.yang@shingroup.cn>
>> ---
>>   Documentation/translations/zh_CN/core-api/printk-basics.rst | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/translations/zh_CN/core-api/printk-basics.rst b/Documentation/translations/zh_CN/core-api/printk-basics.rst
>> index 59c6efb3fc41..cafa01bccff2 100644
>> --- a/Documentation/translations/zh_CN/core-api/printk-basics.rst
>> +++ b/Documentation/translations/zh_CN/core-api/printk-basics.rst
>> @@ -100,7 +100,7 @@ printk()的用法通常是这样的::
>>   
>>   为了调试，还有两个有条件编译的宏：
>>   pr_debug()和pr_devel()，除非定义了 ``DEBUG`` (或者在pr_debug()的情况下定义了
>> -``CONFIG_DYNAMIC_DEBUG`` )，否则它们会被编译。
>> +``CONFIG_DYNAMIC_DEBUG`` )，否则它们不会被编译。
>>   
> This patch needs an actual changelog.  Being illiterate in Chinese, I
> can't make any connection between the subject line and what has actually
> been done here.

As jon said, could you please write a commit message?

For details see: .../Documentation/translations/zh_CN/process/5.Posting.rst


Thanks,

Yanteng

>
> Thanks,
>
> jon


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] Docs/zh_CN: Fix the meaning of DEBUG to pr_debug()
       [not found] <202312201105408639401@shingroup.cn>
@ 2023-12-20  6:28 ` JiaLong.Yang
  2023-12-20  7:26   ` Yanteng Si
  0 siblings, 1 reply; 6+ messages in thread
From: JiaLong.Yang @ 2023-12-20  6:28 UTC (permalink / raw)
  To: Alex Shi, Yanteng Si, Jonathan Corbet
  Cc: 2738078698, JiaLong.Yang, linux-doc, linux-kernel

We know the macro DEBUG will make pr_debug() save the formatted
string into final binary. So the translation is a little wrong.

Signed-off-by: JiaLong.Yang <jialong.yang@shingroup.cn>
---
 Documentation/translations/zh_CN/core-api/printk-basics.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/translations/zh_CN/core-api/printk-basics.rst b/Documentation/translations/zh_CN/core-api/printk-basics.rst
index 59c6efb3fc41..cafa01bccff2 100644
--- a/Documentation/translations/zh_CN/core-api/printk-basics.rst
+++ b/Documentation/translations/zh_CN/core-api/printk-basics.rst
@@ -100,7 +100,7 @@ printk()的用法通常是这样的::
 
 为了调试，还有两个有条件编译的宏：
 pr_debug()和pr_devel()，除非定义了 ``DEBUG`` (或者在pr_debug()的情况下定义了
-``CONFIG_DYNAMIC_DEBUG`` )，否则它们会被编译。
+``CONFIG_DYNAMIC_DEBUG`` )，否则它们不会被编译。
 
 
 函数接口
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] Docs/zh_CN: Fix the meaning of DEBUG to pr_debug()
  2023-12-20  6:28 ` JiaLong.Yang
@ 2023-12-20  7:26   ` Yanteng Si
  0 siblings, 0 replies; 6+ messages in thread
From: Yanteng Si @ 2023-12-20  7:26 UTC (permalink / raw)
  To: JiaLong.Yang, Alex Shi, Jonathan Corbet
  Cc: 2738078698, linux-doc, linux-kernel


在 2023/12/20 14:28, JiaLong.Yang 写道:
> We know the macro DEBUG will make pr_debug() save the formatted
> string into final binary. So the translation is a little wrong.
>
> Signed-off-by: JiaLong.Yang <jialong.yang@shingroup.cn>

Acked-by: Yanteng Si <siyanteng@loongson.cn>


BTW, you lost Zenghui's Reviewed-by tag. :)


Thanks,

Yanteng

> ---
>   Documentation/translations/zh_CN/core-api/printk-basics.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/translations/zh_CN/core-api/printk-basics.rst b/Documentation/translations/zh_CN/core-api/printk-basics.rst
> index 59c6efb3fc41..cafa01bccff2 100644
> --- a/Documentation/translations/zh_CN/core-api/printk-basics.rst
> +++ b/Documentation/translations/zh_CN/core-api/printk-basics.rst
> @@ -100,7 +100,7 @@ printk()的用法通常是这样的::
>   
>   为了调试，还有两个有条件编译的宏：
>   pr_debug()和pr_devel()，除非定义了 ``DEBUG`` (或者在pr_debug()的情况下定义了
> -``CONFIG_DYNAMIC_DEBUG`` )，否则它们会被编译。
> +``CONFIG_DYNAMIC_DEBUG`` )，否则它们不会被编译。
>   
>   
>   函数接口


^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-12-20  7:26 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-19  7:08 [PATCH] Docs/zh_CN: Fix the meaning of DEBUG to pr_debug() JiaLong.Yang
2023-12-19 14:43 ` Jonathan Corbet
2023-12-19 18:47   ` Zenghui Yu
2023-12-20  2:00   ` Yanteng Si
     [not found] <202312201105408639401@shingroup.cn>
2023-12-20  6:28 ` JiaLong.Yang
2023-12-20  7:26   ` Yanteng Si

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.