Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: enable W=1 warnings by default

[Jani Nikula <jani.nikula@intel.com>]

On Wed, 11 Oct 2023, Masahiro Yamada <masahiroy@kernel.org> wrote:
> On Wed, Oct 11, 2023 at 4:29 PM Jani Nikula <jani.nikula@intel.com> wrote:
>>
>> We enable a bunch more compiler warnings than the kernel
>> defaults. However, they've drifted to become a unique set of warnings,
>> and have increasingly fallen behind from the W=1 set.
>>
>> Align with the W=1 warnings from scripts/Makefile.extrawarn for clarity,
>> by copy-pasting them with s/KBUILD_CFLAGS/subdir-ccflags-y/ to make it
>> easier to compare in the future.
>>
>> Some of the -Wextra warnings do need to be disabled, just like in
>> Makefile.extrawarn, but take care to not disable them for W=2 or W=3
>> builds, depending on the warning.
>>
>> v2: Add back some -Wextra warning disables (Nathan)
>>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Cc: Nick Desaulniers <ndesaulniers@google.com>
>> Cc: Nathan Chancellor <nathan@kernel.org>
>> Cc: Masahiro Yamada <masahiroy@kernel.org>
>> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>

Thanks for the reviews everyone...

...though we missed some s/KBUILD_CFLAGS/subdir-ccflags-y/ in v2. Fixed
while applying.

BR,
Jani.


-- 
Jani Nikula, Intel