From: Cornelia Huck <cohuck@redhat.com>
To: Parav Pandit <parav@nvidia.com>,
virtio-comment@lists.oasis-open.org, mst@redhat.com
Cc: virtio-dev@lists.oasis-open.org, hengqi@linux.alibaba.com,
shahafs@nvidia.com, Parav Pandit <parav@nvidia.com>
Subject: Re: [virtio-comment] [PATCH 1/4] virtio-net: Place C code under listing
Date: Thu, 13 Jul 2023 11:13:04 +0200 [thread overview]
Message-ID: <87wmz4qin3.fsf@redhat.com> (raw)
In-Reply-To: <20230712222405.455201-2-parav@nvidia.com>
On Thu, Jul 13 2023, Parav Pandit <parav@nvidia.com> wrote:
> With extra white space for the define, pdf generation fails.
> Also place the C code under listing.
>
> Signed-off-by: Parav Pandit <parav@nvidia.com>
> ---
> device-types/net/description.tex | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/device-types/net/description.tex b/device-types/net/description.tex
> index 206020d..6fd4a20 100644
> --- a/device-types/net/description.tex
> +++ b/device-types/net/description.tex
> @@ -1024,12 +1024,14 @@ \subsubsection{Processing of Incoming Packets}\label{sec:Device Types / Network
> If VIRTIO_NET_F_HASH_TUNNEL has been negotiated, the driver can send the command
> VIRTIO_NET_CTRL_HASH_TUNNEL_SET to configure the calculation of the inner header hash.
>
> +\begin{lstlisting}
> struct virtnet_hash_tunnel {
> le32 enabled_tunnel_types;
> };
>
> #define VIRTIO_NET_CTRL_HASH_TUNNEL 7
> - #define VIRTIO_NET_CTRL_HASH_TUNNEL_SET 0
> +#define VIRTIO_NET_CTRL_HASH_TUNNEL_SET 0
I think the indentation here is intentional (as in other, similare
sections.)
> +\end{lstlisting}
>
> Field \field{enabled_tunnel_types} contains the bitmask of encapsulation types enabled for inner header hash.
> See \ref{sec:Device Types / Network Device / Device Operation / Processing of Incoming Packets /
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: Parav Pandit <parav@nvidia.com>,
virtio-comment@lists.oasis-open.org, mst@redhat.com
Cc: virtio-dev@lists.oasis-open.org, hengqi@linux.alibaba.com,
shahafs@nvidia.com, Parav Pandit <parav@nvidia.com>
Subject: [virtio-dev] Re: [virtio-comment] [PATCH 1/4] virtio-net: Place C code under listing
Date: Thu, 13 Jul 2023 11:13:04 +0200 [thread overview]
Message-ID: <87wmz4qin3.fsf@redhat.com> (raw)
In-Reply-To: <20230712222405.455201-2-parav@nvidia.com>
On Thu, Jul 13 2023, Parav Pandit <parav@nvidia.com> wrote:
> With extra white space for the define, pdf generation fails.
> Also place the C code under listing.
>
> Signed-off-by: Parav Pandit <parav@nvidia.com>
> ---
> device-types/net/description.tex | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/device-types/net/description.tex b/device-types/net/description.tex
> index 206020d..6fd4a20 100644
> --- a/device-types/net/description.tex
> +++ b/device-types/net/description.tex
> @@ -1024,12 +1024,14 @@ \subsubsection{Processing of Incoming Packets}\label{sec:Device Types / Network
> If VIRTIO_NET_F_HASH_TUNNEL has been negotiated, the driver can send the command
> VIRTIO_NET_CTRL_HASH_TUNNEL_SET to configure the calculation of the inner header hash.
>
> +\begin{lstlisting}
> struct virtnet_hash_tunnel {
> le32 enabled_tunnel_types;
> };
>
> #define VIRTIO_NET_CTRL_HASH_TUNNEL 7
> - #define VIRTIO_NET_CTRL_HASH_TUNNEL_SET 0
> +#define VIRTIO_NET_CTRL_HASH_TUNNEL_SET 0
I think the indentation here is intentional (as in other, similare
sections.)
> +\end{lstlisting}
>
> Field \field{enabled_tunnel_types} contains the bitmask of encapsulation types enabled for inner header hash.
> See \ref{sec:Device Types / Network Device / Device Operation / Processing of Incoming Packets /
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-07-13 9:13 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 22:24 [virtio-comment] [PATCH 0/4] Short document fixes to inner hash feature Parav Pandit
2023-07-12 22:24 ` [virtio-dev] " Parav Pandit
2023-07-12 22:24 ` [virtio-comment] [PATCH 1/4] virtio-net: Place C code under listing Parav Pandit
2023-07-12 22:24 ` [virtio-dev] " Parav Pandit
2023-07-13 9:13 ` Cornelia Huck [this message]
2023-07-13 9:13 ` [virtio-dev] Re: [virtio-comment] " Cornelia Huck
2023-07-13 11:44 ` Parav Pandit
2023-07-13 11:44 ` [virtio-dev] " Parav Pandit
2023-07-12 22:24 ` [virtio-comment] [PATCH 2/4] virtio-net: Avoid hyphen and extra braces Parav Pandit
2023-07-12 22:24 ` [virtio-dev] " Parav Pandit
2023-07-13 9:16 ` [virtio-comment] " Cornelia Huck
2023-07-13 9:16 ` [virtio-dev] " Cornelia Huck
2023-07-12 22:24 ` [virtio-comment] [PATCH 3/4] virtio-net: Use table to describe inner hash to rfc mapping Parav Pandit
2023-07-12 22:24 ` [virtio-dev] " Parav Pandit
2023-07-12 22:41 ` [virtio-comment] " Michael S. Tsirkin
2023-07-12 22:41 ` [virtio-dev] " Michael S. Tsirkin
2023-07-12 22:42 ` [virtio-comment] " Parav Pandit
2023-07-12 22:42 ` [virtio-dev] " Parav Pandit
2023-07-13 8:09 ` [virtio-comment] " Cornelia Huck
2023-07-13 8:09 ` [virtio-dev] " Cornelia Huck
2023-07-13 11:01 ` [virtio-comment] " Michael S. Tsirkin
2023-07-13 11:01 ` [virtio-dev] " Michael S. Tsirkin
2023-07-12 22:24 ` [virtio-comment] [PATCH 4/4] virtio-net: Use note instead of advice Parav Pandit
2023-07-12 22:24 ` [virtio-dev] " Parav Pandit
2023-07-13 9:12 ` [virtio-comment] Re: [PATCH 0/4] Short document fixes to inner hash feature Cornelia Huck
2023-07-13 9:12 ` [virtio-dev] " Cornelia Huck
2023-07-13 9:32 ` [virtio-comment] " Cornelia Huck
2023-07-13 9:32 ` [virtio-dev] " Cornelia Huck
2023-07-13 11:00 ` Michael S. Tsirkin
2023-07-13 11:00 ` [virtio-dev] " Michael S. Tsirkin
2023-07-13 11:33 ` Michael S. Tsirkin
2023-07-13 11:33 ` [virtio-dev] " Michael S. Tsirkin
2023-07-13 11:58 ` [virtio-comment] " Heng Qi
2023-07-13 11:58 ` [virtio-dev] " Heng Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmz4qin3.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=hengqi@linux.alibaba.com \
--cc=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.