From: Kalle Valo <kvalo@kernel.org>
To: Arowa Suliman <arowa@chromium.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
Arowa Suliman <arowa@google.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] wifi: ath11k: Add crash logging
Date: Tue, 11 Jul 2023 09:40:53 +0300 [thread overview]
Message-ID: <87wmz77xxm.fsf@kernel.org> (raw)
In-Reply-To: <20230710230546.3544912-1-arowa@google.com> (Arowa Suliman's message of "Mon, 10 Jul 2023 16:04:53 -0700")
Arowa Suliman <arowa@chromium.org> writes:
> Change crash logging from debug to informational and add warning when
> firmware crash MHI_CB_EE_RDDM happens.
Why? What's the reason why you want to change this? The commit log
should always describe that.
> Tested-on: Qualcomm WCN6855
This is not correct format:
https://wireless.wiki.kernel.org/en/users/drivers/ath11k/submittingpatches#tested-on_tag
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202306141105.c1e82Q0y-lkp@intel.com/
The robot only reported problems with your patch, it didn't report the
original problem. So you should remove these two lines.
> Signed-off-by: Arowa Suliman <arowa@google.com>
From and s-o-b have different email addresses.
Also this seems to a second version of your patch so you should have
marked it as v2 and include a changelog what changed from v1.
Please read our documentation from the wiki link below how to submit
patches.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Arowa Suliman <arowa@chromium.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
Arowa Suliman <arowa@google.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] wifi: ath11k: Add crash logging
Date: Tue, 11 Jul 2023 09:40:53 +0300 [thread overview]
Message-ID: <87wmz77xxm.fsf@kernel.org> (raw)
In-Reply-To: <20230710230546.3544912-1-arowa@google.com> (Arowa Suliman's message of "Mon, 10 Jul 2023 16:04:53 -0700")
Arowa Suliman <arowa@chromium.org> writes:
> Change crash logging from debug to informational and add warning when
> firmware crash MHI_CB_EE_RDDM happens.
Why? What's the reason why you want to change this? The commit log
should always describe that.
> Tested-on: Qualcomm WCN6855
This is not correct format:
https://wireless.wiki.kernel.org/en/users/drivers/ath11k/submittingpatches#tested-on_tag
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202306141105.c1e82Q0y-lkp@intel.com/
The robot only reported problems with your patch, it didn't report the
original problem. So you should remove these two lines.
> Signed-off-by: Arowa Suliman <arowa@google.com>
From and s-o-b have different email addresses.
Also this seems to a second version of your patch so you should have
marked it as v2 and include a changelog what changed from v1.
Please read our documentation from the wiki link below how to submit
patches.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-07-11 6:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 23:04 [PATCH] wifi: ath11k: Add crash logging Arowa Suliman
2023-07-10 23:04 ` Arowa Suliman
2023-07-11 6:40 ` Kalle Valo [this message]
2023-07-11 6:40 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2023-06-14 2:29 Arowa Suliman
2023-06-14 2:29 ` Arowa Suliman
2023-06-14 4:01 ` kernel test robot
2023-06-14 4:01 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmz77xxm.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=arowa@chromium.org \
--cc=arowa@google.com \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.