All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Sui Jingfeng <15330273260@189.cn>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915_drm.h: fix a typo
Date: Mon, 29 May 2023 13:06:45 +0300	[thread overview]
Message-ID: <87wn0rh2oa.fsf@intel.com> (raw)
In-Reply-To: <970d2cff-f181-d933-8ce3-b1dbe7f90fd8@189.cn>

On Mon, 29 May 2023, Sui Jingfeng <15330273260@189.cn> wrote:
> Hi,
>
>
> On 2023/5/29 16:06, Jani Nikula wrote:
>> On Mon, 29 May 2023, Sui Jingfeng <suijingfeng@loongson.cn> wrote:
>>>   'rbiter' -> 'arbite'
>> Should be arbiter.
>
> Yeah, should be arbiter.
>
> arbiter is a noun. Here, this arbiter may referrer to the 
> drivers/pci/vgaarb.c.
>
> Can you help correct then apply it ? thanks.

Please send a fixed version and I'll apply it. I'm not fixing trivial
patches for you.

BR,
Jani.


>
>>
>>> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
>>> ---
>>>   include/drm/i915_drm.h | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h
>>> index 7adce327c1c2..3dcb1db519ae 100644
>>> --- a/include/drm/i915_drm.h
>>> +++ b/include/drm/i915_drm.h
>>> @@ -42,7 +42,7 @@ extern struct resource intel_graphics_stolen_res;
>>>    * The Bridge device's PCI config space has information about the
>>>    * fb aperture size and the amount of pre-reserved memory.
>>>    * This is all handled in the intel-gtt.ko module. i915.ko only
>>> - * cares about the vga bit for the vga rbiter.
>>> + * cares about the vga bit for the vga arbite.
>>>    */
>>>   #define INTEL_GMCH_CTRL		0x52
>>>   #define INTEL_GMCH_VGA_DISABLE  (1 << 1)

-- 
Jani Nikula, Intel Open Source Graphics Center

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Sui Jingfeng <15330273260@189.cn>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915_drm.h: fix a typo
Date: Mon, 29 May 2023 13:06:45 +0300	[thread overview]
Message-ID: <87wn0rh2oa.fsf@intel.com> (raw)
In-Reply-To: <970d2cff-f181-d933-8ce3-b1dbe7f90fd8@189.cn>

On Mon, 29 May 2023, Sui Jingfeng <15330273260@189.cn> wrote:
> Hi,
>
>
> On 2023/5/29 16:06, Jani Nikula wrote:
>> On Mon, 29 May 2023, Sui Jingfeng <suijingfeng@loongson.cn> wrote:
>>>   'rbiter' -> 'arbite'
>> Should be arbiter.
>
> Yeah, should be arbiter.
>
> arbiter is a noun. Here, this arbiter may referrer to the 
> drivers/pci/vgaarb.c.
>
> Can you help correct then apply it ? thanks.

Please send a fixed version and I'll apply it. I'm not fixing trivial
patches for you.

BR,
Jani.


>
>>
>>> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
>>> ---
>>>   include/drm/i915_drm.h | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h
>>> index 7adce327c1c2..3dcb1db519ae 100644
>>> --- a/include/drm/i915_drm.h
>>> +++ b/include/drm/i915_drm.h
>>> @@ -42,7 +42,7 @@ extern struct resource intel_graphics_stolen_res;
>>>    * The Bridge device's PCI config space has information about the
>>>    * fb aperture size and the amount of pre-reserved memory.
>>>    * This is all handled in the intel-gtt.ko module. i915.ko only
>>> - * cares about the vga bit for the vga rbiter.
>>> + * cares about the vga bit for the vga arbite.
>>>    */
>>>   #define INTEL_GMCH_CTRL		0x52
>>>   #define INTEL_GMCH_VGA_DISABLE  (1 << 1)

-- 
Jani Nikula, Intel Open Source Graphics Center

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Sui Jingfeng <15330273260@189.cn>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/i915_drm.h: fix a typo
Date: Mon, 29 May 2023 13:06:45 +0300	[thread overview]
Message-ID: <87wn0rh2oa.fsf@intel.com> (raw)
In-Reply-To: <970d2cff-f181-d933-8ce3-b1dbe7f90fd8@189.cn>

On Mon, 29 May 2023, Sui Jingfeng <15330273260@189.cn> wrote:
> Hi,
>
>
> On 2023/5/29 16:06, Jani Nikula wrote:
>> On Mon, 29 May 2023, Sui Jingfeng <suijingfeng@loongson.cn> wrote:
>>>   'rbiter' -> 'arbite'
>> Should be arbiter.
>
> Yeah, should be arbiter.
>
> arbiter is a noun. Here, this arbiter may referrer to the 
> drivers/pci/vgaarb.c.
>
> Can you help correct then apply it ? thanks.

Please send a fixed version and I'll apply it. I'm not fixing trivial
patches for you.

BR,
Jani.


>
>>
>>> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
>>> ---
>>>   include/drm/i915_drm.h | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h
>>> index 7adce327c1c2..3dcb1db519ae 100644
>>> --- a/include/drm/i915_drm.h
>>> +++ b/include/drm/i915_drm.h
>>> @@ -42,7 +42,7 @@ extern struct resource intel_graphics_stolen_res;
>>>    * The Bridge device's PCI config space has information about the
>>>    * fb aperture size and the amount of pre-reserved memory.
>>>    * This is all handled in the intel-gtt.ko module. i915.ko only
>>> - * cares about the vga bit for the vga rbiter.
>>> + * cares about the vga bit for the vga arbite.
>>>    */
>>>   #define INTEL_GMCH_CTRL		0x52
>>>   #define INTEL_GMCH_VGA_DISABLE  (1 << 1)

-- 
Jani Nikula, Intel Open Source Graphics Center

  reply	other threads:[~2023-05-29 10:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-29  7:49 [Intel-gfx] [PATCH] drm/i915_drm.h: fix a typo Sui Jingfeng
2023-05-29  7:49 ` Sui Jingfeng
2023-05-29  7:49 ` Sui Jingfeng
2023-05-29  8:06 ` [Intel-gfx] " Jani Nikula
2023-05-29  8:06   ` Jani Nikula
2023-05-29  8:06   ` Jani Nikula
2023-05-29  8:47   ` [Intel-gfx] " Sui Jingfeng
2023-05-29  8:47     ` Sui Jingfeng
2023-05-29  8:47     ` Sui Jingfeng
2023-05-29 10:06     ` Jani Nikula [this message]
2023-05-29 10:06       ` Jani Nikula
2023-05-29 10:06       ` Jani Nikula
2023-05-29 11:20       ` [Intel-gfx] " Sui Jingfeng
2023-05-29 11:20         ` Sui Jingfeng
2023-05-29 11:20         ` Sui Jingfeng
2023-05-29  8:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-05-29 13:20 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wn0rh2oa.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=15330273260@189.cn \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.