From: Takashi Iwai <tiwai@suse.de>
To: Artemii Karasev <karasev@ispras.ru>
Cc: alsa-devel@alsa-project.org, Xiang wangx <wangxiang@cdjrlc.com>,
lvc-project@linuxtesting.org, linux-kernel@vger.kernel.org,
Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH] ALSA: hda/via: Avoid potential array out-of-bound in add_secret_dac_path()
Date: Thu, 19 Jan 2023 11:29:42 +0100 [thread overview]
Message-ID: <87wn5irf55.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230119082259.3634-1-karasev@ispras.ru>
On Thu, 19 Jan 2023 09:22:59 +0100,
Artemii Karasev wrote:
>
> snd_hda_get_connections() can return a negative error code.
> It may lead to accessing 'conn' array at a negative index.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Artemii Karasev <karasev@ispras.ru>
> Fixes: 30b4503378c9 ("ALSA: hda - Expose secret DAC-AA connection of some VIA codecs")
Thanks, applied.
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Artemii Karasev <karasev@ispras.ru>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Xiang wangx <wangxiang@cdjrlc.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] ALSA: hda/via: Avoid potential array out-of-bound in add_secret_dac_path()
Date: Thu, 19 Jan 2023 11:29:42 +0100 [thread overview]
Message-ID: <87wn5irf55.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230119082259.3634-1-karasev@ispras.ru>
On Thu, 19 Jan 2023 09:22:59 +0100,
Artemii Karasev wrote:
>
> snd_hda_get_connections() can return a negative error code.
> It may lead to accessing 'conn' array at a negative index.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Artemii Karasev <karasev@ispras.ru>
> Fixes: 30b4503378c9 ("ALSA: hda - Expose secret DAC-AA connection of some VIA codecs")
Thanks, applied.
Takashi
next prev parent reply other threads:[~2023-01-19 10:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 8:22 [PATCH] ALSA: hda/via: Avoid potential array out-of-bound in add_secret_dac_path() Artemii Karasev
2023-01-19 8:22 ` Artemii Karasev
2023-01-19 10:29 ` Takashi Iwai [this message]
2023-01-19 10:29 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wn5irf55.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=karasev@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=tiwai@suse.com \
--cc=wangxiang@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.