* [PATCH RESEND] ARM: pxa: pxa2xx-ac97-lib: fix return value check of platform_get_irq()
@ 2022-10-29 8:20 Yang Yingliang
2022-10-29 8:46 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2022-10-29 8:20 UTC (permalink / raw)
To: alsa-devel
Cc: arnd, tiwai, haojian.zhuang, yangyingliang, robert.jarzmik,
daniel
platform_get_irq() returns negative error number on failure, fix the
return value check in pxa2xx_ac97_hw_probe() and assign the error code
to 'ret'.
Fixes: 2548e6c76ebf ("ARM: pxa: pxa2xx-ac97-lib: use IRQ resource")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
The previous link:
https://lore.kernel.org/lkml/20220425074559.2436002-1-yangyingliang@huawei.com/T/#u
---
sound/arm/pxa2xx-ac97-lib.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/sound/arm/pxa2xx-ac97-lib.c b/sound/arm/pxa2xx-ac97-lib.c
index e55c0421718b..2ca33fd5a575 100644
--- a/sound/arm/pxa2xx-ac97-lib.c
+++ b/sound/arm/pxa2xx-ac97-lib.c
@@ -402,8 +402,10 @@ int pxa2xx_ac97_hw_probe(struct platform_device *dev)
goto err_clk2;
irq = platform_get_irq(dev, 0);
- if (!irq)
+ if (irq < 0) {
+ ret = irq;
goto err_irq;
+ }
ret = request_irq(irq, pxa2xx_ac97_irq, 0, "AC97", NULL);
if (ret < 0)
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND] ARM: pxa: pxa2xx-ac97-lib: fix return value check of platform_get_irq()
2022-10-29 8:20 [PATCH RESEND] ARM: pxa: pxa2xx-ac97-lib: fix return value check of platform_get_irq() Yang Yingliang
@ 2022-10-29 8:46 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2022-10-29 8:46 UTC (permalink / raw)
To: Yang Yingliang
Cc: alsa-devel, arnd, tiwai, haojian.zhuang, robert.jarzmik, daniel
On Sat, 29 Oct 2022 10:20:01 +0200,
Yang Yingliang wrote:
>
> platform_get_irq() returns negative error number on failure, fix the
> return value check in pxa2xx_ac97_hw_probe() and assign the error code
> to 'ret'.
>
> Fixes: 2548e6c76ebf ("ARM: pxa: pxa2xx-ac97-lib: use IRQ resource")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-29 8:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-29 8:20 [PATCH RESEND] ARM: pxa: pxa2xx-ac97-lib: fix return value check of platform_get_irq() Yang Yingliang
2022-10-29 8:46 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.