Re: [PATCH 1/1] gpio: mpfs - add polarfire soc gpio support

[Marc Zyngier <maz@kernel.org>]

On Thu, 07 Jul 2022 05:46:44 +0100,
kernel test robot <lkp@intel.com> wrote:
> 
> Hi,
> 
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on brgl/gpio/for-next]
> [also build test ERROR on linus/master v5.19-rc5 next-20220706]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/lewis-hanly-microchip-com/Add-Polarfire-SoC-GPIO-support/20220705-220421
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next
> config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220707/202207071219.0Jw0owWG-lkp@intel.com/config)
> compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
> reproduce (this is a W=1 build):
>         # https://github.com/intel-lab-lkp/linux/commit/f1c1cf42734c00cf02babb6220f8b68a62e86d0e
>         git remote add linux-review https://github.com/intel-lab-lkp/linux
>         git fetch --no-tags linux-review lewis-hanly-microchip-com/Add-Polarfire-SoC-GPIO-support/20220705-220421
>         git checkout f1c1cf42734c00cf02babb6220f8b68a62e86d0e
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/
> 
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/gpio/gpio-mpfs.c: In function 'mpfs_gpio_probe':
> >> drivers/gpio/gpio-mpfs.c:290:20: error: 'struct irq_chip' has no member named 'parent_device'
>      290 |         irq_c->chip->parent_device = dev;
>          |                    ^~
> >> drivers/gpio/gpio-mpfs.c:310:23: error: implicit declaration of function 'devm_request_irq'; did you mean 'can_request_irq'? [-Werror=implicit-function-declaration]
>      310 |                 ret = devm_request_irq(&pdev->dev, irq,

I missed this in my initial eyeballing of this patch. This should
implement a chained interrupt flow, and not request the mux interrupt
directly. That's yet another level of brokenness in this driver.

	M.

-- 
Without deviation from the norm, progress is not possible.