All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Li kunyu <kunyu@nfschina.com>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	tiwai@suse.com
Subject: Re: [PATCH] sound: It seems that the code format could be cleaner
Date: Mon, 04 Jul 2022 15:04:09 +0200	[thread overview]
Message-ID: <87wnctxc52.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220627032521.259750-1-kunyu@nfschina.com>

On Mon, 27 Jun 2022 05:25:21 +0200,
Li kunyu wrote:
> 
> It seems that the condition statement and return statement could be
> tidied up by adding blank lines.
> 
> Signed-off-by: Li kunyu <kunyu@nfschina.com>

Thanks for the patch.

But in general we don't take such white-space only changes alone,
unless it's a cleanup work for the other real changes.

i.e. if you really work on the code to fix or enhance something, we
are glad to take such a white-space patch as prerequisite.


Takashi

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Li kunyu <kunyu@nfschina.com>
Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound: It seems that the code format could be cleaner
Date: Mon, 04 Jul 2022 15:04:09 +0200	[thread overview]
Message-ID: <87wnctxc52.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220627032521.259750-1-kunyu@nfschina.com>

On Mon, 27 Jun 2022 05:25:21 +0200,
Li kunyu wrote:
> 
> It seems that the condition statement and return statement could be
> tidied up by adding blank lines.
> 
> Signed-off-by: Li kunyu <kunyu@nfschina.com>

Thanks for the patch.

But in general we don't take such white-space only changes alone,
unless it's a cleanup work for the other real changes.

i.e. if you really work on the code to fix or enhance something, we
are glad to take such a white-space patch as prerequisite.


Takashi

  reply	other threads:[~2022-07-04 13:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-27  3:25 [PATCH] sound: It seems that the code format could be cleaner Li kunyu
2022-07-04 13:04 ` Takashi Iwai [this message]
2022-07-04 13:04   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnctxc52.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=kunyu@nfschina.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.