From: Marc Zyngier <maz@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: Lars Povlsen <lars.povlsen@microchip.com>,
Steen Hegelund <Steen.Hegelund@microchip.com>,
Linus Walleij <linus.walleij@linaro.org>,
UNGLinuxDriver@microchip.com,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: microchip-sgpio: make irq_chip immutable
Date: Thu, 28 Apr 2022 17:05:43 +0100 [thread overview]
Message-ID: <87wnf98a7c.wl-maz@kernel.org> (raw)
In-Reply-To: <20220428111622.1395831-1-michael@walle.cc>
On Thu, 28 Apr 2022 12:16:22 +0100,
Michael Walle <michael@walle.cc> wrote:
>
> Since recently, the kernel is nagging about mutable irq_chips:
>
> [ 4.967050] gpio gpiochip1: (e2004190.gpio-input): not an immutable chip, please consider fixing it!
>
> Drop the unneeded copy, flag it as IRQCHIP_IMMUTABLE, add the new
> helper functions and call the appropriate gpiolib functions.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
FWIW:
Reviewed-by: Marc Zyngier <maz@kernel.org>
M.
--
Without deviation from the norm, progress is not possible.
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: Lars Povlsen <lars.povlsen@microchip.com>,
Steen Hegelund <Steen.Hegelund@microchip.com>,
Linus Walleij <linus.walleij@linaro.org>,
UNGLinuxDriver@microchip.com,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: microchip-sgpio: make irq_chip immutable
Date: Thu, 28 Apr 2022 17:05:43 +0100 [thread overview]
Message-ID: <87wnf98a7c.wl-maz@kernel.org> (raw)
In-Reply-To: <20220428111622.1395831-1-michael@walle.cc>
On Thu, 28 Apr 2022 12:16:22 +0100,
Michael Walle <michael@walle.cc> wrote:
>
> Since recently, the kernel is nagging about mutable irq_chips:
>
> [ 4.967050] gpio gpiochip1: (e2004190.gpio-input): not an immutable chip, please consider fixing it!
>
> Drop the unneeded copy, flag it as IRQCHIP_IMMUTABLE, add the new
> helper functions and call the appropriate gpiolib functions.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
FWIW:
Reviewed-by: Marc Zyngier <maz@kernel.org>
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-28 16:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 11:16 [PATCH] pinctrl: microchip-sgpio: make irq_chip immutable Michael Walle
2022-04-28 11:16 ` Michael Walle
2022-04-28 16:05 ` Marc Zyngier [this message]
2022-04-28 16:05 ` Marc Zyngier
2022-04-28 22:34 ` Linus Walleij
2022-04-28 22:34 ` Linus Walleij
2022-05-05 14:55 ` Linus Walleij
2022-05-05 14:55 ` Linus Walleij
2022-05-05 15:05 ` Marc Zyngier
2022-05-05 15:05 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnf98a7c.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=lars.povlsen@microchip.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.