All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	"fengping.yu" <fengping.yu@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	Marco Felsch <m.felsch@pengutronix.de>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-input@vger.kernel.org, linux-mediatek@lists.infradead.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Input: mt6779-keypad - fix signedness bug in probe
Date: Mon, 14 Mar 2022 15:37:55 +0100	[thread overview]
Message-ID: <87wngw1tx8.fsf@baylibre.com> (raw)
In-Reply-To: <20220314140038.GA30883@kili>

Hi Dan,

On lun., mars 14, 2022 at 17:00, Dan Carpenter <dan.carpenter@oracle.com> wrote:

> The "irq" variable needs to be signed for the error handling to work.
>
> Fixes: f28af984e771 ("Input: mt6779-keypad - add MediaTek keypad driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thank you for the patch.

This was already reported and fixed at [1]

[1] https://lore.kernel.org/linux-input/20220308025054.2077162-1-lv.ruyi@zte.com.cn/

> ---
>  drivers/input/keyboard/mt6779-keypad.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/mt6779-keypad.c b/drivers/input/keyboard/mt6779-keypad.c
> index 5ff23250ed37..abd7e346203d 100644
> --- a/drivers/input/keyboard/mt6779-keypad.c
> +++ b/drivers/input/keyboard/mt6779-keypad.c
> @@ -91,10 +91,10 @@ static void mt6779_keypad_clk_disable(void *data)
>  static int mt6779_keypad_pdrv_probe(struct platform_device *pdev)
>  {
>  	struct mt6779_keypad *keypad;
> -	unsigned int irq;
>  	u32 debounce;
>  	bool wakeup;
>  	int error;
> +	int irq;
>  
>  	keypad = devm_kzalloc(&pdev->dev, sizeof(*keypad), GFP_KERNEL);
>  	if (!keypad)
> -- 
> 2.20.1

WARNING: multiple messages have this Message-ID (diff)
From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	"fengping.yu" <fengping.yu@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	Marco Felsch <m.felsch@pengutronix.de>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-input@vger.kernel.org, linux-mediatek@lists.infradead.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Input: mt6779-keypad - fix signedness bug in probe
Date: Mon, 14 Mar 2022 15:37:55 +0100	[thread overview]
Message-ID: <87wngw1tx8.fsf@baylibre.com> (raw)
In-Reply-To: <20220314140038.GA30883@kili>

Hi Dan,

On lun., mars 14, 2022 at 17:00, Dan Carpenter <dan.carpenter@oracle.com> wrote:

> The "irq" variable needs to be signed for the error handling to work.
>
> Fixes: f28af984e771 ("Input: mt6779-keypad - add MediaTek keypad driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thank you for the patch.

This was already reported and fixed at [1]

[1] https://lore.kernel.org/linux-input/20220308025054.2077162-1-lv.ruyi@zte.com.cn/

> ---
>  drivers/input/keyboard/mt6779-keypad.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/mt6779-keypad.c b/drivers/input/keyboard/mt6779-keypad.c
> index 5ff23250ed37..abd7e346203d 100644
> --- a/drivers/input/keyboard/mt6779-keypad.c
> +++ b/drivers/input/keyboard/mt6779-keypad.c
> @@ -91,10 +91,10 @@ static void mt6779_keypad_clk_disable(void *data)
>  static int mt6779_keypad_pdrv_probe(struct platform_device *pdev)
>  {
>  	struct mt6779_keypad *keypad;
> -	unsigned int irq;
>  	u32 debounce;
>  	bool wakeup;
>  	int error;
> +	int irq;
>  
>  	keypad = devm_kzalloc(&pdev->dev, sizeof(*keypad), GFP_KERNEL);
>  	if (!keypad)
> -- 
> 2.20.1

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

  reply	other threads:[~2022-03-14 14:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-14 14:00 [PATCH] Input: mt6779-keypad - fix signedness bug in probe Dan Carpenter
2022-03-14 14:00 ` Dan Carpenter
2022-03-14 14:37 ` Mattijs Korpershoek [this message]
2022-03-14 14:37   ` Mattijs Korpershoek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wngw1tx8.fsf@baylibre.com \
    --to=mkorpershoek@baylibre.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dan.carpenter@oracle.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=fengping.yu@mediatek.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=m.felsch@pengutronix.de \
    --cc=matthias.bgg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.