All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH i-g-t] tests/i915/perf_pmu: Fix allow hang handling
@ 2022-01-06 16:42 Tvrtko Ursulin
  2022-01-06 17:27 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Tvrtko Ursulin @ 2022-01-06 16:42 UTC (permalink / raw)
  To: igt-dev; +Cc: Intel-gfx

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Commit d7a74b959eea ("tests/i915/perf_pmu: Convert to intel_ctx_t (v3)")
broke the test when it is run in its entirety.

Correct context id needs to be used with igt_allow_hang to avoid context
ban preventing the test to run to completion.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Fixes: d7a74b959eea ("tests/i915/perf_pmu: Convert to intel_ctx_t (v3)")
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
I haven't audited more tests apart from grep showing a lot of
igt_allow_hang with the default context so someone needs to go through
them and see if more are affected.
---
 tests/i915/perf_pmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/i915/perf_pmu.c b/tests/i915/perf_pmu.c
index 581da8483f0c..1665dc5e6317 100644
--- a/tests/i915/perf_pmu.c
+++ b/tests/i915/perf_pmu.c
@@ -2319,7 +2319,7 @@ igt_main
 	}
 
 	test_each_engine("busy-hang", fd, ctx, e) {
-		igt_hang_t hang = igt_allow_hang(fd, 0, 0);
+		igt_hang_t hang = igt_allow_hang(fd, ctx->id, 0);
 
 		single(fd, ctx, e, TEST_BUSY | FLAG_HANG);
 
-- 
2.32.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-07 14:21 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-06 16:42 [Intel-gfx] [PATCH i-g-t] tests/i915/perf_pmu: Fix allow hang handling Tvrtko Ursulin
2022-01-06 17:27 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2022-01-06 17:43 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
2022-01-06 20:39 ` [igt-dev] [PATCH i-g-t] " Dixit, Ashutosh
2022-01-06 20:39   ` [Intel-gfx] " Dixit, Ashutosh
2022-01-07 14:21 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.