Re: [PATCH] ath10k: abstract htt_rx_desc structure

From: Kalle Valo <kvalo@codeaurora.org>
To: Thorsten Leemhuis <regressions@leemhuis.info>
Cc: Francesco Magliocca <franciman12@gmail.com>,
	ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
	enrico@fracta.dev
Subject: Re: [PATCH] ath10k: abstract htt_rx_desc structure
Date: Wed, 10 Nov 2021 15:38:03 +0200	[thread overview]
Message-ID: <87wnlgm8qs.fsf@codeaurora.org> (raw)
In-Reply-To: <27297ff6-d970-7b9a-01f0-d5261d553e6b@leemhuis.info> (Thorsten Leemhuis's message of "Tue, 9 Nov 2021 09:53:13 +0100")

Thorsten Leemhuis <regressions@leemhuis.info> writes:

> On 08.11.21 17:25, Francesco Magliocca wrote:
>> QCA6174 card often hangs with the current htt_rx_desc
>> memory layout in some circumstances, because its firmware
>> fails to handle length differences.
>> Therefore we must abstract the htt_rx_desc structure
>> and operations on it, to allow different wireless cards
>> to use different, unrelated rx descriptor structures.
>> 
>> Define a base htt_rx_desc structure and htt_rx_desc_qca_old
>> for use with the QCA family of ath10k supported cards
>> and htt_rx_desc_new for use with the WCN3990 card.
>> 
>> Define htt_rx_desc_ops which contains the abstract operations
>> to access the generic htt_rx_desc, give implementations
>> for each card and update htt_rx.c to use the defined
>> abstract interface to rx descriptors.
>> 
>> Fixes: e3def6f7 ("ath10k: Update rx descriptor for WCN3990 target")

This should be:

Fixes: e3def6f7ddf8 ("ath10k: Update rx descriptor for WCN3990 target")

I can fix that during commit.

>> Tested-on: QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00157-QCARMSWPZ-1
>> 
>> Co-developed-by: Enrico Lumetti <enrico@fracta.dev>
>> Signed-off-by: Enrico Lumetti <enrico@fracta.dev>
>> Signed-off-by: Francesco Magliocca <franciman12@gmail.com>
>
> As a Linux kernel regression tracker let me use this opportunity and
> say: Thanks for working on a fix for this regression.
>
> There is one small detail that could be improved: the commit message
> would benefit from a link to the regression report. This is explained in
> Documentation/process/submitting-patches.rst, which recently was changed
> slightly to make this aspect clearer:
> https://git.kernel.org/linus/1f57bd42b77c
>
> E.g. add something like this, just *without* the leading caret(¹):
>
> ^Link:
> https://lore.kernel.org/ath10k/CAH4F6usFu8-A6k5Z7rU9__iENcSC6Zr-NtRhh_aypR74UvN1uQ@mail.gmail.com/
>
> Francesco, could you please do this in case you need to sent an improved
> version for other reasons? And if the patch is already good to go: could
> the subsystem maintainer please add it when applying?

I have not had a chance to review the patch yet, but I can add the link
during commit (if I'll apply this version).

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k