From: Cornelia Huck <cohuck@redhat.com>
To: Halil Pasic <pasic@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, markver@us.ibm.com,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, Jason Wang <jasowang@redhat.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Xie Yongji <xieyongji@bytedance.com>,
stefanha@redhat.com,
Raphael Norwitz <raphael.norwitz@nutanix.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Halil Pasic <pasic@linux.ibm.com>
Subject: Re: [PATCH 1/1] virtio: write back F_VERSION_1 before validate
Date: Thu, 07 Oct 2021 18:16:16 +0200 [thread overview]
Message-ID: <87wnmoyfn3.fsf@redhat.com> (raw)
In-Reply-To: <20211007175242.4b0155b8.pasic@linux.ibm.com>
On Thu, Oct 07 2021, Halil Pasic <pasic@linux.ibm.com> wrote:
> On Thu, 07 Oct 2021 17:25:52 +0200
> Cornelia Huck <cohuck@redhat.com> wrote:
>
>> On Thu, Oct 07 2021, Halil Pasic <pasic@linux.ibm.com> wrote:
>>
>> > On Thu, 07 Oct 2021 13:52:24 +0200
>> > Cornelia Huck <cohuck@redhat.com> wrote:
>> >
>> >> On Wed, Oct 06 2021, Halil Pasic <pasic@linux.ibm.com> wrote:
>> >>
>> >> > The virtio specification virtio-v1.1-cs01 states: "Transitional devices
>> >> > MUST detect Legacy drivers by detecting that VIRTIO_F_VERSION_1 has not
>> >> > been acknowledged by the driver." This is exactly what QEMU as of 6.1
>> >> > has done relying solely on VIRTIO_F_VERSION_1 for detecting that.
>> >> >
>> >> > However, the specification also says: "... driver MAY read (but MUST NOT
>> >> > write) the device-specific configuration fields to check that it can
>> >> > support the device ..." before setting FEATURES_OK.
>> >>
>> >> Suggest to put the citations from the spec into quotes, so that they are
>> >> distinguishable from the rest of the text.
>> >
>> > For the record: I basically took Michael's description, the one which you
>> > said you prefer, with some minor changes.
>>
>> Well I did look at what the text said, not the details in the formatting...
>>
>> >
>> > This is one of the changes, which renders this a paraphrase and not a
>> > quote. Michael didn't use quotation marks so I was not sure it is was
>> > a word by word quote anyway. It was. But the spec depends on "During this
>> > step" which does not make any sense without the context. That is why I made
>> > the end of step explicit.
>>
>> I still think that would be nicer while using some quotation marks, even
>> if you are just doing a partial quote.
>>
>> In the first paragraph, however, we really should mark the quote
>> properly. It gave me a stop when I first read it.
>
> I've added in some quotation marks and ellipsis marks. Does that look
> good for you?
Yep, works for me.
WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: Halil Pasic <pasic@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, markver@us.ibm.com,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, linux-kernel@vger.kernel.org,
Halil Pasic <pasic@linux.ibm.com>,
Xie Yongji <xieyongji@bytedance.com>,
Raphael Norwitz <raphael.norwitz@nutanix.com>,
stefanha@redhat.com, virtualization@lists.linux-foundation.org,
Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Re: [PATCH 1/1] virtio: write back F_VERSION_1 before validate
Date: Thu, 07 Oct 2021 18:16:16 +0200 [thread overview]
Message-ID: <87wnmoyfn3.fsf@redhat.com> (raw)
In-Reply-To: <20211007175242.4b0155b8.pasic@linux.ibm.com>
On Thu, Oct 07 2021, Halil Pasic <pasic@linux.ibm.com> wrote:
> On Thu, 07 Oct 2021 17:25:52 +0200
> Cornelia Huck <cohuck@redhat.com> wrote:
>
>> On Thu, Oct 07 2021, Halil Pasic <pasic@linux.ibm.com> wrote:
>>
>> > On Thu, 07 Oct 2021 13:52:24 +0200
>> > Cornelia Huck <cohuck@redhat.com> wrote:
>> >
>> >> On Wed, Oct 06 2021, Halil Pasic <pasic@linux.ibm.com> wrote:
>> >>
>> >> > The virtio specification virtio-v1.1-cs01 states: "Transitional devices
>> >> > MUST detect Legacy drivers by detecting that VIRTIO_F_VERSION_1 has not
>> >> > been acknowledged by the driver." This is exactly what QEMU as of 6.1
>> >> > has done relying solely on VIRTIO_F_VERSION_1 for detecting that.
>> >> >
>> >> > However, the specification also says: "... driver MAY read (but MUST NOT
>> >> > write) the device-specific configuration fields to check that it can
>> >> > support the device ..." before setting FEATURES_OK.
>> >>
>> >> Suggest to put the citations from the spec into quotes, so that they are
>> >> distinguishable from the rest of the text.
>> >
>> > For the record: I basically took Michael's description, the one which you
>> > said you prefer, with some minor changes.
>>
>> Well I did look at what the text said, not the details in the formatting...
>>
>> >
>> > This is one of the changes, which renders this a paraphrase and not a
>> > quote. Michael didn't use quotation marks so I was not sure it is was
>> > a word by word quote anyway. It was. But the spec depends on "During this
>> > step" which does not make any sense without the context. That is why I made
>> > the end of step explicit.
>>
>> I still think that would be nicer while using some quotation marks, even
>> if you are just doing a partial quote.
>>
>> In the first paragraph, however, we really should mark the quote
>> properly. It gave me a stop when I first read it.
>
> I've added in some quotation marks and ellipsis marks. Does that look
> good for you?
Yep, works for me.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: Halil Pasic <pasic@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, markver@us.ibm.com,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
qemu-devel@nongnu.org, linux-kernel@vger.kernel.org,
Halil Pasic <pasic@linux.ibm.com>,
Xie Yongji <xieyongji@bytedance.com>,
Raphael Norwitz <raphael.norwitz@nutanix.com>,
stefanha@redhat.com, virtualization@lists.linux-foundation.org,
Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Re: [PATCH 1/1] virtio: write back F_VERSION_1 before validate
Date: Thu, 07 Oct 2021 18:16:16 +0200 [thread overview]
Message-ID: <87wnmoyfn3.fsf@redhat.com> (raw)
In-Reply-To: <20211007175242.4b0155b8.pasic@linux.ibm.com>
On Thu, Oct 07 2021, Halil Pasic <pasic@linux.ibm.com> wrote:
> On Thu, 07 Oct 2021 17:25:52 +0200
> Cornelia Huck <cohuck@redhat.com> wrote:
>
>> On Thu, Oct 07 2021, Halil Pasic <pasic@linux.ibm.com> wrote:
>>
>> > On Thu, 07 Oct 2021 13:52:24 +0200
>> > Cornelia Huck <cohuck@redhat.com> wrote:
>> >
>> >> On Wed, Oct 06 2021, Halil Pasic <pasic@linux.ibm.com> wrote:
>> >>
>> >> > The virtio specification virtio-v1.1-cs01 states: "Transitional devices
>> >> > MUST detect Legacy drivers by detecting that VIRTIO_F_VERSION_1 has not
>> >> > been acknowledged by the driver." This is exactly what QEMU as of 6.1
>> >> > has done relying solely on VIRTIO_F_VERSION_1 for detecting that.
>> >> >
>> >> > However, the specification also says: "... driver MAY read (but MUST NOT
>> >> > write) the device-specific configuration fields to check that it can
>> >> > support the device ..." before setting FEATURES_OK.
>> >>
>> >> Suggest to put the citations from the spec into quotes, so that they are
>> >> distinguishable from the rest of the text.
>> >
>> > For the record: I basically took Michael's description, the one which you
>> > said you prefer, with some minor changes.
>>
>> Well I did look at what the text said, not the details in the formatting...
>>
>> >
>> > This is one of the changes, which renders this a paraphrase and not a
>> > quote. Michael didn't use quotation marks so I was not sure it is was
>> > a word by word quote anyway. It was. But the spec depends on "During this
>> > step" which does not make any sense without the context. That is why I made
>> > the end of step explicit.
>>
>> I still think that would be nicer while using some quotation marks, even
>> if you are just doing a partial quote.
>>
>> In the first paragraph, however, we really should mark the quote
>> properly. It gave me a stop when I first read it.
>
> I've added in some quotation marks and ellipsis marks. Does that look
> good for you?
Yep, works for me.
next prev parent reply other threads:[~2021-10-07 16:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 14:25 [PATCH 1/1] virtio: write back F_VERSION_1 before validate Halil Pasic
2021-10-06 14:25 ` Halil Pasic
2021-10-06 14:25 ` Halil Pasic
2021-10-07 11:52 ` Cornelia Huck
2021-10-07 11:52 ` Cornelia Huck
2021-10-07 11:52 ` Cornelia Huck
2021-10-07 14:32 ` Halil Pasic
2021-10-07 14:32 ` Halil Pasic
2021-10-07 14:32 ` Halil Pasic
2021-10-07 15:25 ` Cornelia Huck
2021-10-07 15:25 ` Cornelia Huck
2021-10-07 15:25 ` Cornelia Huck
2021-10-07 15:52 ` Halil Pasic
2021-10-07 15:52 ` Halil Pasic
2021-10-07 15:52 ` Halil Pasic
2021-10-07 16:16 ` Cornelia Huck [this message]
2021-10-07 16:16 ` Cornelia Huck
2021-10-07 16:16 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnmoyfn3.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=markver@us.ibm.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=raphael.norwitz@nutanix.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.