From: Marc Zyngier <maz@kernel.org>
To: Oliver Upton <oupton@google.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
kvm@vger.kernel.org, Will Deacon <will@kernel.org>,
Sean Christopherson <seanjc@google.com>,
Peter Shier <pshier@google.com>,
Raghavendra Rao Anata <rananta@google.com>,
David Matlack <dmatlack@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org,
Jim Mattson <jmattson@google.com>
Subject: Re: [PATCH v6 17/21] KVM: arm64: Allow userspace to configure a guest's counter-timer offset
Date: Wed, 11 Aug 2021 10:01:32 +0100 [thread overview]
Message-ID: <87wnos9wyb.wl-maz@kernel.org> (raw)
In-Reply-To: <CAOQ_Qsjn4UK81qBj-uPzoejNc4GAnZXPi=mvcoVi15N0_kayAw@mail.gmail.com>
On Tue, 10 Aug 2021 18:55:12 +0100,
Oliver Upton <oupton@google.com> wrote:
>
> On Tue, Aug 10, 2021 at 3:56 AM Marc Zyngier <maz@kernel.org> wrote:
> >
> > On Wed, 04 Aug 2021 09:58:15 +0100,
> > Oliver Upton <oupton@google.com> wrote:
[...]
> > > diff --git a/include/clocksource/arm_arch_timer.h b/include/clocksource/arm_arch_timer.h
> > > index 73c7139c866f..7252ffa3d675 100644
> > > --- a/include/clocksource/arm_arch_timer.h
> > > +++ b/include/clocksource/arm_arch_timer.h
> > > @@ -21,6 +21,7 @@
> > > #define CNTHCTL_EVNTEN (1 << 2)
> > > #define CNTHCTL_EVNTDIR (1 << 3)
> > > #define CNTHCTL_EVNTI (0xF << 4)
> > > +#define CNTHCTL_ECV (1 << 12)
> > >
> > > enum arch_timer_reg {
> > > ARCH_TIMER_REG_CTRL,
> >
> > You also want to document that SCR_EL3.ECVEn has to be set to 1 for
> > this to work (see Documentation/arm64/booting.txt). And if it isn't,
> > the firmware better handle the CNTPOFF_EL2 traps correctly...
>
> I'll grab the popcorn now ;-) Adding docs for this, good idea.
>
> > What firmware did you use for this? I think we need to update the boot
> > wrapper, but that's something that can be done in parallel.
>
> I had actually just done a direct boot from ARM-TF -> Linux, nothing
> else in between.
Ah, right. I tend to use the boot-wrapper[1] to build a single binary
that contains the 'boot loader', DT and kernel. Using ATF is probably
more representative of the final thing, but the boot-wrapper is dead
easy to hack on...
Thanks,
M.
[1] git://git.kernel.org/pub/scm/linux/kernel/git/mark/boot-wrapper-aarch64.git
--
Without deviation from the norm, progress is not possible.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Oliver Upton <oupton@google.com>
Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Peter Shier <pshier@google.com>,
Jim Mattson <jmattson@google.com>,
David Matlack <dmatlack@google.com>,
Ricardo Koller <ricarkol@google.com>,
Jing Zhang <jingzhangos@google.com>,
Raghavendra Rao Anata <rananta@google.com>,
James Morse <james.morse@arm.com>,
Alexandru Elisei <Alexandru.Elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
linux-arm-kernel@lists.infradead.org,
Andrew Jones <drjones@redhat.com>, Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [PATCH v6 17/21] KVM: arm64: Allow userspace to configure a guest's counter-timer offset
Date: Wed, 11 Aug 2021 10:01:32 +0100 [thread overview]
Message-ID: <87wnos9wyb.wl-maz@kernel.org> (raw)
In-Reply-To: <CAOQ_Qsjn4UK81qBj-uPzoejNc4GAnZXPi=mvcoVi15N0_kayAw@mail.gmail.com>
On Tue, 10 Aug 2021 18:55:12 +0100,
Oliver Upton <oupton@google.com> wrote:
>
> On Tue, Aug 10, 2021 at 3:56 AM Marc Zyngier <maz@kernel.org> wrote:
> >
> > On Wed, 04 Aug 2021 09:58:15 +0100,
> > Oliver Upton <oupton@google.com> wrote:
[...]
> > > diff --git a/include/clocksource/arm_arch_timer.h b/include/clocksource/arm_arch_timer.h
> > > index 73c7139c866f..7252ffa3d675 100644
> > > --- a/include/clocksource/arm_arch_timer.h
> > > +++ b/include/clocksource/arm_arch_timer.h
> > > @@ -21,6 +21,7 @@
> > > #define CNTHCTL_EVNTEN (1 << 2)
> > > #define CNTHCTL_EVNTDIR (1 << 3)
> > > #define CNTHCTL_EVNTI (0xF << 4)
> > > +#define CNTHCTL_ECV (1 << 12)
> > >
> > > enum arch_timer_reg {
> > > ARCH_TIMER_REG_CTRL,
> >
> > You also want to document that SCR_EL3.ECVEn has to be set to 1 for
> > this to work (see Documentation/arm64/booting.txt). And if it isn't,
> > the firmware better handle the CNTPOFF_EL2 traps correctly...
>
> I'll grab the popcorn now ;-) Adding docs for this, good idea.
>
> > What firmware did you use for this? I think we need to update the boot
> > wrapper, but that's something that can be done in parallel.
>
> I had actually just done a direct boot from ARM-TF -> Linux, nothing
> else in between.
Ah, right. I tend to use the boot-wrapper[1] to build a single binary
that contains the 'boot loader', DT and kernel. Using ATF is probably
more representative of the final thing, but the boot-wrapper is dead
easy to hack on...
Thanks,
M.
[1] git://git.kernel.org/pub/scm/linux/kernel/git/mark/boot-wrapper-aarch64.git
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Oliver Upton <oupton@google.com>
Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Peter Shier <pshier@google.com>,
Jim Mattson <jmattson@google.com>,
David Matlack <dmatlack@google.com>,
Ricardo Koller <ricarkol@google.com>,
Jing Zhang <jingzhangos@google.com>,
Raghavendra Rao Anata <rananta@google.com>,
James Morse <james.morse@arm.com>,
Alexandru Elisei <Alexandru.Elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
linux-arm-kernel@lists.infradead.org,
Andrew Jones <drjones@redhat.com>, Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [PATCH v6 17/21] KVM: arm64: Allow userspace to configure a guest's counter-timer offset
Date: Wed, 11 Aug 2021 10:01:32 +0100 [thread overview]
Message-ID: <87wnos9wyb.wl-maz@kernel.org> (raw)
In-Reply-To: <CAOQ_Qsjn4UK81qBj-uPzoejNc4GAnZXPi=mvcoVi15N0_kayAw@mail.gmail.com>
On Tue, 10 Aug 2021 18:55:12 +0100,
Oliver Upton <oupton@google.com> wrote:
>
> On Tue, Aug 10, 2021 at 3:56 AM Marc Zyngier <maz@kernel.org> wrote:
> >
> > On Wed, 04 Aug 2021 09:58:15 +0100,
> > Oliver Upton <oupton@google.com> wrote:
[...]
> > > diff --git a/include/clocksource/arm_arch_timer.h b/include/clocksource/arm_arch_timer.h
> > > index 73c7139c866f..7252ffa3d675 100644
> > > --- a/include/clocksource/arm_arch_timer.h
> > > +++ b/include/clocksource/arm_arch_timer.h
> > > @@ -21,6 +21,7 @@
> > > #define CNTHCTL_EVNTEN (1 << 2)
> > > #define CNTHCTL_EVNTDIR (1 << 3)
> > > #define CNTHCTL_EVNTI (0xF << 4)
> > > +#define CNTHCTL_ECV (1 << 12)
> > >
> > > enum arch_timer_reg {
> > > ARCH_TIMER_REG_CTRL,
> >
> > You also want to document that SCR_EL3.ECVEn has to be set to 1 for
> > this to work (see Documentation/arm64/booting.txt). And if it isn't,
> > the firmware better handle the CNTPOFF_EL2 traps correctly...
>
> I'll grab the popcorn now ;-) Adding docs for this, good idea.
>
> > What firmware did you use for this? I think we need to update the boot
> > wrapper, but that's something that can be done in parallel.
>
> I had actually just done a direct boot from ARM-TF -> Linux, nothing
> else in between.
Ah, right. I tend to use the boot-wrapper[1] to build a single binary
that contains the 'boot loader', DT and kernel. Using ATF is probably
more representative of the final thing, but the boot-wrapper is dead
easy to hack on...
Thanks,
M.
[1] git://git.kernel.org/pub/scm/linux/kernel/git/mark/boot-wrapper-aarch64.git
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2021-08-11 9:01 UTC|newest]
Thread overview: 153+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 8:57 [PATCH v6 00/21] KVM: Add idempotent controls for migrating system counter state Oliver Upton
2021-08-04 8:57 ` Oliver Upton
2021-08-04 8:57 ` Oliver Upton
2021-08-04 8:57 ` [PATCH v6 01/21] KVM: x86: Fix potential race in KVM_GET_CLOCK Oliver Upton
2021-08-04 8:57 ` Oliver Upton
2021-08-04 8:57 ` Oliver Upton
2021-08-11 12:23 ` Paolo Bonzini
2021-08-11 12:23 ` Paolo Bonzini
2021-08-11 12:23 ` Paolo Bonzini
2021-08-13 10:39 ` Oliver Upton
2021-08-13 10:39 ` Oliver Upton
2021-08-13 10:39 ` Oliver Upton
2021-08-13 10:44 ` Paolo Bonzini
2021-08-13 10:44 ` Paolo Bonzini
2021-08-13 10:44 ` Paolo Bonzini
2021-08-13 17:46 ` Oliver Upton
2021-08-13 17:46 ` Oliver Upton
2021-08-13 17:46 ` Oliver Upton
2021-08-04 8:58 ` [PATCH v6 02/21] KVM: x86: Report host tsc and realtime values " Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` [PATCH v6 03/21] KVM: x86: Take the pvclock sync lock behind the tsc_write_lock Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` [PATCH v6 04/21] KVM: x86: Refactor tsc synchronization code Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` [PATCH v6 05/21] KVM: x86: Expose TSC offset controls to userspace Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` [PATCH v6 06/21] tools: arch: x86: pull in pvclock headers Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` [PATCH v6 07/21] selftests: KVM: Add test for KVM_{GET,SET}_CLOCK Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` [PATCH v6 08/21] selftests: KVM: Fix kvm device helper ioctl assertions Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` [PATCH v6 09/21] selftests: KVM: Add helpers for vCPU device attributes Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` [PATCH v6 10/21] selftests: KVM: Introduce system counter offset test Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` [PATCH v6 11/21] KVM: arm64: Refactor update_vtimer_cntvoff() Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 9:23 ` Andrew Jones
2021-08-04 9:23 ` Andrew Jones
2021-08-04 9:23 ` Andrew Jones
2021-08-04 8:58 ` [PATCH v6 12/21] KVM: arm64: Separate guest/host counter offset values Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 10:19 ` Andrew Jones
2021-08-04 10:19 ` Andrew Jones
2021-08-04 10:19 ` Andrew Jones
2021-08-04 8:58 ` [PATCH v6 13/21] KVM: arm64: Allow userspace to configure a vCPU's virtual offset Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 10:20 ` Andrew Jones
2021-08-04 10:20 ` Andrew Jones
2021-08-04 10:20 ` Andrew Jones
2021-08-10 9:35 ` Marc Zyngier
2021-08-10 9:35 ` Marc Zyngier
2021-08-10 9:35 ` Marc Zyngier
2021-08-10 9:44 ` Oliver Upton
2021-08-10 9:44 ` Oliver Upton
2021-08-10 9:44 ` Oliver Upton
2021-08-11 15:22 ` Marc Zyngier
2021-08-11 15:22 ` Marc Zyngier
2021-08-11 15:22 ` Marc Zyngier
2021-08-04 8:58 ` [PATCH v6 14/21] selftests: KVM: Add helper to check for register presence Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 9:14 ` Andrew Jones
2021-08-04 9:14 ` Andrew Jones
2021-08-04 9:14 ` Andrew Jones
2021-08-04 8:58 ` [PATCH v6 15/21] selftests: KVM: Add support for aarch64 to system_counter_offset_test Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` [PATCH v6 16/21] arm64: cpufeature: Enumerate support for Enhanced Counter Virtualization Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-10 9:38 ` Marc Zyngier
2021-08-10 9:38 ` Marc Zyngier
2021-08-10 9:38 ` Marc Zyngier
2021-08-04 8:58 ` [PATCH v6 17/21] KVM: arm64: Allow userspace to configure a guest's counter-timer offset Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 10:17 ` Andrew Jones
2021-08-04 10:17 ` Andrew Jones
2021-08-04 10:17 ` Andrew Jones
2021-08-04 10:22 ` Oliver Upton
2021-08-04 10:22 ` Oliver Upton
2021-08-04 10:22 ` Oliver Upton
2021-08-10 10:56 ` Marc Zyngier
2021-08-10 10:56 ` Marc Zyngier
2021-08-10 10:56 ` Marc Zyngier
2021-08-10 17:55 ` Oliver Upton
2021-08-10 17:55 ` Oliver Upton
2021-08-10 17:55 ` Oliver Upton
2021-08-11 9:01 ` Marc Zyngier [this message]
2021-08-11 9:01 ` Marc Zyngier
2021-08-11 9:01 ` Marc Zyngier
2021-08-04 8:58 ` [PATCH v6 18/21] KVM: arm64: Configure timer traps in vcpu_load() for VHE Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 10:25 ` Andrew Jones
2021-08-04 10:25 ` Andrew Jones
2021-08-04 10:25 ` Andrew Jones
2021-08-04 8:58 ` [PATCH v6 19/21] KVM: arm64: Emulate physical counter offsetting on non-ECV systems Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 11:05 ` Andrew Jones
2021-08-04 11:05 ` Andrew Jones
2021-08-04 11:05 ` Andrew Jones
2021-08-05 6:27 ` Oliver Upton
2021-08-05 6:27 ` Oliver Upton
2021-08-05 6:27 ` Oliver Upton
2021-08-10 11:27 ` Marc Zyngier
2021-08-10 11:27 ` Marc Zyngier
2021-08-10 11:27 ` Marc Zyngier
2021-08-04 8:58 ` [PATCH v6 20/21] selftests: KVM: Test physical counter offsetting Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 11:03 ` Andrew Jones
2021-08-04 11:03 ` Andrew Jones
2021-08-04 11:03 ` Andrew Jones
2021-08-04 8:58 ` [PATCH v6 21/21] selftests: KVM: Add counter emulation benchmark Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 8:58 ` Oliver Upton
2021-08-04 11:05 ` [PATCH v6 00/21] KVM: Add idempotent controls for migrating system counter state Oliver Upton
2021-08-04 11:05 ` Oliver Upton
2021-08-04 11:05 ` Oliver Upton
2021-08-04 22:03 ` Oliver Upton
2021-08-04 22:03 ` Oliver Upton
2021-08-04 22:03 ` Oliver Upton
2021-08-10 0:04 ` Oliver Upton
2021-08-10 0:04 ` Oliver Upton
2021-08-10 0:04 ` Oliver Upton
2021-08-10 12:30 ` Marc Zyngier
2021-08-10 12:30 ` Marc Zyngier
2021-08-10 12:30 ` Marc Zyngier
2021-08-11 13:05 ` Paolo Bonzini
2021-08-11 13:05 ` Paolo Bonzini
2021-08-11 13:05 ` Paolo Bonzini
2021-08-11 18:56 ` Oliver Upton
2021-08-11 18:56 ` Oliver Upton
2021-08-11 18:56 ` Oliver Upton
2021-08-11 19:01 ` Marc Zyngier
2021-08-11 19:01 ` Marc Zyngier
2021-08-11 19:01 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnos9wyb.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dmatlack@google.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=oupton@google.com \
--cc=pbonzini@redhat.com \
--cc=pshier@google.com \
--cc=rananta@google.com \
--cc=seanjc@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.