All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Dave Airlie <airlied@gmail.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Matt Roper <matthew.d.roper@intel.com>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] missing signoff on drm-intel-gt-next pull
Date: Wed, 11 Aug 2021 11:00:32 +0300	[thread overview]
Message-ID: <87wnosmmvz.fsf@intel.com> (raw)
In-Reply-To: <CAPM=9tyVa4S++5r3XU8M=MTqEVUBJ2bf6EnrTVNQwSFJT22XZg@mail.gmail.com>

On Wed, 11 Aug 2021, Dave Airlie <airlied@gmail.com> wrote:
> On Wed, 11 Aug 2021 at 17:11, Jani Nikula <jani.nikula@linux.intel.com> wrote:
>>
>> On Wed, 11 Aug 2021, Joonas Lahtinen <joonas.lahtinen@linux.intel.com> wrote:
>> > Quoting Dave Airlie (2021-08-11 06:48:39)
>> >> dim: db47fe727e1f ("drm/i915/step:
>> >> s/<platform>_revid_tbl/<platform>_revids"): committer Signed-off-by
>> >> missing.
>> >>
>> >> I'm not sure how much pain it is to fix that up, but
>> >> commit db47fe727e1fc516cf60fc9ab8299605ef3c2d54
>> >> Author: Anusha Srivatsa <anusha.srivatsa@intel.com>
>> >> Commit: Matt Roper <matthew.d.roper@intel.com>
>> >>
>> >>     drm/i915/step: s/<platform>_revid_tbl/<platform>_revids
>> >>
>> >>     Simplify the stepping info array name.
>> >>
>> >>     Cc: Jani Nikula <jani.nikula@linux.intel.com>
>> >>     Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
>> >>     Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>> >>     Link: https://patchwork.freedesktop.org/patch/msgid/20210713193635.3390052-2-matthew.d.roper@intel.com
>> >>
>> >> It's definitely missing an S-o-b by anyone who handled the patch.
>> >>
>> >> Let me know if it's insanely painful to fix that.
>> >
>> > Added you to the earlier mail thread that discussed the incident.
>> >
>> > There are now 277 patches on top of that patch, so means rebasing all of
>> > those and changing the hashes and trying to fixup all the Fixes:.
>> >
>> > So it's painful but not insanely so. Let me know if you want the tree
>> > rebased.
>> >
>> > Regards, Joonas
>>
>> The commit came in via a topic branch also to drm-intel-next, so that's
>> another 168 commits to rebase. There's a lot of people working on top of
>> those trees, so I'm leaning on the very painful side.
>
> Okay I think we can let that one slide. Having an S-o-b by someone in
> the org on it is also technically enough for legal purposes anyways.
>
> I'll finish the pulls from both trees tomorrow.

Thanks; in the mean time we'll need to eyeball the tooling to see if we
can plug some of these holes.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Graphics Center

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Dave Airlie <airlied@gmail.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Matt Roper <matthew.d.roper@intel.com>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: missing signoff on drm-intel-gt-next pull
Date: Wed, 11 Aug 2021 11:00:32 +0300	[thread overview]
Message-ID: <87wnosmmvz.fsf@intel.com> (raw)
In-Reply-To: <CAPM=9tyVa4S++5r3XU8M=MTqEVUBJ2bf6EnrTVNQwSFJT22XZg@mail.gmail.com>

On Wed, 11 Aug 2021, Dave Airlie <airlied@gmail.com> wrote:
> On Wed, 11 Aug 2021 at 17:11, Jani Nikula <jani.nikula@linux.intel.com> wrote:
>>
>> On Wed, 11 Aug 2021, Joonas Lahtinen <joonas.lahtinen@linux.intel.com> wrote:
>> > Quoting Dave Airlie (2021-08-11 06:48:39)
>> >> dim: db47fe727e1f ("drm/i915/step:
>> >> s/<platform>_revid_tbl/<platform>_revids"): committer Signed-off-by
>> >> missing.
>> >>
>> >> I'm not sure how much pain it is to fix that up, but
>> >> commit db47fe727e1fc516cf60fc9ab8299605ef3c2d54
>> >> Author: Anusha Srivatsa <anusha.srivatsa@intel.com>
>> >> Commit: Matt Roper <matthew.d.roper@intel.com>
>> >>
>> >>     drm/i915/step: s/<platform>_revid_tbl/<platform>_revids
>> >>
>> >>     Simplify the stepping info array name.
>> >>
>> >>     Cc: Jani Nikula <jani.nikula@linux.intel.com>
>> >>     Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
>> >>     Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>> >>     Link: https://patchwork.freedesktop.org/patch/msgid/20210713193635.3390052-2-matthew.d.roper@intel.com
>> >>
>> >> It's definitely missing an S-o-b by anyone who handled the patch.
>> >>
>> >> Let me know if it's insanely painful to fix that.
>> >
>> > Added you to the earlier mail thread that discussed the incident.
>> >
>> > There are now 277 patches on top of that patch, so means rebasing all of
>> > those and changing the hashes and trying to fixup all the Fixes:.
>> >
>> > So it's painful but not insanely so. Let me know if you want the tree
>> > rebased.
>> >
>> > Regards, Joonas
>>
>> The commit came in via a topic branch also to drm-intel-next, so that's
>> another 168 commits to rebase. There's a lot of people working on top of
>> those trees, so I'm leaning on the very painful side.
>
> Okay I think we can let that one slide. Having an S-o-b by someone in
> the org on it is also technically enough for legal purposes anyways.
>
> I'll finish the pulls from both trees tomorrow.

Thanks; in the mean time we'll need to eyeball the tooling to see if we
can plug some of these holes.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Graphics Center

  reply	other threads:[~2021-08-11  8:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11  3:48 [Intel-gfx] missing signoff on drm-intel-gt-next pull Dave Airlie
2021-08-11  3:48 ` Dave Airlie
2021-08-11  6:05 ` [Intel-gfx] " Joonas Lahtinen
2021-08-11  6:05   ` Joonas Lahtinen
2021-08-11  7:11   ` [Intel-gfx] " Jani Nikula
2021-08-11  7:11     ` Jani Nikula
2021-08-11  7:55     ` [Intel-gfx] " Dave Airlie
2021-08-11  7:55       ` Dave Airlie
2021-08-11  8:00       ` Jani Nikula [this message]
2021-08-11  8:00         ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnosmmvz.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=airlied@gmail.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.