From: Kalle Valo <kvalo@codeaurora.org>
To: Saheed Olayemi Bolarinwa <refactormyself@gmail.com>
Cc: helgaas@kernel.org, "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
bjorn@helgaas.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 4/14 v3] iwlegacy: Check the return value of pcie_capability_read_*()
Date: Mon, 13 Jul 2020 16:44:26 +0300 [thread overview]
Message-ID: <87wo37a5s5.fsf@codeaurora.org> (raw)
In-Reply-To: <20200710212026.27136-5-refactormyself@gmail.com> (Saheed Olayemi Bolarinwa's message of "Fri, 10 Jul 2020 23:20:16 +0200")
+ linux-wireless
Saheed Olayemi Bolarinwa <refactormyself@gmail.com> writes:
> From: Bolarinwa Olayemi Saheed <refactormyself@gmail.com>
>
> Cc: bjorn@helgaas.com,
> skhan@linuxfoundation.org,
> linux-pci@vger.kernel.org,
> linux-kernel-mentees@lists.linuxfoundation.org,
> linux-kernel@vger.kernel.org,
> Stanislaw Gruszka <stf_xl@wp.pl>,
> linux-wireless@vger.kernel.org,
> netdev@vger.kernel.org
>
> On failure pcie_capability_read_dword() sets it's last parameter, val
> to 0. However, with Patch 14/14, it is possible that val is set to ~0 on
> failure. This would introduce a bug because (x & x) == (~0 & x).
>
> This bug can be avoided without changing the function's behaviour if the
> return value of pcie_capability_read_dword is checked to confirm success.
>
> Check the return value of pcie_capability_read_dword() to ensure success.
>
> Suggested-by: Bjorn Helgaas <bjorn@helgaas.com>
> Signed-off-by: Bolarinwa Olayemi Saheed <refactormyself@gmail.com>
Please check your setup, linux-wireless was not in Cc field.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-07-13 13:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 21:20 [PATCH 0/14 v3] PCI: Remove '*val = 0' from pcie_capability_read_*() Saheed Olayemi Bolarinwa
2020-07-10 21:20 ` Saheed Olayemi Bolarinwa
2020-07-10 21:20 ` [Linux-kernel-mentees] " Saheed Olayemi Bolarinwa
2020-07-10 21:20 ` [Linux-kernel-mentees] [PATCH 2/14 v3] misc: rtsx: Check the return value of pcie_capability_read_*() Saheed Olayemi Bolarinwa
2020-07-10 21:20 ` Saheed Olayemi Bolarinwa
2020-07-10 21:20 ` [Linux-kernel-mentees] [PATCH 5/14 v3] PCI: pciehp: " Saheed Olayemi Bolarinwa
2020-07-10 21:20 ` Saheed Olayemi Bolarinwa
2020-07-10 21:20 ` [Linux-kernel-mentees] [PATCH 6/14 v3] PCI: pciehp: Make "Power On" the default Saheed Olayemi Bolarinwa
2020-07-10 21:20 ` Saheed Olayemi Bolarinwa
2020-07-10 21:20 ` [Linux-kernel-mentees] [PATCH 7/14 v3] PCI: pciehp: Check the return value of pcie_capability_read_*() Saheed Olayemi Bolarinwa
2020-07-10 21:20 ` Saheed Olayemi Bolarinwa
2020-07-10 21:20 ` [Linux-kernel-mentees] [PATCH 9/14 v3] PCI: pciehp: Check " Saheed Olayemi Bolarinwa
2020-07-10 21:20 ` Saheed Olayemi Bolarinwa
2020-07-10 21:20 ` [Linux-kernel-mentees] [PATCH 10/14 v3] PCI: " Saheed Olayemi Bolarinwa
2020-07-10 21:20 ` Saheed Olayemi Bolarinwa
2020-07-10 21:20 ` [Linux-kernel-mentees] [PATCH 11/14 v3] PCI/PM: " Saheed Olayemi Bolarinwa
2020-07-10 21:20 ` Saheed Olayemi Bolarinwa
2020-07-14 8:10 ` [Linux-kernel-mentees] " David Laight
2020-07-14 8:10 ` David Laight
2020-07-10 21:20 ` [Linux-kernel-mentees] [PATCH 13/14] PCI/ASPM: Check the " Saheed Olayemi Bolarinwa
2020-07-10 21:20 ` Saheed Olayemi Bolarinwa
2020-07-10 21:20 ` [PATCH 14/14 v3] PCI: Remove '*val = 0' from pcie_capability_read_*() Saheed Olayemi Bolarinwa
2020-07-10 21:20 ` Saheed Olayemi Bolarinwa
2020-07-10 21:20 ` [Linux-kernel-mentees] " Saheed Olayemi Bolarinwa
[not found] ` <20200710212026.27136-5-refactormyself@gmail.com>
2020-07-13 13:44 ` Kalle Valo [this message]
2020-07-13 18:02 ` [PATCH 4/14 v3] iwlegacy: Check the return value of pcie_capability_read_*() Saheed Bolarinwa
-- strict thread matches above, loose matches on Subject: below --
2020-07-13 17:55 [Linux-kernel-mentees] [PATCH 1/14 v3] IB/hfi1: " Saheed O. Bolarinwa
2020-07-13 17:55 ` [PATCH 4/14 v3] iwlegacy: " Saheed O. Bolarinwa
2020-07-15 16:47 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo37a5s5.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=bjorn@helgaas.com \
--cc=davem@davemloft.net \
--cc=helgaas@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=refactormyself@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.