All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/selftests: Flush any i915_active callback work as well
Date: Thu, 24 Oct 2019 11:07:17 +0300	[thread overview]
Message-ID: <87wocu7eiy.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20191023235359.27132-1-chris@chris-wilson.co.uk>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Make trebly sure that all possible callbacks and their delayed brethren
> are complete before asserting that the i915_active should be idle after
> flushing all barriers.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c b/drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c
> index 9fb5d30c43bb..768f032e6578 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c
> @@ -55,6 +55,7 @@ static void pulse_unlock_wait(struct pulse *p)
>  {
>  	mutex_lock(&p->active.mutex);
>  	mutex_unlock(&p->active.mutex);
> +	flush_work(&p->active.work);
>  }
>  
>  static int __live_idle_pulse(struct intel_engine_cs *engine,
> -- 
> 2.24.0.rc0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/selftests: Flush any i915_active callback work as well
Date: Thu, 24 Oct 2019 11:07:17 +0300	[thread overview]
Message-ID: <87wocu7eiy.fsf@gaia.fi.intel.com> (raw)
Message-ID: <20191024080717.dr3s2vTGgOJvr4z0VE7irXDXj7amGWv-z6_GqnZi4Gc@z> (raw)
In-Reply-To: <20191023235359.27132-1-chris@chris-wilson.co.uk>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Make trebly sure that all possible callbacks and their delayed brethren
> are complete before asserting that the i915_active should be idle after
> flushing all barriers.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c b/drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c
> index 9fb5d30c43bb..768f032e6578 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c
> @@ -55,6 +55,7 @@ static void pulse_unlock_wait(struct pulse *p)
>  {
>  	mutex_lock(&p->active.mutex);
>  	mutex_unlock(&p->active.mutex);
> +	flush_work(&p->active.work);
>  }
>  
>  static int __live_idle_pulse(struct intel_engine_cs *engine,
> -- 
> 2.24.0.rc0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-10-24  8:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-23 23:53 [PATCH] drm/i915/selftests: Flush any i915_active callback work as well Chris Wilson
2019-10-23 23:53 ` [Intel-gfx] " Chris Wilson
2019-10-24  3:53 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-10-24  3:53   ` [Intel-gfx] " Patchwork
2019-10-24  8:07 ` Mika Kuoppala [this message]
2019-10-24  8:07   ` [Intel-gfx] [PATCH] " Mika Kuoppala
2019-10-25  2:39 ` ✗ Fi.CI.IGT: failure for " Patchwork
2019-10-25  2:39   ` [Intel-gfx] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wocu7eiy.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.