* Re: [Xen-devel] [PATCH v2] xen/arm: domain_build: Print the correct domain in dtb_load()
2019-08-15 17:29 [Xen-devel] [PATCH v2] xen/arm: domain_build: Print the correct domain in dtb_load() Julien Grall
@ 2019-08-16 16:33 ` Volodymyr Babchuk
2019-10-02 1:20 ` Stefano Stabellini
2019-10-10 14:43 ` Julien Grall
2 siblings, 0 replies; 6+ messages in thread
From: Volodymyr Babchuk @ 2019-08-16 16:33 UTC (permalink / raw)
To: Julien Grall
Cc: xen-devel@lists.xenproject.org, Stefano Stabellini,
Volodymyr Babchuk
Julien Grall writes:
> dtb_load() can be called by other domain than dom0. To avoid confusion
> in the log, print the correct domain.
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
>
> ---
> Changes in v2:
> - Fix the second print in the function as well.
> ---
> xen/arch/arm/domain_build.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 4e51e22927..126374f603 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -1787,15 +1787,17 @@ static void __init dtb_load(struct kernel_info *kinfo)
> {
> unsigned long left;
>
> - printk("Loading dom0 DTB to 0x%"PRIpaddr"-0x%"PRIpaddr"\n",
> - kinfo->dtb_paddr, kinfo->dtb_paddr + fdt_totalsize(kinfo->fdt));
> + printk("Loading %pd DTB to 0x%"PRIpaddr"-0x%"PRIpaddr"\n",
> + kinfo->d, kinfo->dtb_paddr,
> + kinfo->dtb_paddr + fdt_totalsize(kinfo->fdt));
>
> left = copy_to_guest_phys_flush_dcache(kinfo->d, kinfo->dtb_paddr,
> kinfo->fdt,
> fdt_totalsize(kinfo->fdt));
>
> if ( left != 0 )
> - panic("Unable to copy the DTB to dom0 memory (left = %lu bytes)\n", left);
> + panic("Unable to copy the DTB to %pd memory (left = %lu bytes)\n",
> + kinfo->d, left);
> xfree(kinfo->fdt);
> }
--
Volodymyr Babchuk at EPAM
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Xen-devel] [PATCH v2] xen/arm: domain_build: Print the correct domain in dtb_load()
2019-08-15 17:29 [Xen-devel] [PATCH v2] xen/arm: domain_build: Print the correct domain in dtb_load() Julien Grall
2019-08-16 16:33 ` Volodymyr Babchuk
@ 2019-10-02 1:20 ` Stefano Stabellini
2019-10-10 14:43 ` Julien Grall
2 siblings, 0 replies; 6+ messages in thread
From: Stefano Stabellini @ 2019-10-02 1:20 UTC (permalink / raw)
To: Julien Grall; +Cc: xen-devel, Stefano Stabellini, Volodymyr Babchuk
On Thu, 15 Aug 2019, Julien Grall wrote:
> dtb_load() can be called by other domain than dom0. To avoid confusion
> in the log, print the correct domain.
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> Changes in v2:
> - Fix the second print in the function as well.
> ---
> xen/arch/arm/domain_build.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 4e51e22927..126374f603 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -1787,15 +1787,17 @@ static void __init dtb_load(struct kernel_info *kinfo)
> {
> unsigned long left;
>
> - printk("Loading dom0 DTB to 0x%"PRIpaddr"-0x%"PRIpaddr"\n",
> - kinfo->dtb_paddr, kinfo->dtb_paddr + fdt_totalsize(kinfo->fdt));
> + printk("Loading %pd DTB to 0x%"PRIpaddr"-0x%"PRIpaddr"\n",
> + kinfo->d, kinfo->dtb_paddr,
> + kinfo->dtb_paddr + fdt_totalsize(kinfo->fdt));
>
> left = copy_to_guest_phys_flush_dcache(kinfo->d, kinfo->dtb_paddr,
> kinfo->fdt,
> fdt_totalsize(kinfo->fdt));
>
> if ( left != 0 )
> - panic("Unable to copy the DTB to dom0 memory (left = %lu bytes)\n", left);
> + panic("Unable to copy the DTB to %pd memory (left = %lu bytes)\n",
> + kinfo->d, left);
> xfree(kinfo->fdt);
> }
>
> --
> 2.11.0
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Xen-devel] [PATCH v2] xen/arm: domain_build: Print the correct domain in dtb_load()
2019-08-15 17:29 [Xen-devel] [PATCH v2] xen/arm: domain_build: Print the correct domain in dtb_load() Julien Grall
2019-08-16 16:33 ` Volodymyr Babchuk
2019-10-02 1:20 ` Stefano Stabellini
@ 2019-10-10 14:43 ` Julien Grall
2019-10-15 16:45 ` Julien Grall
2 siblings, 1 reply; 6+ messages in thread
From: Julien Grall @ 2019-10-10 14:43 UTC (permalink / raw)
To: xen-devel; +Cc: Juergen Gross, Stefano Stabellini, Volodymyr Babchuk
Hi,
Hmm, it looks like I forgot this patch before the freeze. Juergen, are you happy
with this to go in Xen 4.13?
Cheers,
On 15/08/2019 18:29, Julien Grall wrote:
> dtb_load() can be called by other domain than dom0. To avoid confusion
> in the log, print the correct domain.
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
>
> ---
> Changes in v2:
> - Fix the second print in the function as well.
> ---
> xen/arch/arm/domain_build.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 4e51e22927..126374f603 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -1787,15 +1787,17 @@ static void __init dtb_load(struct kernel_info *kinfo)
> {
> unsigned long left;
>
> - printk("Loading dom0 DTB to 0x%"PRIpaddr"-0x%"PRIpaddr"\n",
> - kinfo->dtb_paddr, kinfo->dtb_paddr + fdt_totalsize(kinfo->fdt));
> + printk("Loading %pd DTB to 0x%"PRIpaddr"-0x%"PRIpaddr"\n",
> + kinfo->d, kinfo->dtb_paddr,
> + kinfo->dtb_paddr + fdt_totalsize(kinfo->fdt));
>
> left = copy_to_guest_phys_flush_dcache(kinfo->d, kinfo->dtb_paddr,
> kinfo->fdt,
> fdt_totalsize(kinfo->fdt));
>
> if ( left != 0 )
> - panic("Unable to copy the DTB to dom0 memory (left = %lu bytes)\n", left);
> + panic("Unable to copy the DTB to %pd memory (left = %lu bytes)\n",
> + kinfo->d, left);
> xfree(kinfo->fdt);
> }
>
>
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Xen-devel] [PATCH v2] xen/arm: domain_build: Print the correct domain in dtb_load()
2019-10-10 14:43 ` Julien Grall
@ 2019-10-15 16:45 ` Julien Grall
2019-10-16 4:53 ` Jürgen Groß
0 siblings, 1 reply; 6+ messages in thread
From: Julien Grall @ 2019-10-15 16:45 UTC (permalink / raw)
To: xen-devel, Juergen Gross; +Cc: Stefano Stabellini, Volodymyr Babchuk
Hi Juergen,
Gentle ping.
Cheers,
On 10/10/19 3:43 PM, Julien Grall wrote:
> Hi,
>
> Hmm, it looks like I forgot this patch before the freeze. Juergen, are
> you happy with this to go in Xen 4.13?
>
> Cheers,
>
> On 15/08/2019 18:29, Julien Grall wrote:
>> dtb_load() can be called by other domain than dom0. To avoid confusion
>> in the log, print the correct domain.
>>
>> Signed-off-by: Julien Grall <julien.grall@arm.com>
>>
>> ---
>> Changes in v2:
>> - Fix the second print in the function as well.
>> ---
>> xen/arch/arm/domain_build.c | 8 +++++---
>> 1 file changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
>> index 4e51e22927..126374f603 100644
>> --- a/xen/arch/arm/domain_build.c
>> +++ b/xen/arch/arm/domain_build.c
>> @@ -1787,15 +1787,17 @@ static void __init dtb_load(struct kernel_info
>> *kinfo)
>> {
>> unsigned long left;
>> - printk("Loading dom0 DTB to 0x%"PRIpaddr"-0x%"PRIpaddr"\n",
>> - kinfo->dtb_paddr, kinfo->dtb_paddr +
>> fdt_totalsize(kinfo->fdt));
>> + printk("Loading %pd DTB to 0x%"PRIpaddr"-0x%"PRIpaddr"\n",
>> + kinfo->d, kinfo->dtb_paddr,
>> + kinfo->dtb_paddr + fdt_totalsize(kinfo->fdt));
>> left = copy_to_guest_phys_flush_dcache(kinfo->d, kinfo->dtb_paddr,
>> kinfo->fdt,
>> fdt_totalsize(kinfo->fdt));
>> if ( left != 0 )
>> - panic("Unable to copy the DTB to dom0 memory (left = %lu
>> bytes)\n", left);
>> + panic("Unable to copy the DTB to %pd memory (left = %lu
>> bytes)\n",
>> + kinfo->d, left);
>> xfree(kinfo->fdt);
>> }
>>
>
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Xen-devel] [PATCH v2] xen/arm: domain_build: Print the correct domain in dtb_load()
2019-10-15 16:45 ` Julien Grall
@ 2019-10-16 4:53 ` Jürgen Groß
0 siblings, 0 replies; 6+ messages in thread
From: Jürgen Groß @ 2019-10-16 4:53 UTC (permalink / raw)
To: Julien Grall, xen-devel; +Cc: Stefano Stabellini, Volodymyr Babchuk
On 15.10.19 18:45, Julien Grall wrote:
> Hi Juergen,
>
> Gentle ping.
>
> Cheers,
>
> On 10/10/19 3:43 PM, Julien Grall wrote:
>> Hi,
>>
>> Hmm, it looks like I forgot this patch before the freeze. Juergen, are
>> you happy with this to go in Xen 4.13?
>>
>> Cheers,
>>
>> On 15/08/2019 18:29, Julien Grall wrote:
>>> dtb_load() can be called by other domain than dom0. To avoid confusion
>>> in the log, print the correct domain.
>>>
>>> Signed-off-by: Julien Grall <julien.grall@arm.com>
Release-acked-by: Juergen Gross <jgross@suse.com>
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread