Re: [PATCH v5 1/2] kvm: support -overcommit cpu-pm=on|off

[Juan Quintela <quintela@redhat.com>]

"Michael S. Tsirkin" <mst@redhat.com> wrote:
> With this flag, kvm allows guest to control host CPU power state.  This
> increases latency for other processes using same host CPU in an
> unpredictable way, but if decreases idle entry/exit times for the
> running VCPU, so to use it QEMU needs a hint about whether host CPU is
> overcommitted, hence the flag name.
>
> Follow-up patches will expose this capability to guest
> (using mwait leaf).
>
> Based on a patch by Wanpeng Li <kernellwp@gmail.com> .
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

[...]

> diff --git a/migration/migration.c b/migration/migration.c
> index 1e99ec9b7e..e468b50c4f 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -45,6 +45,7 @@
>  #include "migration/colo.h"
>  #include "hw/boards.h"
>  #include "monitor/monitor.h"
> +#include "qemu/ptr_ring.h"
>  
>  #define MAX_THROTTLE  (32 << 20)      /* Migration transfer speed throttling */
>  

Why is this chuck needed?  I can't see a reason.


Thanks, Juan.