* [PATCH] drm/i915: Initialize panel_pipe to INVALID_PIPE
@ 2018-05-23 14:57 Ville Syrjala
2018-05-23 15:12 ` Jani Nikula
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Ville Syrjala @ 2018-05-23 14:57 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
We can always figure out which pipe is affected by the panel power
sequencer lockout mechanism. So no need for the pipe A fallback
anymore. The only case we may have to worry about is an invalid
port select in the power sequencer, but INVALID_PIPE is just fine
in that case. We'll get the WARN about the bogus pps port select
anyway.
Cc: Jani Nikula <jani.nikula@intel.com>
Suggested-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 1afd70fdbd85..25285939f987 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -1202,7 +1202,7 @@ void assert_panel_unlocked(struct drm_i915_private *dev_priv, enum pipe pipe)
{
i915_reg_t pp_reg;
u32 val;
- enum pipe panel_pipe = PIPE_A;
+ enum pipe panel_pipe = INVALID_PIPE;
bool locked = true;
if (WARN_ON(HAS_DDI(dev_priv)))
--
2.16.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: Initialize panel_pipe to INVALID_PIPE
2018-05-23 14:57 [PATCH] drm/i915: Initialize panel_pipe to INVALID_PIPE Ville Syrjala
@ 2018-05-23 15:12 ` Jani Nikula
2018-05-23 15:21 ` Ville Syrjälä
2018-05-23 16:46 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-05-23 19:02 ` ✓ Fi.CI.IGT: " Patchwork
2 siblings, 1 reply; 5+ messages in thread
From: Jani Nikula @ 2018-05-23 15:12 UTC (permalink / raw)
To: Ville Syrjala, intel-gfx
On Wed, 23 May 2018, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We can always figure out which pipe is affected by the panel power
> sequencer lockout mechanism. So no need for the pipe A fallback
> anymore. The only case we may have to worry about is an invalid
> port select in the power sequencer, but INVALID_PIPE is just fine
> in that case. We'll get the WARN about the bogus pps port select
> anyway.
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Suggested-by: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Hmm, do the same for cpt_dp_port_selected() fail path? Or keep that as
pipe A to cause mismatch and error?
> ---
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 1afd70fdbd85..25285939f987 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -1202,7 +1202,7 @@ void assert_panel_unlocked(struct drm_i915_private *dev_priv, enum pipe pipe)
> {
> i915_reg_t pp_reg;
> u32 val;
> - enum pipe panel_pipe = PIPE_A;
> + enum pipe panel_pipe = INVALID_PIPE;
> bool locked = true;
>
> if (WARN_ON(HAS_DDI(dev_priv)))
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: Initialize panel_pipe to INVALID_PIPE
2018-05-23 15:12 ` Jani Nikula
@ 2018-05-23 15:21 ` Ville Syrjälä
0 siblings, 0 replies; 5+ messages in thread
From: Ville Syrjälä @ 2018-05-23 15:21 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Wed, May 23, 2018 at 06:12:44PM +0300, Jani Nikula wrote:
> On Wed, 23 May 2018, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > We can always figure out which pipe is affected by the panel power
> > sequencer lockout mechanism. So no need for the pipe A fallback
> > anymore. The only case we may have to worry about is an invalid
> > port select in the power sequencer, but INVALID_PIPE is just fine
> > in that case. We'll get the WARN about the bogus pps port select
> > anyway.
> >
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Suggested-by: Jani Nikula <jani.nikula@intel.com>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> Hmm, do the same for cpt_dp_port_selected() fail path? Or keep that as
> pipe A to cause mismatch and error?
I think we can change it back to INVALID_PIPE too. I had some idea why
I'd have to make it a valid pipe even if the port is disabled, but I
guess that was just nonsense. Or at least I can't see why anything
would fail badly with INVALID_PIPE now.
>
>
> > ---
> > drivers/gpu/drm/i915/intel_display.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> > index 1afd70fdbd85..25285939f987 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -1202,7 +1202,7 @@ void assert_panel_unlocked(struct drm_i915_private *dev_priv, enum pipe pipe)
> > {
> > i915_reg_t pp_reg;
> > u32 val;
> > - enum pipe panel_pipe = PIPE_A;
> > + enum pipe panel_pipe = INVALID_PIPE;
> > bool locked = true;
> >
> > if (WARN_ON(HAS_DDI(dev_priv)))
>
> --
> Jani Nikula, Intel Open Source Graphics Center
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Initialize panel_pipe to INVALID_PIPE
2018-05-23 14:57 [PATCH] drm/i915: Initialize panel_pipe to INVALID_PIPE Ville Syrjala
2018-05-23 15:12 ` Jani Nikula
@ 2018-05-23 16:46 ` Patchwork
2018-05-23 19:02 ` ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-05-23 16:46 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Initialize panel_pipe to INVALID_PIPE
URL : https://patchwork.freedesktop.org/series/43641/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4225 -> Patchwork_9097 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/43641/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_9097 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_flip@basic-flip-vs-wf_vblank:
fi-hsw-4770r: PASS -> FAIL (fdo#103928)
==== Possible fixes ====
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-snb-2520m: INCOMPLETE (fdo#103713) -> PASS
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
== Participating hosts (44 -> 39) ==
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-skl-6700hq
== Build changes ==
* Linux: CI_DRM_4225 -> Patchwork_9097
CI_DRM_4225: 88ca72d89921db7a46dfb1492e2059e04a7b6c5e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4493: 0b381c7d1067a4fe520b72d4d391d4920834cbe0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9097: e08ed995a53a19bf554c03755c9d3cc8c7e33d77 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4493: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Linux commits ==
e08ed995a53a drm/i915: Initialize panel_pipe to INVALID_PIPE
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9097/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* ✓ Fi.CI.IGT: success for drm/i915: Initialize panel_pipe to INVALID_PIPE
2018-05-23 14:57 [PATCH] drm/i915: Initialize panel_pipe to INVALID_PIPE Ville Syrjala
2018-05-23 15:12 ` Jani Nikula
2018-05-23 16:46 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-05-23 19:02 ` Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-05-23 19:02 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Initialize panel_pipe to INVALID_PIPE
URL : https://patchwork.freedesktop.org/series/43641/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4225_full -> Patchwork_9097_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_9097_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_9097_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/43641/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9097_full:
=== IGT changes ===
==== Warnings ====
igt@gem_exec_schedule@deep-bsd2:
shard-kbl: PASS -> SKIP +1
== Known issues ==
Here are the changes found in Patchwork_9097_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_flip@2x-plain-flip-ts-check-interruptible:
shard-glk: PASS -> FAIL (fdo#100368)
igt@kms_flip@blocking-wf_vblank:
shard-glk: PASS -> FAIL (fdo#103928)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render:
shard-snb: PASS -> FAIL (fdo#103167, fdo#104724)
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
==== Possible fixes ====
igt@drv_selftest@live_gtt:
shard-glk: FAIL -> PASS
igt@drv_selftest@live_hangcheck:
shard-kbl: DMESG-FAIL (fdo#106560) -> PASS
igt@gem_ppgtt@blt-vs-render-ctx0:
shard-kbl: INCOMPLETE (fdo#106023, fdo#103665) -> PASS
igt@kms_flip@2x-plain-flip-fb-recreate:
shard-hsw: FAIL (fdo#100368) -> PASS +1
igt@kms_flip@plain-flip-fb-recreate-interruptible:
shard-glk: FAIL (fdo#100368) -> PASS +1
igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
shard-glk: INCOMPLETE (k.org#198133, fdo#103359) -> PASS
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4225 -> Patchwork_9097
CI_DRM_4225: 88ca72d89921db7a46dfb1492e2059e04a7b6c5e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4493: 0b381c7d1067a4fe520b72d4d391d4920834cbe0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9097: e08ed995a53a19bf554c03755c9d3cc8c7e33d77 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4493: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9097/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-05-23 19:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-23 14:57 [PATCH] drm/i915: Initialize panel_pipe to INVALID_PIPE Ville Syrjala
2018-05-23 15:12 ` Jani Nikula
2018-05-23 15:21 ` Ville Syrjälä
2018-05-23 16:46 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-05-23 19:02 ` ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.