From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next-queue PATCH v4 2/8] igb: Fix queue selection on MAC filters on i210 and i211
Date: Wed, 14 Mar 2018 10:25:29 -0700 [thread overview]
Message-ID: <87woyewovq.fsf@intel.com> (raw)
In-Reply-To: <309B89C4C689E141A5FF6A0C5FB2118B8C8032BA@ORSMSX101.amr.corp.intel.com>
Hi,
"Brown, Aaron F" <aaron.f.brown@intel.com> writes:
>> --- a/drivers/net/ethernet/intel/igb/igb_main.c
>> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
>> @@ -8747,12 +8747,19 @@ static void igb_rar_set_index(struct igb_adapter
>> *adapter, u32 index)
>> if (is_valid_ether_addr(addr))
>> rar_high |= E1000_RAH_AV;
>>
>> - if (hw->mac.type == e1000_82575)
>> + switch (hw->mac.type) {
>> + case e1000_82575:
>> + case e1000_i210:
>> + case e1000_i211:
>> + rar_high |= E1000_RAH_QSEL_ENABLE;
>> rar_high |= E1000_RAH_POOL_1 *
>> - adapter->mac_table[index].queue;
>> - else
>> + adapter->mac_table[index].queue;
>> + break;
>> + default:
>> rar_high |= E1000_RAH_POOL_1 <<
>> - adapter->mac_table[index].queue;
>> + adapter->mac_table[index].queue;
>
> Small nit. Shouldn't this line be indented more to be a few spaces
> past the "|=" operator as above?
I don't know why my editor seemed to disagree, I will fix.
Thank you,
--
Vinicius
WARNING: multiple messages have this Message-ID (diff)
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: "Brown\, Aaron F" <aaron.f.brown@intel.com>,
"intel-wired-lan\@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>
Cc: "netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
"Sanchez-Palencia\, Jesus" <jesus.sanchez-palencia@intel.com>
Subject: RE: [Intel-wired-lan] [next-queue PATCH v4 2/8] igb: Fix queue selection on MAC filters on i210 and i211
Date: Wed, 14 Mar 2018 10:25:29 -0700 [thread overview]
Message-ID: <87woyewovq.fsf@intel.com> (raw)
In-Reply-To: <309B89C4C689E141A5FF6A0C5FB2118B8C8032BA@ORSMSX101.amr.corp.intel.com>
Hi,
"Brown, Aaron F" <aaron.f.brown@intel.com> writes:
>> --- a/drivers/net/ethernet/intel/igb/igb_main.c
>> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
>> @@ -8747,12 +8747,19 @@ static void igb_rar_set_index(struct igb_adapter
>> *adapter, u32 index)
>> if (is_valid_ether_addr(addr))
>> rar_high |= E1000_RAH_AV;
>>
>> - if (hw->mac.type == e1000_82575)
>> + switch (hw->mac.type) {
>> + case e1000_82575:
>> + case e1000_i210:
>> + case e1000_i211:
>> + rar_high |= E1000_RAH_QSEL_ENABLE;
>> rar_high |= E1000_RAH_POOL_1 *
>> - adapter->mac_table[index].queue;
>> - else
>> + adapter->mac_table[index].queue;
>> + break;
>> + default:
>> rar_high |= E1000_RAH_POOL_1 <<
>> - adapter->mac_table[index].queue;
>> + adapter->mac_table[index].queue;
>
> Small nit. Shouldn't this line be indented more to be a few spaces
> past the "|=" operator as above?
I don't know why my editor seemed to disagree, I will fix.
Thank you,
--
Vinicius
next prev parent reply other threads:[~2018-03-14 17:25 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 0:37 [Intel-wired-lan] [next-queue PATCH v3 0/8] igb: offloading of receive filters Vinicius Costa Gomes
2018-03-08 0:37 ` Vinicius Costa Gomes
2018-03-08 0:37 ` [Intel-wired-lan] [next-queue PATCH v4 1/8] igb: Fix not adding filter elements to the list Vinicius Costa Gomes
2018-03-08 0:37 ` Vinicius Costa Gomes
2018-03-08 0:37 ` [Intel-wired-lan] [next-queue PATCH v4 2/8] igb: Fix queue selection on MAC filters on i210 and i211 Vinicius Costa Gomes
2018-03-08 0:37 ` Vinicius Costa Gomes
2018-03-14 3:07 ` [Intel-wired-lan] " Brown, Aaron F
2018-03-14 3:07 ` Brown, Aaron F
2018-03-14 17:25 ` Vinicius Costa Gomes [this message]
2018-03-14 17:25 ` Vinicius Costa Gomes
2018-03-08 0:37 ` [Intel-wired-lan] [next-queue PATCH v4 3/8] igb: Enable the hardware traffic class feature bit for igb models Vinicius Costa Gomes
2018-03-08 0:37 ` Vinicius Costa Gomes
2018-03-08 0:37 ` [Intel-wired-lan] [next-queue PATCH v4 4/8] igb: Add support for MAC address filters specifying source addresses Vinicius Costa Gomes
2018-03-08 0:37 ` Vinicius Costa Gomes
2018-03-08 0:37 ` [Intel-wired-lan] [next-queue PATCH v4 5/8] igb: Enable nfc filters to specify MAC addresses Vinicius Costa Gomes
2018-03-08 0:37 ` Vinicius Costa Gomes
2018-03-08 0:37 ` [Intel-wired-lan] [next-queue PATCH v4 6/8] igb: Add MAC address support for ethtool nftuple filters Vinicius Costa Gomes
2018-03-08 0:37 ` Vinicius Costa Gomes
2018-03-14 3:04 ` [Intel-wired-lan] " Brown, Aaron F
2018-03-14 3:04 ` Brown, Aaron F
2018-03-14 19:58 ` Vinicius Costa Gomes
2018-03-14 19:58 ` Vinicius Costa Gomes
2018-03-16 17:38 ` Alexander Duyck
2018-03-16 17:38 ` Alexander Duyck
2018-03-16 17:59 ` Vinicius Costa Gomes
2018-03-16 17:59 ` Vinicius Costa Gomes
2018-03-16 18:07 ` Alexander Duyck
2018-03-16 18:07 ` Alexander Duyck
2018-03-16 18:14 ` Brown, Aaron F
2018-03-16 18:14 ` Brown, Aaron F
2018-03-08 0:37 ` [Intel-wired-lan] [next-queue PATCH v4 7/8] igb: Add the skeletons for tc-flower offloading Vinicius Costa Gomes
2018-03-08 0:37 ` Vinicius Costa Gomes
2018-03-08 0:37 ` [Intel-wired-lan] [next-queue PATCH v4 8/8] igb: Add support for adding offloaded clsflower filters Vinicius Costa Gomes
2018-03-08 0:37 ` Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87woyewovq.fsf@intel.com \
--to=vinicius.gomes@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.