* Possible bug in Armada-37xx pincontroller
@ 2017-11-06 14:12 ` Henrik Juul Pedersen
0 siblings, 0 replies; 4+ messages in thread
From: Henrik Juul Pedersen @ 2017-11-06 14:12 UTC (permalink / raw)
To: Jason Cooper, Andrew Lunn, Gregory Clement, Sebastian Hesselbarth
Cc: linux-arm-kernel, linux-gpio, Emil Vesterdahl
Hi,
After some review of a current Armada 37xx design, we stumbled upon
some pin numbering, which seems doubly-defined, and doesn't seem to
follow the documentation available to us.
We haven't gotten our hardware yet, so we haven't been able to test
it, but the following patch is as we believe it should be defined.
Best regards,
Henrik Juul Pedersen
LIAB ApS
---
diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
index 71b944748304..e223fac20993 100644
--- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
+++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
@@ -157,8 +157,8 @@ static struct armada_37xx_pin_group
armada_37xx_nb_groups[] = {
PIN_GRP_GPIO("pwm1", 12, 1, BIT(4), "pwm"),
PIN_GRP_GPIO("pwm2", 13, 1, BIT(5), "pwm"),
PIN_GRP_GPIO("pwm3", 14, 1, BIT(6), "pwm"),
- PIN_GRP_GPIO("pmic1", 17, 1, BIT(7), "pmic"),
- PIN_GRP_GPIO("pmic0", 16, 1, BIT(8), "pmic"),
+ PIN_GRP_GPIO("pmic1", 7, 1, BIT(7), "pmic"),
+ PIN_GRP_GPIO("pmic0", 6, 1, BIT(8), "pmic"),
PIN_GRP_GPIO("i2c2", 2, 2, BIT(9), "i2c"),
PIN_GRP_GPIO("i2c1", 0, 2, BIT(10), "i2c"),
PIN_GRP_GPIO("spi_cs1", 17, 1, BIT(12), "spi"),
^ permalink raw reply related [flat|nested] 4+ messages in thread* Possible bug in Armada-37xx pincontroller
@ 2017-11-06 14:12 ` Henrik Juul Pedersen
0 siblings, 0 replies; 4+ messages in thread
From: Henrik Juul Pedersen @ 2017-11-06 14:12 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
After some review of a current Armada 37xx design, we stumbled upon
some pin numbering, which seems doubly-defined, and doesn't seem to
follow the documentation available to us.
We haven't gotten our hardware yet, so we haven't been able to test
it, but the following patch is as we believe it should be defined.
Best regards,
Henrik Juul Pedersen
LIAB ApS
---
diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
index 71b944748304..e223fac20993 100644
--- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
+++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
@@ -157,8 +157,8 @@ static struct armada_37xx_pin_group
armada_37xx_nb_groups[] = {
PIN_GRP_GPIO("pwm1", 12, 1, BIT(4), "pwm"),
PIN_GRP_GPIO("pwm2", 13, 1, BIT(5), "pwm"),
PIN_GRP_GPIO("pwm3", 14, 1, BIT(6), "pwm"),
- PIN_GRP_GPIO("pmic1", 17, 1, BIT(7), "pmic"),
- PIN_GRP_GPIO("pmic0", 16, 1, BIT(8), "pmic"),
+ PIN_GRP_GPIO("pmic1", 7, 1, BIT(7), "pmic"),
+ PIN_GRP_GPIO("pmic0", 6, 1, BIT(8), "pmic"),
PIN_GRP_GPIO("i2c2", 2, 2, BIT(9), "i2c"),
PIN_GRP_GPIO("i2c1", 0, 2, BIT(10), "i2c"),
PIN_GRP_GPIO("spi_cs1", 17, 1, BIT(12), "spi"),
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: Possible bug in Armada-37xx pincontroller
2017-11-06 14:12 ` Henrik Juul Pedersen
@ 2017-11-06 15:05 ` Gregory CLEMENT
-1 siblings, 0 replies; 4+ messages in thread
From: Gregory CLEMENT @ 2017-11-06 15:05 UTC (permalink / raw)
To: Henrik Juul Pedersen
Cc: Jason Cooper, Andrew Lunn, Sebastian Hesselbarth, linux-gpio,
Emil Vesterdahl, linux-arm-kernel
Hi Henrik,
On lun., nov. 06 2017, Henrik Juul Pedersen <hjp@liab.dk> wrote:
> Hi,
>
> After some review of a current Armada 37xx design, we stumbled upon
> some pin numbering, which seems doubly-defined, and doesn't seem to
> follow the documentation available to us.
Thanks for the report, indeed it seems to be a typo.
If you want to provide a patch for it then you will have to give a
proper commit log as well as your Signed-off-by.
Else I can take care of it.
Gregory
>
> We haven't gotten our hardware yet, so we haven't been able to test
> it, but the following patch is as we believe it should be defined.
>
> Best regards,
> Henrik Juul Pedersen
> LIAB ApS
>
> ---
>
> diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> index 71b944748304..e223fac20993 100644
> --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> @@ -157,8 +157,8 @@ static struct armada_37xx_pin_group
> armada_37xx_nb_groups[] = {
> PIN_GRP_GPIO("pwm1", 12, 1, BIT(4), "pwm"),
> PIN_GRP_GPIO("pwm2", 13, 1, BIT(5), "pwm"),
> PIN_GRP_GPIO("pwm3", 14, 1, BIT(6), "pwm"),
> - PIN_GRP_GPIO("pmic1", 17, 1, BIT(7), "pmic"),
> - PIN_GRP_GPIO("pmic0", 16, 1, BIT(8), "pmic"),
> + PIN_GRP_GPIO("pmic1", 7, 1, BIT(7), "pmic"),
> + PIN_GRP_GPIO("pmic0", 6, 1, BIT(8), "pmic"),
> PIN_GRP_GPIO("i2c2", 2, 2, BIT(9), "i2c"),
> PIN_GRP_GPIO("i2c1", 0, 2, BIT(10), "i2c"),
> PIN_GRP_GPIO("spi_cs1", 17, 1, BIT(12), "spi"),
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread* Possible bug in Armada-37xx pincontroller
@ 2017-11-06 15:05 ` Gregory CLEMENT
0 siblings, 0 replies; 4+ messages in thread
From: Gregory CLEMENT @ 2017-11-06 15:05 UTC (permalink / raw)
To: linux-arm-kernel
Hi Henrik,
On lun., nov. 06 2017, Henrik Juul Pedersen <hjp@liab.dk> wrote:
> Hi,
>
> After some review of a current Armada 37xx design, we stumbled upon
> some pin numbering, which seems doubly-defined, and doesn't seem to
> follow the documentation available to us.
Thanks for the report, indeed it seems to be a typo.
If you want to provide a patch for it then you will have to give a
proper commit log as well as your Signed-off-by.
Else I can take care of it.
Gregory
>
> We haven't gotten our hardware yet, so we haven't been able to test
> it, but the following patch is as we believe it should be defined.
>
> Best regards,
> Henrik Juul Pedersen
> LIAB ApS
>
> ---
>
> diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> index 71b944748304..e223fac20993 100644
> --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> @@ -157,8 +157,8 @@ static struct armada_37xx_pin_group
> armada_37xx_nb_groups[] = {
> PIN_GRP_GPIO("pwm1", 12, 1, BIT(4), "pwm"),
> PIN_GRP_GPIO("pwm2", 13, 1, BIT(5), "pwm"),
> PIN_GRP_GPIO("pwm3", 14, 1, BIT(6), "pwm"),
> - PIN_GRP_GPIO("pmic1", 17, 1, BIT(7), "pmic"),
> - PIN_GRP_GPIO("pmic0", 16, 1, BIT(8), "pmic"),
> + PIN_GRP_GPIO("pmic1", 7, 1, BIT(7), "pmic"),
> + PIN_GRP_GPIO("pmic0", 6, 1, BIT(8), "pmic"),
> PIN_GRP_GPIO("i2c2", 2, 2, BIT(9), "i2c"),
> PIN_GRP_GPIO("i2c1", 0, 2, BIT(10), "i2c"),
> PIN_GRP_GPIO("spi_cs1", 17, 1, BIT(12), "spi"),
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-06 15:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-06 14:12 Possible bug in Armada-37xx pincontroller Henrik Juul Pedersen
2017-11-06 14:12 ` Henrik Juul Pedersen
2017-11-06 15:05 ` Gregory CLEMENT
2017-11-06 15:05 ` Gregory CLEMENT
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.