From: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Xinliang Liu <z.liuxinliang@hisilicon.com>,
zourongrong@gmail.com, kong.kongxinwei@hisilicon.com,
puck.chen@hisilicon.com, airlied@linux.ie, robh@kernel.org,
rmk+kernel@armlinux.org.uk, treding@nvidia.com, arnd@arndb.de,
daniel.vetter@ffwll.ch, seanpaul@chromium.org, jsarha@ti.com,
noralf@tronnes.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: Fix return value check in kirin_drm_platform_probe()
Date: Thu, 12 Oct 2017 03:39:59 -0300 [thread overview]
Message-ID: <87wp40oon4.fsf@dilma.collabora.co.uk> (raw)
In-Reply-To: <1507720636-129038-1-git-send-email-weiyongjun1@huawei.com> (Wei Yongjun's message of "Wed, 11 Oct 2017 11:17:16 +0000")
Wei Yongjun <weiyongjun1@huawei.com> writes:
> In case of error, the function of_graph_get_remote_node() returns NULL
> pointer not ERR_PTR(). The IS_ERR() test in the return value check
> should be replaced with NULL test..
Looks good.
Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
--
Gabriel Krisman Bertazi
WARNING: multiple messages have this Message-ID (diff)
From: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Xinliang Liu <z.liuxinliang@hisilicon.com>,
<zourongrong@gmail.com>, <kong.kongxinwei@hisilicon.com>,
<puck.chen@hisilicon.com>, <airlied@linux.ie>, <robh@kernel.org>,
<rmk+kernel@armlinux.org.uk>, <treding@nvidia.com>,
<arnd@arndb.de>, <daniel.vetter@ffwll.ch>,
<seanpaul@chromium.org>, <jsarha@ti.com>, <noralf@tronnes.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm: Fix return value check in kirin_drm_platform_probe()
Date: Thu, 12 Oct 2017 03:39:59 -0300 [thread overview]
Message-ID: <87wp40oon4.fsf@dilma.collabora.co.uk> (raw)
In-Reply-To: <1507720636-129038-1-git-send-email-weiyongjun1@huawei.com> (Wei Yongjun's message of "Wed, 11 Oct 2017 11:17:16 +0000")
Wei Yongjun <weiyongjun1@huawei.com> writes:
> In case of error, the function of_graph_get_remote_node() returns NULL
> pointer not ERR_PTR(). The IS_ERR() test in the return value check
> should be replaced with NULL test..
Looks good.
Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
--
Gabriel Krisman Bertazi
next prev parent reply other threads:[~2017-10-12 6:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 11:17 [PATCH] drm: Fix return value check in kirin_drm_platform_probe() Wei Yongjun
2017-10-11 11:17 ` Wei Yongjun
2017-10-11 17:30 ` Sean Paul
2017-10-11 17:30 ` Sean Paul
2017-10-12 6:39 ` Gabriel Krisman Bertazi [this message]
2017-10-12 6:39 ` Gabriel Krisman Bertazi
2017-10-12 14:42 ` Sean Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wp40oon4.fsf@dilma.collabora.co.uk \
--to=krisman@collabora.co.uk \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=noralf@tronnes.org \
--cc=puck.chen@hisilicon.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh@kernel.org \
--cc=seanpaul@chromium.org \
--cc=treding@nvidia.com \
--cc=weiyongjun1@huawei.com \
--cc=z.liuxinliang@hisilicon.com \
--cc=zourongrong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.