Re: [Outreachy kernel] [PATCH 0/3] GPU: DRM: drm_agpsupport.c: Code cleanup

[Jani Nikula <jani.nikula@linux.intel.com>]

On Wed, 13 Sep 2017, Julia Lawall <julia.lawall@lip6.fr> wrote:
> On Wed, 13 Sep 2017, Meghana Madhyastha wrote:
>
>> These patches fix the checkpath warnings and errors
>> in drm_agpsupport.c
>>
>> Meghana Madhyastha (3):
>>   GPU: DRM: Moved EXPORT_SYMBOL so that it immediately followed its
>>     function
>>   GPU: DRM: Replace "foo * bar" with "foo *bar"
>>   GPU: DRM: Remove assignment in if condition
>>
>>  drivers/gpu/drm/drm_agpsupport.c | 41 ++++++++++++++++++++++------------------

Please try 'git log --oneline -- drivers/gpu/drm/drm_agpsupport.c' and
observe the commit subject prefix used. Please try to follow the style
in the area you're changing, not some generic rules.

>>  1 file changed, 23 insertions(+), 18 deletions(-)
>
> Are the DRM people going to pick this up?  Because Greg will not.  If you
> do something that is outside staging at a mentor's suggestion it could be
> good to make explicit that the mentor will make sure that the patch will
> be applied.

I'm not generally fond of pure checkpatch fixes, but patch 3 alone I
want enough to pick them all up. ;)

But please do submit the series to dri-devel@lists.freedesktop.org. As a
matter of policy, we don't apply patches not posted to our subsystem
mailing list.

The scripts/get_maintainer.pl script will help you with the lists, but
do use discretion. The script is sometimes misguided, adding *way* too
many lists and people. Just the main subsystem list and
supporters/maintainers are usually enough.


Thanks,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center